)]}'
{"zun/network/kuryr_network.py":[{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"fe41d33e702fafde9bf93365936866d095990fea","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        if v6_subnet:"},{"line_number":84,"context_line":"            options[\u0027neutron.pool.v6.uuid\u0027] \u003d v6_subnet.get(\u0027subnetpool_id\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if v4_subnet:"},{"line_number":87,"context_line":"            LOG.debug(\"Calling docker.create_network with ipv4 addresses \","},{"line_number":88,"context_line":"                      \"to create network %s, ipam_options %s, options %s\","},{"line_number":89,"context_line":"                      name, ipam_options, options[\u0027neutron.pool.uuid\u0027])"},{"line_number":90,"context_line":"        if v6_subnet:"},{"line_number":91,"context_line":"            LOG.debug(\"Calling docker.create_network with ipv6 addresses \","},{"line_number":92,"context_line":"                      \"to create network %s, ipam_options %s, options %s\","},{"line_number":93,"context_line":"                      name, ipam_options, options[\u0027neutron.pool.v6.uuid\u0027])"},{"line_number":94,"context_line":"        docker_network \u003d self.docker.create_network("},{"line_number":95,"context_line":"            name\u003dname,"},{"line_number":96,"context_line":"            driver\u003d\u0027kuryr\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_a0cd1c86","line":93,"range":{"start_line":86,"start_character":8,"end_line":93,"end_character":74},"updated":"2017-06-05 03:26:51.000000000","message":"I think it is better to reuse the if statement, e.g. moving the log.debug after line 82 and 84.","commit_id":"e04c0dd105ca0c87e944178acf141d9db7004f2c"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"88c1d60c568124c9362f7685d9f262ddaa732c05","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        if v6_subnet:"},{"line_number":84,"context_line":"            options[\u0027neutron.pool.v6.uuid\u0027] \u003d v6_subnet.get(\u0027subnetpool_id\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if v4_subnet:"},{"line_number":87,"context_line":"            LOG.debug(\"Calling docker.create_network with ipv4 addresses \","},{"line_number":88,"context_line":"                      \"to create network %s, ipam_options %s, options %s\","},{"line_number":89,"context_line":"                      name, ipam_options, options[\u0027neutron.pool.uuid\u0027])"},{"line_number":90,"context_line":"        if v6_subnet:"},{"line_number":91,"context_line":"            LOG.debug(\"Calling docker.create_network with ipv6 addresses \","},{"line_number":92,"context_line":"                      \"to create network %s, ipam_options %s, options %s\","},{"line_number":93,"context_line":"                      name, ipam_options, options[\u0027neutron.pool.v6.uuid\u0027])"},{"line_number":94,"context_line":"        docker_network \u003d self.docker.create_network("},{"line_number":95,"context_line":"            name\u003dname,"},{"line_number":96,"context_line":"            driver\u003d\u0027kuryr\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_4609b893","line":93,"range":{"start_line":86,"start_character":8,"end_line":93,"end_character":74},"in_reply_to":"df140735_a0cd1c86","updated":"2017-06-05 05:49:11.000000000","message":"Done","commit_id":"e04c0dd105ca0c87e944178acf141d9db7004f2c"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d722154a1367e1f4d4c838c4fed5a94522b3897a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                      name, ipam_options, options[\u0027neutron.pool.uuid\u0027])"},{"line_number":86,"context_line":"        if v6_subnet:"},{"line_number":87,"context_line":"            options[\u0027neutron.pool.v6.uuid\u0027] \u003d v6_subnet.get(\u0027subnetpool_id\u0027)"},{"line_number":88,"context_line":"            LOG.debug(\"Calling docker.create_network with ipv6 addresses \","},{"line_number":89,"context_line":"                      \"to create network %s, ipam_options %s, options %s\","},{"line_number":90,"context_line":"                      name, ipam_options, options[\u0027neutron.pool.v6.uuid\u0027])"},{"line_number":91,"context_line":"        docker_network \u003d self.docker.create_network("}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_ae0dfde8","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":21},"updated":"2017-06-05 15:01:23.000000000","message":"Shengqin,\n\nThis will log the almost the similar information twice. Suggest to consolidate them into one as following (untested):\n\n        if v4_subnet:\n            options[\u0027neutron.pool.uuid\u0027] \u003d v4_subnet.get(\u0027subnetpool_id\u0027)\n        if v6_subnet:\n            options[\u0027neutron.pool.v6.uuid\u0027] \u003d v6_subnet.get(\u0027subnetpool_id\u0027)\n        LOG.debug(\"Calling docker.create_network \",\n                      \"to create network %s, ipam_options %s, options %s\",\n                      name, ipam_options, options[\u0027neutron.pool.uuid\u0027])","commit_id":"52e388cd8ddaa3584b31546f04735b0e64728501"}]}
