)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b1dc5db48896d80013a2ca42303fe1da6f4e82fc","unresolved":false,"context_lines":[{"line_number":588,"context_line":"        compute_api.container_commit(context, container,"},{"line_number":589,"context_line":"                                     kw.get(\u0027repository\u0027, None),"},{"line_number":590,"context_line":"                                     kw.get(\u0027tag\u0027, None))"},{"line_number":591,"context_line":"        pecan.response.status \u003d 202"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_73ceb263","side":"PARENT","line":591,"range":{"start_line":591,"start_character":32,"end_line":591,"end_character":35},"updated":"2017-06-05 14:55:53.000000000","message":"I think we still want to return 202 since it is the correct status code. Suggest to move this line up instead of deleting it.","commit_id":"14d3c88211eb3962448e07c5e2e6637b7c0c8be4"}],"zun/compute/manager.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b1dc5db48896d80013a2ca42303fe1da6f4e82fc","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        LOG.debug(\u0027Commit the container: %s\u0027, container.uuid)"},{"line_number":522,"context_line":"        container_image \u003d None"},{"line_number":523,"context_line":"        try:"},{"line_number":524,"context_line":"            container_image \u003d self.driver.get_image(repository + \u0027:\u0027 + tag)"},{"line_number":525,"context_line":"        except exception.DockerError as e:"},{"line_number":526,"context_line":"            LOG.error(\"Error occurred while calling docker get_image API: %s\","},{"line_number":527,"context_line":"                      six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_f3088292","line":524,"range":{"start_line":524,"start_character":35,"end_line":524,"end_character":41},"updated":"2017-06-05 14:55:53.000000000","message":"@miao,\n\nHere will retrieve the image from docker, which is not the goal. The goal is to retrieve the ID of the snapshot image (i.e. which is the glance image we are going to create). Suggest to change it to something like below:\n\n  snapshot_image \u003d image_driver.create_image(repository)\n\nThis requires a refactoring of the image driver in the following ways:\n\n* In https://github.com/openstack/zun/blob/master/zun/image/driver.py#L107 , split \"upload_image\" into two methods: \"create_image\" and \"upload_image_data\". \n* In this line, call \"create_image\" as I mentioned above.\n* In line #534, call \"upload_image_data\" instead.\n\nHope it is clear. Please feel free to ping me in IRC if you need further help for this.","commit_id":"9e107fa7a3370bf38965aef4ae2cfd8152c39f64"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"3bb2f69e51ac3bbc1474544f62c387373bfca4ec","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        LOG.debug(\u0027Commit the container: %s\u0027, container.uuid)"},{"line_number":522,"context_line":"        container_image \u003d None"},{"line_number":523,"context_line":"        try:"},{"line_number":524,"context_line":"            container_image \u003d self.driver.get_image(repository + \u0027:\u0027 + tag)"},{"line_number":525,"context_line":"        except exception.DockerError as e:"},{"line_number":526,"context_line":"            LOG.error(\"Error occurred while calling docker get_image API: %s\","},{"line_number":527,"context_line":"                      six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_4b164e4b","line":524,"range":{"start_line":524,"start_character":35,"end_line":524,"end_character":41},"in_reply_to":"df140735_f3088292","updated":"2017-06-05 16:49:08.000000000","message":"I agree with Hongbin. During commit, we create two images: one docker image through docker commit; another glance image through glance driver.\nPlease keep in mind, the get_image() call in original implementation is done after docker commit(), e.g. a new docker image created after commit(). The order is important.","commit_id":"9e107fa7a3370bf38965aef4ae2cfd8152c39f64"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"ee5d396f7049152a1c4ac2aaad5734802fed5fe6","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        snapshot_image \u003d None"},{"line_number":523,"context_line":"        try:"},{"line_number":524,"context_line":"            snapshot_image \u003d image_driver.create_image(context, repository,"},{"line_number":525,"context_line":"                                                       glance.GlanceDriver())"},{"line_number":526,"context_line":"        except exception.DockerError as e:"},{"line_number":527,"context_line":"            LOG.error(\"Error occurred while calling glance \""},{"line_number":528,"context_line":"                      \"create_image API: %s\","}],"source_content_type":"text/x-python","patch_set":4,"id":"bf091321_57f34a9f","line":525,"range":{"start_line":525,"start_character":55,"end_line":525,"end_character":74},"updated":"2017-06-08 14:55:57.000000000","message":"Why is glance hard coded here?","commit_id":"1c69d3c85701da1650b34b4f4586ca0e4a70ac25"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"da7ae3c1c24422588681162a1baaddf0d89d3fbf","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        snapshot_image \u003d None"},{"line_number":523,"context_line":"        try:"},{"line_number":524,"context_line":"            snapshot_image \u003d image_driver.create_image(context, repository,"},{"line_number":525,"context_line":"                                                       glance.GlanceDriver())"},{"line_number":526,"context_line":"        except exception.DockerError as e:"},{"line_number":527,"context_line":"            LOG.error(\"Error occurred while calling glance \""},{"line_number":528,"context_line":"                      \"create_image API: %s\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_2791d253","line":525,"range":{"start_line":525,"start_character":55,"end_line":525,"end_character":74},"in_reply_to":"7f231b9d_f12ddfa8","updated":"2017-06-10 17:17:08.000000000","message":"@miao,\n\nFor clarifying Madhuri\u0027s question, you could add a note on top to explain the rational (like this: https://github.com/openstack/zun/blob/master/zun/compute/rpcapi.py#L159) . From my understanding, one of the reason is because glance is the only driver that support image uploading. This allows us to upload the snapshot image to there. The other image driver is docker, which doesn\u0027t support image upload to DockerHub yet (and I don\u0027t know if it makes sense to add support for it). As a plus, you could also create a bug for that and put the link of the bug here.","commit_id":"1c69d3c85701da1650b34b4f4586ca0e4a70ac25"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"969a84ca0776b46dd76c746da969b2f2da03d750","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        snapshot_image \u003d None"},{"line_number":523,"context_line":"        try:"},{"line_number":524,"context_line":"            snapshot_image \u003d image_driver.create_image(context, repository,"},{"line_number":525,"context_line":"                                                       glance.GlanceDriver())"},{"line_number":526,"context_line":"        except exception.DockerError as e:"},{"line_number":527,"context_line":"            LOG.error(\"Error occurred while calling glance \""},{"line_number":528,"context_line":"                      \"create_image API: %s\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_f12ddfa8","line":525,"range":{"start_line":525,"start_character":55,"end_line":525,"end_character":74},"in_reply_to":"bf091321_57f34a9f","updated":"2017-06-10 05:12:55.000000000","message":"It is refer to \"upload_image\" in line537. Can you give a better suggestion?","commit_id":"1c69d3c85701da1650b34b4f4586ca0e4a70ac25"}]}
