)]}'
{"zun/container/docker/utils.py":[{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"f89a1b107f2390917c17271c99fa8c08ea2c2a24","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        raise exception.DockerError(error_msg\u003dsix.text_type(e))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class DockerHTTPClient(docker.APIClient):"},{"line_number":44,"context_line":"    def __init__(self, url\u003dCONF.docker.api_url,"},{"line_number":45,"context_line":"                 ver\u003dCONF.docker.docker_remote_api_version,"},{"line_number":46,"context_line":"                 timeout\u003dCONF.docker.default_timeout,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_1e3cdfbd","line":43,"range":{"start_line":43,"start_character":30,"end_line":43,"end_character":39},"updated":"2017-06-20 09:11:35.000000000","message":"I think this should not be APIClient, APIClient is still the 1.0 compatible API in docker package.","commit_id":"052a1a2d25407e028a76e15cbcf1d1ff66c9c2ba"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"cfebc6f753a3381ab01da09b4ed31b5ef7b79aea","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        raise exception.DockerError(error_msg\u003dsix.text_type(e))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class DockerHTTPClient(docker.APIClient):"},{"line_number":44,"context_line":"    def __init__(self, url\u003dCONF.docker.api_url,"},{"line_number":45,"context_line":"                 ver\u003dCONF.docker.docker_remote_api_version,"},{"line_number":46,"context_line":"                 timeout\u003dCONF.docker.default_timeout,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_52180c80","line":43,"range":{"start_line":43,"start_character":30,"end_line":43,"end_character":39},"in_reply_to":"5f201791_c3ec55f5","updated":"2017-06-21 02:55:36.000000000","message":"I see. we can call low level api and upgrade docker client to 2.0 package.","commit_id":"052a1a2d25407e028a76e15cbcf1d1ff66c9c2ba"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"1fbf7e6742bbd0fd59d26ba30614d499bdb22ccd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        raise exception.DockerError(error_msg\u003dsix.text_type(e))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class DockerHTTPClient(docker.APIClient):"},{"line_number":44,"context_line":"    def __init__(self, url\u003dCONF.docker.api_url,"},{"line_number":45,"context_line":"                 ver\u003dCONF.docker.docker_remote_api_version,"},{"line_number":46,"context_line":"                 timeout\u003dCONF.docker.default_timeout,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_1ec50c8f","line":43,"range":{"start_line":43,"start_character":30,"end_line":43,"end_character":39},"in_reply_to":"7f231b9d_1e3cdfbd","updated":"2017-06-20 16:29:41.000000000","message":"ACK. I will look into that.","commit_id":"052a1a2d25407e028a76e15cbcf1d1ff66c9c2ba"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ca0d36262c03a65c4274101feb21d399b3d5fdf4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        raise exception.DockerError(error_msg\u003dsix.text_type(e))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class DockerHTTPClient(docker.APIClient):"},{"line_number":44,"context_line":"    def __init__(self, url\u003dCONF.docker.api_url,"},{"line_number":45,"context_line":"                 ver\u003dCONF.docker.docker_remote_api_version,"},{"line_number":46,"context_line":"                 timeout\u003dCONF.docker.default_timeout,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_c3ec55f5","line":43,"range":{"start_line":43,"start_character":30,"end_line":43,"end_character":39},"in_reply_to":"7f231b9d_1e3cdfbd","updated":"2017-06-20 21:09:29.000000000","message":"This is a good point.\n\nAccording to the documentation [1], APIClient is a low-level API that is one-to-one mapping with the Docker REST API. The docs suggested to use low-level API if we needs extra flexibility and power. Therefore, I think it is acceptable to leverage APIClient for now. This would allow us to quickly fix the issues incurred by implacability between the old and new packages.\n\nWith that said, we could consider migrating to the high-level API in the future, but that looks like a long-term shoot. I would leave the BP open to keep track of this.\n\n[1] https://docker-py.readthedocs.io/en/stable/api.html","commit_id":"052a1a2d25407e028a76e15cbcf1d1ff66c9c2ba"}]}