)]}'
{"zun/container/docker/driver.py":[{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"ca7d69b7bb57f5c0bd8d67cc1488ce10537744c0","unresolved":false,"context_lines":[{"line_number":687,"context_line":"            network_api \u003d zun_network.api(context\u003dcontext, docker_api\u003ddocker)"},{"line_number":688,"context_line":"            sandbox \u003d docker.inspect_container(sandbox_id)"},{"line_number":689,"context_line":"            for network in sandbox[\"NetworkSettings\"][\"Networks\"]:"},{"line_number":690,"context_line":"                network_api.add_security_groups_to_container("},{"line_number":691,"context_line":"                    container, security_group_ids, sandbox_id)"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def get_available_nodes(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_07641d49","line":690,"range":{"start_line":690,"start_character":28,"end_line":690,"end_character":60},"updated":"2017-06-26 01:54:21.000000000","message":"Nit, I do not think rename to \u0027add_security_group_to_container\u0027 is a good idea. As there are two type of security_group in nova, one is on the compute node, one is the neutron security_group. I think the security group in zun now is the neutron security group. Maybe we will need to add the compute side security group later. So seems \u0027add_security_group_to_ports\u0027 is better here.","commit_id":"c9c5f4d3bd3ea8947ef43e7067bbd3e473cacb0e"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"63042219cd47d86e1ed95c0b848e9ff86503e898","unresolved":false,"context_lines":[{"line_number":687,"context_line":"            network_api \u003d zun_network.api(context\u003dcontext, docker_api\u003ddocker)"},{"line_number":688,"context_line":"            sandbox \u003d docker.inspect_container(sandbox_id)"},{"line_number":689,"context_line":"            for network in sandbox[\"NetworkSettings\"][\"Networks\"]:"},{"line_number":690,"context_line":"                network_api.add_security_groups_to_container("},{"line_number":691,"context_line":"                    container, security_group_ids, sandbox_id)"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def get_available_nodes(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_a710c9a9","line":690,"range":{"start_line":690,"start_character":28,"end_line":690,"end_character":60},"updated":"2017-06-26 01:53:56.000000000","message":"Nit, I do not think rename to \u0027add_security_group_to_container\u0027 is a good idea. As there are two type of security_group in nova, one is on the compute node, one is the neutron security_group. I think the security group in zun now is the neutron security group. Maybe we will need to add the compute side security group later. So seems \u0027add_security_group_to_ports\u0027 is better here.","commit_id":"c9c5f4d3bd3ea8947ef43e7067bbd3e473cacb0e"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b11c762c856e44cb7bef1e5335116706f8cf90b7","unresolved":false,"context_lines":[{"line_number":687,"context_line":"            network_api \u003d zun_network.api(context\u003dcontext, docker_api\u003ddocker)"},{"line_number":688,"context_line":"            sandbox \u003d docker.inspect_container(sandbox_id)"},{"line_number":689,"context_line":"            for network in sandbox[\"NetworkSettings\"][\"Networks\"]:"},{"line_number":690,"context_line":"                network_api.add_security_groups_to_container("},{"line_number":691,"context_line":"                    container, security_group_ids, sandbox_id)"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def get_available_nodes(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_8c15db9e","line":690,"range":{"start_line":690,"start_character":28,"end_line":690,"end_character":60},"in_reply_to":"5f201791_07641d49","updated":"2017-06-26 15:33:40.000000000","message":"Done","commit_id":"c9c5f4d3bd3ea8947ef43e7067bbd3e473cacb0e"}]}