)]}'
{"zun/container/docker/driver.py":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"073ec76ce4a8e3482812395cc06fcfa0125d20d5","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                        return"},{"line_number":154,"context_line":"                    raise"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _cleanup_network_for_container(self, container, network_api):"},{"line_number":157,"context_line":"        sandbox_id \u003d self.get_sandbox_id(container)"},{"line_number":158,"context_line":"        for name in container.addresses:"},{"line_number":159,"context_line":"            network_api.disconnect_container_from_network(container, name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_10068a1e","line":156,"range":{"start_line":156,"start_character":4,"end_line":156,"end_character":69},"updated":"2017-07-05 03:02:11.000000000","message":"def _clean_network_for_container(self, container, network_api, sanbox_id):","commit_id":"d69d7444af74a4559be96cc86ec6b639f112cfff"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"602cfdf5dbe2d2ddff58eee49411fae9927b2956","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                        return"},{"line_number":154,"context_line":"                    raise"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _cleanup_network_for_container(self, container, network_api):"},{"line_number":157,"context_line":"        sandbox_id \u003d self.get_sandbox_id(container)"},{"line_number":158,"context_line":"        for name in container.addresses:"},{"line_number":159,"context_line":"            network_api.disconnect_container_from_network(container, name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_30fb71c1","line":156,"range":{"start_line":156,"start_character":4,"end_line":156,"end_character":69},"in_reply_to":"3f1d235d_10068a1e","updated":"2017-07-06 23:00:07.000000000","message":"Done","commit_id":"d69d7444af74a4559be96cc86ec6b639f112cfff"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"073ec76ce4a8e3482812395cc06fcfa0125d20d5","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                    raise"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _cleanup_network_for_container(self, container, network_api):"},{"line_number":157,"context_line":"        sandbox_id \u003d self.get_sandbox_id(container)"},{"line_number":158,"context_line":"        for name in container.addresses:"},{"line_number":159,"context_line":"            network_api.disconnect_container_from_network(container, name,"},{"line_number":160,"context_line":"                                                          sandbox_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_65050214","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":51},"updated":"2017-07-05 03:02:11.000000000","message":"Don\u0027t need this line. Because in `delete_sandbox` method, it already passed `sandbox_id`. Take a look at my above comment.","commit_id":"d69d7444af74a4559be96cc86ec6b639f112cfff"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"602cfdf5dbe2d2ddff58eee49411fae9927b2956","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                    raise"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _cleanup_network_for_container(self, container, network_api):"},{"line_number":157,"context_line":"        sandbox_id \u003d self.get_sandbox_id(container)"},{"line_number":158,"context_line":"        for name in container.addresses:"},{"line_number":159,"context_line":"            network_api.disconnect_container_from_network(container, name,"},{"line_number":160,"context_line":"                                                          sandbox_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_10f635d8","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":51},"in_reply_to":"3f1d235d_65050214","updated":"2017-07-06 23:00:07.000000000","message":"Done","commit_id":"d69d7444af74a4559be96cc86ec6b639f112cfff"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"073ec76ce4a8e3482812395cc06fcfa0125d20d5","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    def delete_sandbox(self, context, container, sandbox_id):"},{"line_number":612,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":613,"context_line":"            network_api \u003d zun_network.api(context\u003dcontext, docker_api\u003ddocker)"},{"line_number":614,"context_line":"            self._cleanup_network_for_container(container, network_api)"},{"line_number":615,"context_line":"            try:"},{"line_number":616,"context_line":"                docker.remove_container(sandbox_id, force\u003dTrue)"},{"line_number":617,"context_line":"            except errors.APIError as api_error:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_f01f8e58","line":614,"range":{"start_line":614,"start_character":65,"end_line":614,"end_character":71},"updated":"2017-07-05 03:02:11.000000000","message":"pass `sanbox_id` here :)","commit_id":"d69d7444af74a4559be96cc86ec6b639f112cfff"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"98eee0b2f28f5447aeccee1951faeb57109badeb","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    def delete_sandbox(self, context, container, sandbox_id):"},{"line_number":612,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":613,"context_line":"            network_api \u003d zun_network.api(context\u003dcontext, docker_api\u003ddocker)"},{"line_number":614,"context_line":"            self._cleanup_network_for_container(container, network_api)"},{"line_number":615,"context_line":"            try:"},{"line_number":616,"context_line":"                docker.remove_container(sandbox_id, force\u003dTrue)"},{"line_number":617,"context_line":"            except errors.APIError as api_error:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_14a9be22","line":614,"range":{"start_line":614,"start_character":65,"end_line":614,"end_character":71},"in_reply_to":"3f1d235d_f01f8e58","updated":"2017-07-05 18:55:25.000000000","message":"+1","commit_id":"d69d7444af74a4559be96cc86ec6b639f112cfff"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"602cfdf5dbe2d2ddff58eee49411fae9927b2956","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    def delete_sandbox(self, context, container, sandbox_id):"},{"line_number":612,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":613,"context_line":"            network_api \u003d zun_network.api(context\u003dcontext, docker_api\u003ddocker)"},{"line_number":614,"context_line":"            self._cleanup_network_for_container(container, network_api)"},{"line_number":615,"context_line":"            try:"},{"line_number":616,"context_line":"                docker.remove_container(sandbox_id, force\u003dTrue)"},{"line_number":617,"context_line":"            except errors.APIError as api_error:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_f00059ad","line":614,"range":{"start_line":614,"start_character":65,"end_line":614,"end_character":71},"in_reply_to":"3f1d235d_f01f8e58","updated":"2017-07-06 23:00:07.000000000","message":"Done","commit_id":"d69d7444af74a4559be96cc86ec6b639f112cfff"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"18922c5bc9bddef61d32b65444ee7135edc76d71","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    def delete_sandbox(self, context, container, sandbox_id):"},{"line_number":612,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":613,"context_line":"            network_api \u003d zun_network.api(context\u003dcontext, docker_api\u003ddocker)"},{"line_number":614,"context_line":"            self._cleanup_network_for_container(container, network_api)"},{"line_number":615,"context_line":"            try:"},{"line_number":616,"context_line":"                docker.remove_container(sandbox_id, force\u003dTrue)"},{"line_number":617,"context_line":"            except errors.APIError as api_error:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_d0d46beb","line":614,"range":{"start_line":614,"start_character":65,"end_line":614,"end_character":71},"in_reply_to":"3f1d235d_f01f8e58","updated":"2017-07-05 22:56:16.000000000","message":"Thanks for the suggestion. I will take into that.","commit_id":"d69d7444af74a4559be96cc86ec6b639f112cfff"}]}
