)]}'
{"zun/network/kuryr_network.py":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2cd5112a57bad76ba0d501f9dbd4544ce629436e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            container_id \u003d container.container_id"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        neutron_ports \u003d set()"},{"line_number":176,"context_line":"        if container.addresses and neutron_network_id:"},{"line_number":177,"context_line":"            addrs_list \u003d container.addresses.get(neutron_network_id, [])"},{"line_number":178,"context_line":"            for addr in addrs_list:"},{"line_number":179,"context_line":"                port_id \u003d addr[\u0027port\u0027]"},{"line_number":180,"context_line":"                neutron_ports.add(port_id)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            self.docker.disconnect_container_from_network(container_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_c0d8167c","line":180,"range":{"start_line":176,"start_character":8,"end_line":180,"end_character":42},"updated":"2017-08-04 04:47:06.000000000","message":"If neutron_network_id is None (default), neutron_ports will be an empty set. Could it raise any problems?\n\ndisconnect_container_from_network still be used oin zun/container/docker/driver.py without neutron_network_id.","commit_id":"268e2872c67796466f104c5bd2aca84e2275d8fa"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"13d49cd68ff0ef7ba66a18120f02403c65fe5298","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            container_id \u003d container.container_id"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        neutron_ports \u003d set()"},{"line_number":176,"context_line":"        if container.addresses and neutron_network_id:"},{"line_number":177,"context_line":"            addrs_list \u003d container.addresses.get(neutron_network_id, [])"},{"line_number":178,"context_line":"            for addr in addrs_list:"},{"line_number":179,"context_line":"                port_id \u003d addr[\u0027port\u0027]"},{"line_number":180,"context_line":"                neutron_ports.add(port_id)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            self.docker.disconnect_container_from_network(container_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_cd6f2129","line":180,"range":{"start_line":176,"start_character":8,"end_line":180,"end_character":42},"in_reply_to":"df3967d1_c0d8167c","updated":"2017-08-04 14:17:09.000000000","message":"For disconnecting non-kuryr network (i.e. the bridge network [1]), the neutron_network_id needs to be None. However, agree with you that it could raise problem on disconnecting kuryr network without setting this parameter. Do you have an improving suggestion?\n\n[1] https://github.com/openstack/zun/blob/master/zun/container/docker/driver.py#L191","commit_id":"268e2872c67796466f104c5bd2aca84e2275d8fa"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"eff0dce04fa50b6e8e252ba8136fa32702fd669c","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            container_id \u003d container.container_id"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        neutron_ports \u003d set()"},{"line_number":176,"context_line":"        if container.addresses and neutron_network_id:"},{"line_number":177,"context_line":"            addrs_list \u003d container.addresses.get(neutron_network_id, [])"},{"line_number":178,"context_line":"            for addr in addrs_list:"},{"line_number":179,"context_line":"                port_id \u003d addr[\u0027port\u0027]"},{"line_number":180,"context_line":"                neutron_ports.add(port_id)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            self.docker.disconnect_container_from_network(container_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf3e73b7_710e80e6","line":180,"range":{"start_line":176,"start_character":8,"end_line":180,"end_character":42},"in_reply_to":"df3967d1_cd6f2129","updated":"2017-08-07 03:38:09.000000000","message":"Sorry for the late reply. Maybe we can check the network driver then define neutron_network_id? I think we can do it via docker [1]. But it will increase the time to execute method and I\u0027m not sure about this idea.\n\n[1] http://paste.openstack.org/show/617630/","commit_id":"268e2872c67796466f104c5bd2aca84e2275d8fa"}]}