)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"4b6cb6ed366c14ce434b8a7c421ae6ed56865e55","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    def _build_requested_networks(self, context, nets):"},{"line_number":301,"context_line":"        neutron_api \u003d neutron.NeutronAPI(context)"},{"line_number":302,"context_line":"        requested_networks \u003d []"},{"line_number":303,"context_line":"        for net in nets:"},{"line_number":304,"context_line":"            if net.get(\u0027port\u0027):"},{"line_number":305,"context_line":"                port \u003d neutron_api.get_neutron_port(net[\u0027port\u0027])"},{"line_number":306,"context_line":"                neutron_api.ensure_neutron_port_usable(port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_dc5f830c","line":303,"updated":"2017-08-07 04:40:04.000000000","message":"IMO, you should add the NOTE (which in commit message) here.\n\nNOTE: If both \u0027port\u0027 and \u0027network\u0027 is set via the \u0027nets\u0027 parameter, the \u0027network\u0027 will be ignored since Zun will use the network of the existing port.","commit_id":"f740893323f81d59b0673dc68865dd85e76648af"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"1cf3818a06933880f8f6d21e2ecb64f2017e9270","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                                           \u0027port\u0027: port[\u0027id\u0027],"},{"line_number":310,"context_line":"                                           \u0027v4-fixed-ip\u0027: \u0027\u0027,"},{"line_number":311,"context_line":"                                           \u0027v6-fixed-ip\u0027: \u0027\u0027})"},{"line_number":312,"context_line":"            elif net.get(\u0027network\u0027):"},{"line_number":313,"context_line":"                network \u003d neutron_api.get_neutron_network(net[\u0027network\u0027])"},{"line_number":314,"context_line":"                requested_networks.append({\u0027network\u0027: network[\u0027id\u0027],"},{"line_number":315,"context_line":"                                           \u0027port\u0027: \u0027\u0027,"},{"line_number":316,"context_line":"                                           \u0027v4-fixed-ip\u0027: \u0027\u0027,"},{"line_number":317,"context_line":"                                           \u0027v6-fixed-ip\u0027: \u0027\u0027})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if not requested_networks:"},{"line_number":320,"context_line":"            # Find an available neutron net and create docker network by"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_95f976c9","line":317,"range":{"start_line":312,"start_character":11,"end_line":317,"end_character":62},"updated":"2017-08-11 08:54:10.000000000","message":"Hongbin, this is not according to your commit message.\nIf both port and network is passed in nets, the network will be used and port will be ignored due to this condition.\nThe first check should be for network and then the second check for port. So that port is given preference.","commit_id":"cd9d2dbbce3ac038ea8846cfb59701ab6b126be7"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"90101e5439a091b206c152887ccefadd408e36ec","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                                           \u0027port\u0027: port[\u0027id\u0027],"},{"line_number":310,"context_line":"                                           \u0027v4-fixed-ip\u0027: \u0027\u0027,"},{"line_number":311,"context_line":"                                           \u0027v6-fixed-ip\u0027: \u0027\u0027})"},{"line_number":312,"context_line":"            elif net.get(\u0027network\u0027):"},{"line_number":313,"context_line":"                network \u003d neutron_api.get_neutron_network(net[\u0027network\u0027])"},{"line_number":314,"context_line":"                requested_networks.append({\u0027network\u0027: network[\u0027id\u0027],"},{"line_number":315,"context_line":"                                           \u0027port\u0027: \u0027\u0027,"},{"line_number":316,"context_line":"                                           \u0027v4-fixed-ip\u0027: \u0027\u0027,"},{"line_number":317,"context_line":"                                           \u0027v6-fixed-ip\u0027: \u0027\u0027})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if not requested_networks:"},{"line_number":320,"context_line":"            # Find an available neutron net and create docker network by"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_97f611f9","line":317,"range":{"start_line":312,"start_character":11,"end_line":317,"end_character":62},"in_reply_to":"9f436f4f_95f976c9","updated":"2017-08-11 14:17:51.000000000","message":"@Madhuri, i think if port and network both are present then port will be used and commit message also says the same.","commit_id":"cd9d2dbbce3ac038ea8846cfb59701ab6b126be7"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"33467e465ffb719346e2cb74b4138fa9de78e561","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                                           \u0027port\u0027: port[\u0027id\u0027],"},{"line_number":310,"context_line":"                                           \u0027v4-fixed-ip\u0027: \u0027\u0027,"},{"line_number":311,"context_line":"                                           \u0027v6-fixed-ip\u0027: \u0027\u0027})"},{"line_number":312,"context_line":"            elif net.get(\u0027network\u0027):"},{"line_number":313,"context_line":"                network \u003d neutron_api.get_neutron_network(net[\u0027network\u0027])"},{"line_number":314,"context_line":"                requested_networks.append({\u0027network\u0027: network[\u0027id\u0027],"},{"line_number":315,"context_line":"                                           \u0027port\u0027: \u0027\u0027,"},{"line_number":316,"context_line":"                                           \u0027v4-fixed-ip\u0027: \u0027\u0027,"},{"line_number":317,"context_line":"                                           \u0027v6-fixed-ip\u0027: \u0027\u0027})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if not requested_networks:"},{"line_number":320,"context_line":"            # Find an available neutron net and create docker network by"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_f2d32b37","line":317,"range":{"start_line":312,"start_character":11,"end_line":317,"end_character":62},"in_reply_to":"9f436f4f_97f611f9","updated":"2017-08-11 14:53:07.000000000","message":"Yes.","commit_id":"cd9d2dbbce3ac038ea8846cfb59701ab6b126be7"}],"zun/network/neutron.py":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"4b6cb6ed366c14ce434b8a7c421ae6ed56865e55","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            networks \u003d self.neutron.list_networks(name\u003dnetwork)[\u0027networks\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        if len(networks) \u003d\u003d 0:"},{"line_number":43,"context_line":"            raise exception.NetworkNotFound(network\u003dnetwork)"},{"line_number":44,"context_line":"        elif len(networks) \u003e 1:"},{"line_number":45,"context_line":"            raise exception.Conflict(_("},{"line_number":46,"context_line":"                \u0027Multiple neutron networks exist with same name. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_bc9a7fc2","line":43,"range":{"start_line":43,"start_character":28,"end_line":43,"end_character":43},"updated":"2017-08-07 04:40:04.000000000","message":"This exception isn\u0027t defined.","commit_id":"f740893323f81d59b0673dc68865dd85e76648af"}]}