)]}'
{"zun/db/sqlalchemy/api.py":[{"author":{"_account_id":15122,"name":"Kiseok Kim","email":"kiseok7@gmail.com","username":"Kiseok"},"change_message_id":"9d1f0b4117abe3cd63096fc1f746e74250a2d8a2","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        return ref"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _add_volume_mappings_filters(self, query, filters):"},{"line_number":242,"context_line":"        if filters is None:"},{"line_number":243,"context_line":"            filters \u003d {}"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        filter_names \u003d [\u0027project_id\u0027, \u0027user_id\u0027, \u0027volume_id\u0027, \u0027container_path\u0027,"},{"line_number":246,"context_line":"                        \u0027container_uuid\u0027, \u0027volume_provider\u0027]"},{"line_number":247,"context_line":"        for name in filter_names:"},{"line_number":248,"context_line":"            if name in filters:"},{"line_number":249,"context_line":"                query \u003d query.filter_by(**{name: filters[name]})"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        return query"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_e64897b3","line":249,"range":{"start_line":242,"start_character":8,"end_line":249,"end_character":64},"updated":"2017-08-31 03:24:42.000000000","message":"I think, there is no need to loop filter_names list if filters is None or empty({}). so this code also works i guess:\n\ndef _add_volume_mappings_filters(self, query, filters):\n    if not filters:\n        return query\n    ...","commit_id":"d99af8bfc46ce29d9e533483227d2a429294ebd5"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0ec61f4961f092eb9265519731ab250a3151b765","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        return ref"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _add_volume_mappings_filters(self, query, filters):"},{"line_number":242,"context_line":"        if filters is None:"},{"line_number":243,"context_line":"            filters \u003d {}"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        filter_names \u003d [\u0027project_id\u0027, \u0027user_id\u0027, \u0027volume_id\u0027, \u0027container_path\u0027,"},{"line_number":246,"context_line":"                        \u0027container_uuid\u0027, \u0027volume_provider\u0027]"},{"line_number":247,"context_line":"        for name in filter_names:"},{"line_number":248,"context_line":"            if name in filters:"},{"line_number":249,"context_line":"                query \u003d query.filter_by(**{name: filters[name]})"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        return query"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_22ae7698","line":249,"range":{"start_line":242,"start_character":8,"end_line":249,"end_character":64},"in_reply_to":"7f287b81_e64897b3","updated":"2017-08-31 18:41:07.000000000","message":"Good point. Done.","commit_id":"d99af8bfc46ce29d9e533483227d2a429294ebd5"}]}