)]}'
{"zun/api/controllers/base.py":[{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"19a0900c9ee9e98b2b349abbc2e8d86c9c1b771a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"class Controller(rest.RestController):"},{"line_number":98,"context_line":"    \"\"\"Base Rest Controller\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":101,"context_line":"    def _no_version_match(self, *args, **kwargs):"},{"line_number":102,"context_line":"        from pecan import request"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_a7062d1f","line":100,"range":{"start_line":100,"start_character":19,"end_line":100,"end_character":23},"updated":"2017-08-30 02:31:18.000000000","message":"seems only add the @pecan.expose(\u0027json\u0027). Could you add some comments for this function, why this should be added? Does this will solve the \u0027HTTP_ACCEPT\u0027 key error problem in ut?","commit_id":"7085fcc6d3b0128f5d16b1f19a0f855b204200d5"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"6c420c66144292d981abd0740ba01e09d02f1bc6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"class Controller(rest.RestController):"},{"line_number":98,"context_line":"    \"\"\"Base Rest Controller\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":101,"context_line":"    def _no_version_match(self, *args, **kwargs):"},{"line_number":102,"context_line":"        from pecan import request"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_a29dfb66","line":100,"range":{"start_line":100,"start_character":19,"end_line":100,"end_character":23},"in_reply_to":"7f287b81_a7062d1f","updated":"2017-08-30 02:57:37.000000000","message":"Added more details on the commit message.\n\nThe HTTP_ACCEPT key error is another problem, which should be resolved after adding \u0027ACCEPT: application/json\u0027 to headers as you did in: https://review.openstack.org/#/c/493787/10..11/zun/tests/unit/api/controllers/v1/test_containers.py","commit_id":"7085fcc6d3b0128f5d16b1f19a0f855b204200d5"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"53699472db78e581873f46dca6ca4cf1f5f3e2e5","unresolved":false,"context_lines":[{"line_number":97,"context_line":"class Controller(rest.RestController):"},{"line_number":98,"context_line":"    \"\"\"Base Rest Controller\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":101,"context_line":"    def _no_version_match(self, *args, **kwargs):"},{"line_number":102,"context_line":"        from pecan import request"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_c225a70a","line":100,"range":{"start_line":100,"start_character":4,"end_line":100,"end_character":25},"updated":"2017-08-30 03:14:11.000000000","message":"Nit. Does this wrapper will finish the http request and return json respone? Without this wrapper, pecan will route request to other action, and then the version mismatch and the request failed for other action, right?\n\nNot so familiar with pecan routing.","commit_id":"78e178500bbcd47a0eba8314faaddf20cc2fe4ed"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"6c1f463fb040db3b6bf4bb8603a07fd246506bb5","unresolved":false,"context_lines":[{"line_number":97,"context_line":"class Controller(rest.RestController):"},{"line_number":98,"context_line":"    \"\"\"Base Rest Controller\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":101,"context_line":"    def _no_version_match(self, *args, **kwargs):"},{"line_number":102,"context_line":"        from pecan import request"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_62c153e5","line":100,"range":{"start_line":100,"start_character":4,"end_line":100,"end_character":25},"in_reply_to":"7f287b81_c225a70a","updated":"2017-08-30 03:24:57.000000000","message":"Here is the implementation: https://github.com/pecan/pecan/blob/master/pecan/decorators.py#L25 . Yes, it seems this decorator will render a json response and expose this method for routing.","commit_id":"78e178500bbcd47a0eba8314faaddf20cc2fe4ed"}]}