)]}'
{"zun/api/controllers/v1/schemas/containers.py":[{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"acc91eec354c572629c23cd21bb4bbffe3c0addf","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"network_attach \u003d {"},{"line_number":185,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":186,"context_line":"    \u0027properties\u0027: {"},{"line_number":187,"context_line":"        \u0027network\u0027: {"},{"line_number":188,"context_line":"            \u0027type\u0027: \u0027string\u0027"},{"line_number":189,"context_line":"        }"},{"line_number":190,"context_line":"    },"},{"line_number":191,"context_line":"    \u0027required\u0027: [\u0027network\u0027],"},{"line_number":192,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":193,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_b0b37b4d","line":193,"range":{"start_line":184,"start_character":0,"end_line":193,"end_character":1},"updated":"2017-09-13 06:33:19.000000000","message":"it may use deepcopy such as \"network_attach \u003d copy.deepcopy(network_detach)\"","commit_id":"586c3e794e7b94dff2257a5c375d3cef104887f0"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"3bddf3df16936e05c5cfb5567dd9365f72378c1b","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"network_attach \u003d {"},{"line_number":185,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":186,"context_line":"    \u0027properties\u0027: {"},{"line_number":187,"context_line":"        \u0027network\u0027: {"},{"line_number":188,"context_line":"            \u0027type\u0027: \u0027string\u0027"},{"line_number":189,"context_line":"        }"},{"line_number":190,"context_line":"    },"},{"line_number":191,"context_line":"    \u0027required\u0027: [\u0027network\u0027],"},{"line_number":192,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":193,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_f11d6e73","line":193,"range":{"start_line":184,"start_character":0,"end_line":193,"end_character":1},"in_reply_to":"5f2577a7_b0b37b4d","updated":"2017-09-14 01:18:09.000000000","message":"Done","commit_id":"586c3e794e7b94dff2257a5c375d3cef104887f0"}],"zun/container/docker/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"c05a8a6ba327723a79ad893f419530f8940dbb25","unresolved":false,"context_lines":[{"line_number":781,"context_line":"                raise exception.ZunException(\u0027Container %(container)s has\u0027"},{"line_number":782,"context_line":"                                             \u0027 alreay connected to the network\u0027"},{"line_number":783,"context_line":"                                             \u0027%(network)s.\u0027"},{"line_number":784,"context_line":"                                             % {\u0027container\u0027: container,"},{"line_number":785,"context_line":"                                                \u0027network\u0027: network})"},{"line_number":786,"context_line":"            self._get_or_create_docker_network(context, network_api, network)"},{"line_number":787,"context_line":"            requested_network \u003d [{\u0027network\u0027: network,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_80d98484","line":784,"range":{"start_line":784,"start_character":61,"end_line":784,"end_character":70},"updated":"2017-09-11 15:44:51.000000000","message":"Log the entire container will be very verbose since it will print a lot of information. I think logging the container name or id is enough.","commit_id":"702152da6bed86a0f8946dc274efa9a1ae5d07f6"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"c05a8a6ba327723a79ad893f419530f8940dbb25","unresolved":false,"context_lines":[{"line_number":788,"context_line":"                                  \u0027port\u0027: \u0027\u0027,"},{"line_number":789,"context_line":"                                  \u0027v4-fixed-ip\u0027: \u0027\u0027,"},{"line_number":790,"context_line":"                                  \u0027v6-fixed-ip\u0027: \u0027\u0027}]"},{"line_number":791,"context_line":"            update \u003d self._setup_network_for_container(context, container,"},{"line_number":792,"context_line":"                                                       requested_network,"},{"line_number":793,"context_line":"                                                       network_api)"},{"line_number":794,"context_line":"            if update is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_80698426","line":791,"range":{"start_line":791,"start_character":26,"end_line":791,"end_character":54},"updated":"2017-09-11 15:44:51.000000000","message":"Keep in mind that this method does the following:\n\n1. Disconnect the container from the \u0027bridge\u0027 network\n2. Connect the container to the selected network\n3. Create a Neutron port.\n4. Apply container\u0027s security group(s) to the neutron port.\n\nIn the case of network_attach, I think #1 should not be performed. The behavior of #4 is inconsistent with Nova (nova interface-attach will create a neutron port with \u0027default\u0027 security group). Personally, I don\u0027t think #4 is a good idea since it is inconsistent with Nova.","commit_id":"702152da6bed86a0f8946dc274efa9a1ae5d07f6"}]}