)]}'
{"zun/network/kuryr_network.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ddcd31f55d313cfde1172fae03d60bf3a6b8e5c7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        if v4_subnet:"},{"line_number":73,"context_line":"            ipam_options[\"Options\"][\u0027neutron.pool.uuid\u0027] \u003d ("},{"line_number":74,"context_line":"                v4_subnet.get(\u0027subnetpool_id\u0027))"},{"line_number":75,"context_line":"            ipam_options[\u0027Options\u0027][\u0027neutron.subnet.name\u0027] \u003d \\"},{"line_number":76,"context_line":"                v4_subnet.get(\u0027name\u0027)"},{"line_number":77,"context_line":"            ipam_options[\u0027Options\u0027][\u0027neutron.subnet.uuid\u0027] \u003d \\"},{"line_number":78,"context_line":"                v4_subnet.get(\u0027id\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_a3dfd00a","line":75,"range":{"start_line":75,"start_character":52,"end_line":75,"end_character":56},"updated":"2017-10-05 14:23:52.000000000","message":"According to your patch in kuryr-libnetwork, it looks an exception will be raised if there are two subnets with the same name. Therefore, I would lean to use subnet uuid instead.","commit_id":"223afde3441d593043a8feca22acb541b29e84bb"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ddcd31f55d313cfde1172fae03d60bf3a6b8e5c7","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            options[\u0027neutron.pool.uuid\u0027] \u003d v4_subnet.get(\u0027subnetpool_id\u0027)"},{"line_number":85,"context_line":"            options[\u0027neutron.subnet.uuid\u0027] \u003d v4_subnet.get(\u0027id\u0027)"},{"line_number":86,"context_line":"            options[\u0027neutron.subnet.name\u0027] \u003d v4_subnet.get(\u0027name\u0027)"},{"line_number":87,"context_line":"        if v6_subnet:"},{"line_number":88,"context_line":"            ipam_options[\"Options\"][\u0027neutron.pool.v6.uuid\u0027] \u003d ("},{"line_number":89,"context_line":"                v6_subnet.get(\u0027subnetpool_id\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_03da2416","line":86,"range":{"start_line":86,"start_character":36,"end_line":86,"end_character":40},"updated":"2017-10-05 14:23:52.000000000","message":"Ditto. Prefer uuid over name.","commit_id":"223afde3441d593043a8feca22acb541b29e84bb"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ddcd31f55d313cfde1172fae03d60bf3a6b8e5c7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        if v6_subnet:"},{"line_number":88,"context_line":"            ipam_options[\"Options\"][\u0027neutron.pool.v6.uuid\u0027] \u003d ("},{"line_number":89,"context_line":"                v6_subnet.get(\u0027subnetpool_id\u0027))"},{"line_number":90,"context_line":"            ipam_options[\u0027Options\u0027][\u0027neutron.subnet.v6.name\u0027] \u003d \\"},{"line_number":91,"context_line":"                v6_subnet.get(\u0027name\u0027)"},{"line_number":92,"context_line":"            ipam_options[\u0027Options\u0027][\u0027neutron.subnet.v6.uuid\u0027] \u003d \\"},{"line_number":93,"context_line":"                v6_subnet.get(\u0027id\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_a316b0a6","line":90,"range":{"start_line":90,"start_character":55,"end_line":90,"end_character":59},"updated":"2017-10-05 14:23:52.000000000","message":"Ditto","commit_id":"223afde3441d593043a8feca22acb541b29e84bb"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ddcd31f55d313cfde1172fae03d60bf3a6b8e5c7","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            options[\u0027neutron.pool.v6.uuid\u0027] \u003d v6_subnet.get(\u0027subnetpool_id\u0027)"},{"line_number":100,"context_line":"            options[\u0027neutron.subnet.v6.uuid\u0027] \u003d v6_subnet.get(\u0027id\u0027)"},{"line_number":101,"context_line":"            options[\u0027neutron.subnet.v6.name\u0027] \u003d v6_subnet.get(\u0027name\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        LOG.debug(\"Calling docker.create_network to create network %s, \""},{"line_number":104,"context_line":"                  \"ipam_options %s, options %s\", name, ipam_options, options)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_032104fc","line":101,"range":{"start_line":101,"start_character":39,"end_line":101,"end_character":43},"updated":"2017-10-05 14:23:52.000000000","message":"Ditto","commit_id":"223afde3441d593043a8feca22acb541b29e84bb"}]}
