)]}'
{"zun/network/kuryr_network.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"51ef0b94913492041e07eb408fd7697135c36415","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                \u0027network_id\u0027: neutron_net_id,"},{"line_number":142,"context_line":"                \u0027tenant_id\u0027: self.context.project_id,"},{"line_number":143,"context_line":"                \u0027fixed_ips\u0027: [{\u0027ip_address\u0027:"},{"line_number":144,"context_line":"                              requested_network.get(\"v4-fixed-ip\") or"},{"line_number":145,"context_line":"                              requested_network.get(\"v6-fixed-ip\")}],"},{"line_number":146,"context_line":"            }"},{"line_number":147,"context_line":"            if security_groups is not None:"},{"line_number":148,"context_line":"                port_dict[\u0027security_groups\u0027] \u003d security_groups"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_a0dbee79","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":69},"updated":"2017-09-15 02:57:35.000000000","message":"Hi @wangzhh,\n\nI think we need to handle the case that neither v4-fixed-ip or v6-fixed-ip is specified. In this case, it will send an empty ip address to neutron which will fail.","commit_id":"5c84b31e6da95546e8397a4e41d891fcd4afd111"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"809ccabf6c1e32fc6f97190ea10edfc0bb2d3628","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                \u0027network_id\u0027: neutron_net_id,"},{"line_number":142,"context_line":"                \u0027tenant_id\u0027: self.context.project_id,"},{"line_number":143,"context_line":"                \u0027fixed_ips\u0027: [{\u0027ip_address\u0027:"},{"line_number":144,"context_line":"                              requested_network.get(\"v4-fixed-ip\") or"},{"line_number":145,"context_line":"                              requested_network.get(\"v6-fixed-ip\")}],"},{"line_number":146,"context_line":"            }"},{"line_number":147,"context_line":"            if security_groups is not None:"},{"line_number":148,"context_line":"                port_dict[\u0027security_groups\u0027] \u003d security_groups"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_b7757534","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":69},"in_reply_to":"5f2577a7_a0dbee79","updated":"2017-09-15 06:09:32.000000000","message":"+1","commit_id":"5c84b31e6da95546e8397a4e41d891fcd4afd111"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"d4490560ec77ff189ff8122aa9c9c97f36d0bb82","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                \u0027tenant_id\u0027: self.context.project_id,"},{"line_number":143,"context_line":"            }"},{"line_number":144,"context_line":"            ip_addr \u003d requested_network.get(\"v4-fixed-ip\") or \\"},{"line_number":145,"context_line":"                      requested_network.get(\"v6-fixed-ip\")"},{"line_number":146,"context_line":"            if ip_addr:"},{"line_number":147,"context_line":"                port_dict[\u0027fixed_ips\u0027] \u003d [{\u0027ip_address\u0027: ip_addr}]"},{"line_number":148,"context_line":"            if security_groups is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf57530f_fd548b56","line":145,"range":{"start_line":145,"start_character":12,"end_line":145,"end_character":22},"updated":"2017-09-20 04:03:52.000000000","message":"It breaks the pep8 gate - continuation line over-indented for visual indent.","commit_id":"8fd3a794cffcc1d9adf4ab51d5bb4dae4379514a"}]}