)]}'
{"zun/pci/stats.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"92cdc2cd14902be623ce5c0e2df29468d681dd47","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            pool \u003d self._find_pool(dev_pool)"},{"line_number":134,"context_line":"            if not pool:"},{"line_number":135,"context_line":"                raise exception.PciDevicePoolEmpty("},{"line_number":136,"context_line":"                    compute_node_uuid\u003ddev.compute_node_uuid,"},{"line_number":137,"context_line":"                    address\u003ddev.address)"},{"line_number":138,"context_line":"            pool[\u0027devices\u0027].remove(dev)"},{"line_number":139,"context_line":"            self._decrease_pool_count(self.pools, pool)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_fdd4d9ea","line":136,"range":{"start_line":136,"start_character":20,"end_line":136,"end_character":37},"updated":"2017-09-28 15:48:51.000000000","message":"The keyword defined in PciDevicePoolEmpty is \u0027compute_node_id\u0027 but \u0027compute_node_uuid\u0027 is used here.","commit_id":"f779bdd829630e8c9debda5e8bf09b8fad80e7d5"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"c8c7b845046e2df85d21d6f83334dff95b768c4b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            pool \u003d self._find_pool(dev_pool)"},{"line_number":134,"context_line":"            if not pool:"},{"line_number":135,"context_line":"                raise exception.PciDevicePoolEmpty("},{"line_number":136,"context_line":"                    compute_node_uuid\u003ddev.compute_node_uuid,"},{"line_number":137,"context_line":"                    address\u003ddev.address)"},{"line_number":138,"context_line":"            pool[\u0027devices\u0027].remove(dev)"},{"line_number":139,"context_line":"            self._decrease_pool_count(self.pools, pool)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_449e6ab9","line":136,"range":{"start_line":136,"start_character":20,"end_line":136,"end_character":37},"in_reply_to":"7f515b1d_fdd4d9ea","updated":"2017-09-29 01:43:06.000000000","message":"Done","commit_id":"f779bdd829630e8c9debda5e8bf09b8fad80e7d5"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"92cdc2cd14902be623ce5c0e2df29468d681dd47","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            # Failed to allocate the required number of devices"},{"line_number":159,"context_line":"            # Return the devices already allocated back to their pools"},{"line_number":160,"context_line":"            if sum([pool[\u0027count\u0027] for pool in pools]) \u003c count:"},{"line_number":161,"context_line":"                LOG.error(\"Failed to allocate PCI devices for instance.\""},{"line_number":162,"context_line":"                          \" Unassigning devices back to pools.\""},{"line_number":163,"context_line":"                          \" This should not happen, since the scheduler\""},{"line_number":164,"context_line":"                          \" should have accurate information, and allocation\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_bd0c21a5","line":161,"range":{"start_line":161,"start_character":62,"end_line":161,"end_character":70},"updated":"2017-09-28 15:48:51.000000000","message":"container","commit_id":"f779bdd829630e8c9debda5e8bf09b8fad80e7d5"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"c8c7b845046e2df85d21d6f83334dff95b768c4b","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            # Failed to allocate the required number of devices"},{"line_number":159,"context_line":"            # Return the devices already allocated back to their pools"},{"line_number":160,"context_line":"            if sum([pool[\u0027count\u0027] for pool in pools]) \u003c count:"},{"line_number":161,"context_line":"                LOG.error(\"Failed to allocate PCI devices for instance.\""},{"line_number":162,"context_line":"                          \" Unassigning devices back to pools.\""},{"line_number":163,"context_line":"                          \" This should not happen, since the scheduler\""},{"line_number":164,"context_line":"                          \" should have accurate information, and allocation\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_8490e296","line":161,"range":{"start_line":161,"start_character":62,"end_line":161,"end_character":70},"in_reply_to":"7f515b1d_bd0c21a5","updated":"2017-09-29 01:43:06.000000000","message":"Done","commit_id":"f779bdd829630e8c9debda5e8bf09b8fad80e7d5"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"92cdc2cd14902be623ce5c0e2df29468d681dd47","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    def apply_requests(self, requests, numa_cells\u003dNone):"},{"line_number":275,"context_line":"        \"\"\"Apply PCI requests to the PCI stats."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        This is used in multiple container creation, when the scheduler has to"},{"line_number":278,"context_line":"        maintain how the resources are consumed by the containers."},{"line_number":279,"context_line":"        If numa_cells is provided then only devices contained in"},{"line_number":280,"context_line":"        those nodes are considered."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_fdb97914","line":277,"range":{"start_line":277,"start_character":24,"end_line":277,"end_character":51},"updated":"2017-09-28 15:48:51.000000000","message":"It seems there is no multiple container creation in Zun (container and request is one-to-one mapping).","commit_id":"f779bdd829630e8c9debda5e8bf09b8fad80e7d5"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"2bb4b2e42e5d7f4aa6fbd65bd75df2056274c576","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    def apply_requests(self, requests, numa_cells\u003dNone):"},{"line_number":275,"context_line":"        \"\"\"Apply PCI requests to the PCI stats."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        This is used in multiple container creation, when the scheduler has to"},{"line_number":278,"context_line":"        maintain how the resources are consumed by the containers."},{"line_number":279,"context_line":"        If numa_cells is provided then only devices contained in"},{"line_number":280,"context_line":"        those nodes are considered."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_44f30a75","line":277,"range":{"start_line":277,"start_character":24,"end_line":277,"end_character":51},"in_reply_to":"7f515b1d_04cbd2a4","updated":"2017-09-29 02:14:59.000000000","message":"OK","commit_id":"f779bdd829630e8c9debda5e8bf09b8fad80e7d5"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"c8c7b845046e2df85d21d6f83334dff95b768c4b","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    def apply_requests(self, requests, numa_cells\u003dNone):"},{"line_number":275,"context_line":"        \"\"\"Apply PCI requests to the PCI stats."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        This is used in multiple container creation, when the scheduler has to"},{"line_number":278,"context_line":"        maintain how the resources are consumed by the containers."},{"line_number":279,"context_line":"        If numa_cells is provided then only devices contained in"},{"line_number":280,"context_line":"        those nodes are considered."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_04cbd2a4","line":277,"range":{"start_line":277,"start_character":24,"end_line":277,"end_character":51},"in_reply_to":"7f515b1d_fdb97914","updated":"2017-09-29 01:43:06.000000000","message":"Yes,you are right. Remove the \u0027multiple container creation\u0027, keep the logic of handle multi request, as one container may have multiple ports, so there is still have the case of multiple request. What do you think?","commit_id":"f779bdd829630e8c9debda5e8bf09b8fad80e7d5"}]}