)]}'
{"zun/container/docker/driver.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"570131c5c24766ba107bc42104090f2909111999","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        memory \u003d patch.get(\u0027memory\u0027)"},{"line_number":546,"context_line":"        if memory is not None:"},{"line_number":547,"context_line":"            args[\u0027mem_limit\u0027] \u003d memory"},{"line_number":548,"context_line":"            args[\u0027memswap_limit\u0027] \u003d -1"},{"line_number":549,"context_line":"        cpu \u003d patch.get(\u0027cpu\u0027)"},{"line_number":550,"context_line":"        if cpu is not None:"},{"line_number":551,"context_line":"            args[\u0027cpu_quota\u0027] \u003d int(100000 * cpu)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_56a60bad","line":548,"range":{"start_line":548,"start_character":12,"end_line":548,"end_character":38},"updated":"2017-09-30 07:23:35.000000000","message":"I don\u0027t like such hardcoded assignment.\n\nSo if we pass bad value for to docker, 500 error is accepted in zun, but we need find better way to show all error message which returned from docker.\n\nBeside, as you mentioned, it\u0027s docker version related, I don\u0027t see the fix are good enough.","commit_id":"e2047a860e66298e4aaa0296d8fcdf004ff0d7f0"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"5de2a149dcded4ac0d264bed46846c67d1d8125c","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        memory \u003d patch.get(\u0027memory\u0027)"},{"line_number":546,"context_line":"        if memory is not None:"},{"line_number":547,"context_line":"            args[\u0027mem_limit\u0027] \u003d memory"},{"line_number":548,"context_line":"            args[\u0027memswap_limit\u0027] \u003d -1"},{"line_number":549,"context_line":"        cpu \u003d patch.get(\u0027cpu\u0027)"},{"line_number":550,"context_line":"        if cpu is not None:"},{"line_number":551,"context_line":"            args[\u0027cpu_quota\u0027] \u003d int(100000 * cpu)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_d6dd4f41","line":548,"range":{"start_line":548,"start_character":12,"end_line":548,"end_character":38},"in_reply_to":"7f515b1d_56a60bad","updated":"2018-02-23 22:17:53.000000000","message":"Done. Use a config instead of hardcoding.","commit_id":"e2047a860e66298e4aaa0296d8fcdf004ff0d7f0"}]}
