)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"17a96ee515c3fc63727cfb897b90f1ff9f547010","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        if not force:"},{"line_number":453,"context_line":"            utils.validate_container_state(container, \u0027delete\u0027)"},{"line_number":454,"context_line":"        else:"},{"line_number":455,"context_line":"            utils.validate_container_state(container, \u0027delete_force\u0027)"},{"line_number":456,"context_line":"            req_version \u003d pecan.request.version"},{"line_number":457,"context_line":"            min_version \u003d versions.Version(\u0027\u0027, \u0027\u0027, \u0027\u0027, \u00271.7\u0027)"},{"line_number":458,"context_line":"            if req_version \u003e\u003d min_version:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_3f47a420","line":455,"range":{"start_line":455,"start_character":18,"end_line":455,"end_character":42},"updated":"2017-10-10 16:01:31.000000000","message":"nit: I would validate container state after we passed the policy checking. However, this is minor.","commit_id":"a54ba13df0e3ffec8b81411398b058a3a1a54609"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"1f9d39f77969f200deb5bf372263676a3bfc79fe","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        if not force:"},{"line_number":453,"context_line":"            utils.validate_container_state(container, \u0027delete\u0027)"},{"line_number":454,"context_line":"        else:"},{"line_number":455,"context_line":"            utils.validate_container_state(container, \u0027delete_force\u0027)"},{"line_number":456,"context_line":"            req_version \u003d pecan.request.version"},{"line_number":457,"context_line":"            min_version \u003d versions.Version(\u0027\u0027, \u0027\u0027, \u0027\u0027, \u00271.7\u0027)"},{"line_number":458,"context_line":"            if req_version \u003e\u003d min_version:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_9260c134","line":455,"range":{"start_line":455,"start_character":18,"end_line":455,"end_character":42},"in_reply_to":"5f4e5783_3f47a420","updated":"2017-10-11 01:02:24.000000000","message":"Done","commit_id":"a54ba13df0e3ffec8b81411398b058a3a1a54609"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"e92728d2726d994344f368c2af04a5bdeceb06f0","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            if req_version \u003e\u003d min_version:"},{"line_number":458,"context_line":"                policy.enforce(context, \"container:delete_force\","},{"line_number":459,"context_line":"                               action\u003d\"container:delete_force\")"},{"line_number":460,"context_line":"                utils.validate_container_state(container, \u0027delete_force\u0027)"},{"line_number":461,"context_line":"        compute_api \u003d pecan.request.compute_api"},{"line_number":462,"context_line":"        container.status \u003d consts.DELETING"},{"line_number":463,"context_line":"        compute_api.container_delete(context, container, force)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_6821d24d","line":460,"range":{"start_line":460,"start_character":22,"end_line":460,"end_character":46},"updated":"2017-10-11 02:14:22.000000000","message":"We should validate container state regardless of the api version. Fixed it in a new patchset.","commit_id":"45abc25462408cd5f1ba2c0246ddb29833b9a394"}]}
