)]}'
{"zun/common/mount.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4104285364485ba5bd32473ff9f1e96c3028167","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            (out, err) \u003d utils.execute(\u0027cat\u0027, PROC_MOUNTS_PATH,"},{"line_number":93,"context_line":"                                       check_exit_code\u003d0, run_as_root\u003dTrue)"},{"line_number":94,"context_line":"        except exception.CommandError:"},{"line_number":95,"context_line":"            msg \u003d _(\"Failed to read mounts.\")"},{"line_number":96,"context_line":"            raise exception.FileNotFound(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_1561c4d3","line":93,"range":{"start_line":93,"start_character":58,"end_line":93,"end_character":74},"updated":"2018-01-06 12:00:22.000000000","message":"This command was not executed as root in before. Is there any reason to change it to root?","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"738e33e2293c0909907666833068ff0a12a1a344","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            (out, err) \u003d utils.execute(\u0027cat\u0027, PROC_MOUNTS_PATH,"},{"line_number":93,"context_line":"                                       check_exit_code\u003d0, run_as_root\u003dTrue)"},{"line_number":94,"context_line":"        except exception.CommandError:"},{"line_number":95,"context_line":"            msg \u003d _(\"Failed to read mounts.\")"},{"line_number":96,"context_line":"            raise exception.FileNotFound(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_311f33b8","line":93,"range":{"start_line":93,"start_character":58,"end_line":93,"end_character":74},"in_reply_to":"9f91af0f_1561c4d3","updated":"2018-01-08 02:44:17.000000000","message":"Seems that I have a confusion about system files permissions here. I will fix these in the new patchset.","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"}],"zun/common/utils.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8aba3fd7774fefc1cf35cbd429a8fb8c72d6415b","unresolved":false,"context_lines":[{"line_number":333,"context_line":"@privileged.default.entrypoint"},{"line_number":334,"context_line":"def execute_root(*cmd, **kwargs):"},{"line_number":335,"context_line":"    # NOTE(kiennt): Set run_as_root\u003dFalse because if it is set to True, the"},{"line_number":336,"context_line":"    #               command is prexied by the command specified in the"},{"line_number":337,"context_line":"    #               root_helper kwargs [1]. But we use oslo.privsep instead"},{"line_number":338,"context_line":"    #               of rootwrap so set run_as_root\u003dFalse."},{"line_number":339,"context_line":"    return custom_execute(*cmd, shell\u003dFalse, run_as_root\u003dFalse, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_0fe91119","line":336,"range":{"start_line":336,"start_character":31,"end_line":336,"end_character":38},"updated":"2018-01-02 07:27:29.000000000","message":"proxied?","commit_id":"ea9ffcb1a1b421dfd298f27a139c2de0d0bf2da2"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8aba3fd7774fefc1cf35cbd429a8fb8c72d6415b","unresolved":false,"context_lines":[{"line_number":334,"context_line":"def execute_root(*cmd, **kwargs):"},{"line_number":335,"context_line":"    # NOTE(kiennt): Set run_as_root\u003dFalse because if it is set to True, the"},{"line_number":336,"context_line":"    #               command is prexied by the command specified in the"},{"line_number":337,"context_line":"    #               root_helper kwargs [1]. But we use oslo.privsep instead"},{"line_number":338,"context_line":"    #               of rootwrap so set run_as_root\u003dFalse."},{"line_number":339,"context_line":"    return custom_execute(*cmd, shell\u003dFalse, run_as_root\u003dFalse, **kwargs)"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_0f84b15d","line":337,"range":{"start_line":337,"start_character":39,"end_line":337,"end_character":42},"updated":"2018-01-02 07:27:29.000000000","message":"This reference is missing.","commit_id":"ea9ffcb1a1b421dfd298f27a139c2de0d0bf2da2"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4104285364485ba5bd32473ff9f1e96c3028167","unresolved":false,"context_lines":[{"line_number":318,"context_line":"@privileged.default.entrypoint"},{"line_number":319,"context_line":"def execute_root(*cmd, **kwargs):"},{"line_number":320,"context_line":"    # NOTE(kiennt): Set run_as_root\u003dFalse because if it is set to True, the"},{"line_number":321,"context_line":"    #               command is prexied by the command specified in the"},{"line_number":322,"context_line":"    #               root_helper kwargs [1]. But we use oslo.privsep instead"},{"line_number":323,"context_line":"    #               of rootwrap so set run_as_root\u003dFalse."},{"line_number":324,"context_line":"    # [1] https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/processutils.py#L218 # noqa"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_355e4812","line":321,"range":{"start_line":321,"start_character":31,"end_line":321,"end_character":38},"updated":"2018-01-06 12:00:22.000000000","message":"prefixed","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"738e33e2293c0909907666833068ff0a12a1a344","unresolved":false,"context_lines":[{"line_number":318,"context_line":"@privileged.default.entrypoint"},{"line_number":319,"context_line":"def execute_root(*cmd, **kwargs):"},{"line_number":320,"context_line":"    # NOTE(kiennt): Set run_as_root\u003dFalse because if it is set to True, the"},{"line_number":321,"context_line":"    #               command is prexied by the command specified in the"},{"line_number":322,"context_line":"    #               root_helper kwargs [1]. But we use oslo.privsep instead"},{"line_number":323,"context_line":"    #               of rootwrap so set run_as_root\u003dFalse."},{"line_number":324,"context_line":"    # [1] https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/processutils.py#L218 # noqa"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_1180efbf","line":321,"range":{"start_line":321,"start_character":31,"end_line":321,"end_character":38},"in_reply_to":"9f91af0f_355e4812","updated":"2018-01-08 02:44:17.000000000","message":"Done","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4104285364485ba5bd32473ff9f1e96c3028167","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    #               therefore pop it!"},{"line_number":332,"context_line":"    kwargs.pop(\u0027root_helper\u0027, None)"},{"line_number":333,"context_line":"    if run_as_root:"},{"line_number":334,"context_line":"        execute_root(*cmd, **kwargs)"},{"line_number":335,"context_line":"    else:"},{"line_number":336,"context_line":"        custom_execute(*cmd, **kwargs)"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_151a246e","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":20},"updated":"2018-01-06 12:00:22.000000000","message":"I got this error: http://paste.openstack.org/show/639459/ . It looks it missed a return?","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"738e33e2293c0909907666833068ff0a12a1a344","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    #               therefore pop it!"},{"line_number":332,"context_line":"    kwargs.pop(\u0027root_helper\u0027, None)"},{"line_number":333,"context_line":"    if run_as_root:"},{"line_number":334,"context_line":"        execute_root(*cmd, **kwargs)"},{"line_number":335,"context_line":"    else:"},{"line_number":336,"context_line":"        custom_execute(*cmd, **kwargs)"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_b18023c1","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":20},"in_reply_to":"9f91af0f_151a246e","updated":"2018-01-08 02:44:17.000000000","message":"Done","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4104285364485ba5bd32473ff9f1e96c3028167","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    if run_as_root:"},{"line_number":334,"context_line":"        execute_root(*cmd, **kwargs)"},{"line_number":335,"context_line":"    else:"},{"line_number":336,"context_line":"        custom_execute(*cmd, **kwargs)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"def check_capsule_template(tpl):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_d59cbcc1","line":336,"range":{"start_line":336,"start_character":8,"end_line":336,"end_character":22},"updated":"2018-01-06 12:00:22.000000000","message":"Ditto. Miss the return.","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"738e33e2293c0909907666833068ff0a12a1a344","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    if run_as_root:"},{"line_number":334,"context_line":"        execute_root(*cmd, **kwargs)"},{"line_number":335,"context_line":"    else:"},{"line_number":336,"context_line":"        custom_execute(*cmd, **kwargs)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"def check_capsule_template(tpl):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_d185a7d0","line":336,"range":{"start_line":336,"start_character":8,"end_line":336,"end_character":22},"in_reply_to":"9f91af0f_d59cbcc1","updated":"2018-01-08 02:44:17.000000000","message":"Done","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"}],"zun/container/os_capability/host_capability.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4104285364485ba5bd32473ff9f1e96c3028167","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        addresses \u003d []"},{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            output, status \u003d utils.execute(\u0027lspci\u0027, \u0027-D\u0027, \u0027-nnmm\u0027,"},{"line_number":81,"context_line":"                                           run_as_root\u003dTrue)"},{"line_number":82,"context_line":"            lines \u003d output.split(\u0027\\n\u0027)"},{"line_number":83,"context_line":"            for line in lines:"},{"line_number":84,"context_line":"                if not line:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_f5a1c0f9","line":81,"range":{"start_line":81,"start_character":43,"end_line":81,"end_character":59},"updated":"2018-01-06 12:00:22.000000000","message":"This command was not executed as root in before. Is there any reason to change it to root?","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4104285364485ba5bd32473ff9f1e96c3028167","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            if \"physfn\" in output:"},{"line_number":112,"context_line":"                phys_address \u003d None"},{"line_number":113,"context_line":"                upath \u003d \u0027/sys/bus/pci/devices/%s/physfn/uevent\u0027 % address"},{"line_number":114,"context_line":"                ou, st \u003d utils.execute(\u0027cat\u0027, upath, run_as_root\u003dTrue)"},{"line_number":115,"context_line":"                lines \u003d ou.split(\u0027\\n\u0027)"},{"line_number":116,"context_line":"                for line in lines:"},{"line_number":117,"context_line":"                    if \u0027PCI_SLOT_NAME\u0027 in line:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_95a2b4fb","line":114,"range":{"start_line":114,"start_character":53,"end_line":114,"end_character":69},"updated":"2018-01-06 12:00:22.000000000","message":"Ditto","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4104285364485ba5bd32473ff9f1e96c3028167","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        def _get_product_and_vendor(address):"},{"line_number":141,"context_line":"            output, status \u003d utils.execute(\u0027lspci\u0027, \u0027-n\u0027, \u0027-s\u0027,"},{"line_number":142,"context_line":"                                           address, run_as_root\u003dTrue)"},{"line_number":143,"context_line":"            value \u003d output.split()[2]"},{"line_number":144,"context_line":"            result \u003d value.split(\":\")"},{"line_number":145,"context_line":"            return result[0], result[1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_b5a7b80b","line":142,"range":{"start_line":142,"start_character":52,"end_line":142,"end_character":68},"updated":"2018-01-06 12:00:22.000000000","message":"Ditto","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4104285364485ba5bd32473ff9f1e96c3028167","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        def _get_numa_node(address):"},{"line_number":148,"context_line":"            numa_node \u003d None"},{"line_number":149,"context_line":"            output, status \u003d utils.execute(\u0027lspci\u0027, \u0027-vmm\u0027, \u0027-s\u0027,"},{"line_number":150,"context_line":"                                           address, run_as_root\u003dTrue)"},{"line_number":151,"context_line":"            lines \u003d output.split(\u0027\\n\u0027)"},{"line_number":152,"context_line":"            for line in lines:"},{"line_number":153,"context_line":"                if \u0027NUMANode\u0027 in line:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_55b0ac43","line":150,"range":{"start_line":150,"start_character":52,"end_line":150,"end_character":68},"updated":"2018-01-06 12:00:22.000000000","message":"Ditto","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4104285364485ba5bd32473ff9f1e96c3028167","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        features \u003d []"},{"line_number":204,"context_line":"        output, status \u003d utils.execute(\u0027ethtool\u0027, \u0027-k\u0027, ifname,"},{"line_number":205,"context_line":"                                       run_as_root\u003dTrue)"},{"line_number":206,"context_line":"        lines \u003d output.split(\u0027\\n\u0027)"},{"line_number":207,"context_line":"        for line in lines:"},{"line_number":208,"context_line":"            columns \u003d line.split(\":\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_75adb0e7","line":205,"range":{"start_line":205,"start_character":39,"end_line":205,"end_character":55},"updated":"2018-01-06 12:00:22.000000000","message":"Ditto","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"}],"zun/container/os_capability/linux/os_capability_linux.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4104285364485ba5bd32473ff9f1e96c3028167","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        old_lscpu \u003d False"},{"line_number":33,"context_line":"        try:"},{"line_number":34,"context_line":"            output \u003d utils.execute(\u0027lscpu\u0027, \u0027-p\u003dsocket,cpu,online\u0027,"},{"line_number":35,"context_line":"                                   run_as_root\u003dTrue)"},{"line_number":36,"context_line":"        except exception.CommandError:"},{"line_number":37,"context_line":"            LOG.info(\"There was a problem while executing lscpu -p\u003dsocket\""},{"line_number":38,"context_line":"                     \",cpu,online. Try again without the online column.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_15b6a43f","line":35,"range":{"start_line":35,"start_character":35,"end_line":35,"end_character":51},"updated":"2018-01-06 12:00:22.000000000","message":"This command was not executed as root in before. Is there any reason to change it to root?","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4104285364485ba5bd32473ff9f1e96c3028167","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            # There is a possibility that an older version of lscpu is used"},{"line_number":40,"context_line":"            # So let\u0027s try without the online column"},{"line_number":41,"context_line":"            output \u003d utils.execute(\u0027lscpu\u0027, \u0027-p\u003dsocket,cpu\u0027,"},{"line_number":42,"context_line":"                                   run_as_root\u003dTrue)"},{"line_number":43,"context_line":"            old_lscpu \u003d True"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if old_lscpu:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_35b3a84f","line":42,"range":{"start_line":42,"start_character":35,"end_line":42,"end_character":51},"updated":"2018-01-06 12:00:22.000000000","message":"Ditto","commit_id":"6a5f953d6db51be697fb32386fb7ab3dfcb2ba44"}]}
