)]}'
{"zun/tests/unit/container/docker/test_docker_driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"522120b62586f6ae8cf126e0814a95b020b5d3b2","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        host_config[\u0027cpu_period\u0027] \u003d 100000"},{"line_number":100,"context_line":"        host_config[\u0027restart_policy\u0027] \u003d {\u0027Name\u0027: \u0027no\u0027, \u0027MaximumRetryCount\u0027: 0}"},{"line_number":101,"context_line":"        host_config[\u0027runtime\u0027] \u003d \u0027runc\u0027"},{"line_number":102,"context_line":"        host_config[\u0027binds\u0027] \u003d [\u0027/test:/test:ro\u0027]"},{"line_number":103,"context_line":"        self.mock_docker.create_host_config.assert_called_once_with("},{"line_number":104,"context_line":"            **host_config)"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_82d8f47a","line":102,"range":{"start_line":102,"start_character":33,"end_line":102,"end_character":38},"updated":"2017-10-15 23:15:23.000000000","message":"I guess the \u0027binds\u0027 option will break in multi-host environment because \u0027/test\u0027 only exists in one host. If zun-compute is running in host other than the one contains file \u0027/test\u0027, the binding is likely to break.\n\nI would suggest to let zunclient read the file \u0027/test\u0027 and pass the file content to the zun server (instead of passing a path). In zun-compute, you can write the content to a temporary file in localhost, then pass the binding to Docker.\n\nMake senses.","commit_id":"5eaaa696e0872986655ae4653c9a12f4c04be851"}]}