)]}'
{"zun/network/kuryr_network.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8d06c9e20f0d676f8830d497264bddceb68054e7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def _check_valid_subnetpool(self, subnetpool_id, subnet_cidr):"},{"line_number":114,"context_line":"        \"\"\"Check subnet\u0027s cidr matches with subnetpool prefixes or not\"\"\""},{"line_number":115,"context_line":"        subnetpools \u003d \\"},{"line_number":116,"context_line":"            self.neutron_api.list_subnetpools(id\u003dsubnetpool_id)"},{"line_number":117,"context_line":"        subnetpools \u003d subnetpools.get(\u0027subnetpools\u0027, [])"},{"line_number":118,"context_line":"        if len(subnetpools):"},{"line_number":119,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_ff21dffc","line":116,"range":{"start_line":116,"start_character":17,"end_line":116,"end_character":28},"updated":"2017-11-13 17:14:46.000000000","message":"I think we need to elevate to admin privilege to list all the subnetpools across tenants. Otherwise, this check will be scoped to current tenant which doesn\u0027t seem to be correct.","commit_id":"5789eb09a358f2cfc4d23734346bf6991bf44e93"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"f60596b559e8910cfba05681b7e910e6e449b657","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def _check_valid_subnetpool(self, subnetpool_id, subnet_cidr):"},{"line_number":114,"context_line":"        \"\"\"Check subnet\u0027s cidr matches with subnetpool prefixes or not\"\"\""},{"line_number":115,"context_line":"        subnetpools \u003d \\"},{"line_number":116,"context_line":"            self.neutron_api.list_subnetpools(id\u003dsubnetpool_id)"},{"line_number":117,"context_line":"        subnetpools \u003d subnetpools.get(\u0027subnetpools\u0027, [])"},{"line_number":118,"context_line":"        if len(subnetpools):"},{"line_number":119,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_a6d596e7","line":116,"range":{"start_line":116,"start_character":17,"end_line":116,"end_character":28},"in_reply_to":"1f485f77_ff21dffc","updated":"2017-11-14 04:58:05.000000000","message":"Done","commit_id":"5789eb09a358f2cfc4d23734346bf6991bf44e93"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8d06c9e20f0d676f8830d497264bddceb68054e7","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        subnetpools \u003d \\"},{"line_number":116,"context_line":"            self.neutron_api.list_subnetpools(id\u003dsubnetpool_id)"},{"line_number":117,"context_line":"        subnetpools \u003d subnetpools.get(\u0027subnetpools\u0027, [])"},{"line_number":118,"context_line":"        if len(subnetpools):"},{"line_number":119,"context_line":"            return False"},{"line_number":120,"context_line":"        if subnet_cidr in subnetpools[0][\u0027prefixes\u0027]:"},{"line_number":121,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_5487ba10","line":118,"range":{"start_line":118,"start_character":11,"end_line":118,"end_character":27},"updated":"2017-11-13 17:14:46.000000000","message":"I guess you mean below? Otherwise, the check in line #120 will throw an index out of range exception.\n\n  if not len(subnetpools):","commit_id":"5789eb09a358f2cfc4d23734346bf6991bf44e93"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"f60596b559e8910cfba05681b7e910e6e449b657","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        subnetpools \u003d \\"},{"line_number":116,"context_line":"            self.neutron_api.list_subnetpools(id\u003dsubnetpool_id)"},{"line_number":117,"context_line":"        subnetpools \u003d subnetpools.get(\u0027subnetpools\u0027, [])"},{"line_number":118,"context_line":"        if len(subnetpools):"},{"line_number":119,"context_line":"            return False"},{"line_number":120,"context_line":"        if subnet_cidr in subnetpools[0][\u0027prefixes\u0027]:"},{"line_number":121,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_86061a86","line":118,"range":{"start_line":118,"start_character":11,"end_line":118,"end_character":27},"in_reply_to":"1f485f77_5487ba10","updated":"2017-11-14 04:58:05.000000000","message":"Oops, thank you. Fixed","commit_id":"5789eb09a358f2cfc4d23734346bf6991bf44e93"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8d06c9e20f0d676f8830d497264bddceb68054e7","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        subnetpools \u003d \\"},{"line_number":135,"context_line":"            self.neutron_api.list_subnetpools(**kwargs).get(\u0027subnetpools\u0027, [])"},{"line_number":136,"context_line":"        if not subnetpools:"},{"line_number":137,"context_line":"            return None"},{"line_number":138,"context_line":"        elif len(subnetpools) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_bf7927fd","line":135,"range":{"start_line":135,"start_character":29,"end_line":135,"end_character":45},"updated":"2017-11-13 17:14:46.000000000","message":"Ditto. I think we need to elevate to admin privilege to list all subnetpools.","commit_id":"5789eb09a358f2cfc4d23734346bf6991bf44e93"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"f60596b559e8910cfba05681b7e910e6e449b657","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        subnetpools \u003d \\"},{"line_number":135,"context_line":"            self.neutron_api.list_subnetpools(**kwargs).get(\u0027subnetpools\u0027, [])"},{"line_number":136,"context_line":"        if not subnetpools:"},{"line_number":137,"context_line":"            return None"},{"line_number":138,"context_line":"        elif len(subnetpools) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_6609de93","line":135,"range":{"start_line":135,"start_character":29,"end_line":135,"end_character":45},"in_reply_to":"1f485f77_bf7927fd","updated":"2017-11-14 04:58:05.000000000","message":"Done","commit_id":"5789eb09a358f2cfc4d23734346bf6991bf44e93"}]}