)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"84a6125c1daff95d965c27ec0cbeb6920a938425","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use global variable to define dbdriver instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use global variable to define dbdriver instance to avoid import"},{"line_number":10,"context_line":"etcd_api and create etcd client every times api call"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iddd73cf53e85fc78d0b3d9ed8c97a4798c984336"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df87a7cf_8faf7393","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":38},"updated":"2017-12-02 02:46:37.000000000","message":"If this is for the etcd_api, how about define a global instance for etcd only and leave the sql instance untouched ?","commit_id":"f9edda287be5312dc5328367caa7ac174b7f78fe"}],"zun/db/api.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"84a6125c1daff95d965c27ec0cbeb6920a938425","unresolved":false,"context_lines":[{"line_number":29,"context_line":"IMPL \u003d db_api.DBAPI.from_config(CONF,"},{"line_number":30,"context_line":"                                backend_mapping\u003d_BACKEND_MAPPING,"},{"line_number":31,"context_line":"                                lazy\u003dTrue)"},{"line_number":32,"context_line":"_dbdriver_instance \u003d None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"@profiler.trace(\"db\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_0f9b6372","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":18},"updated":"2017-12-02 02:46:37.000000000","message":"There is already a global instance for \u0027sql\u0027 above. We don\u0027t need to define another one for \u0027sql\u0027. Just make this for \u0027etcd\u0027 should be enough.","commit_id":"f9edda287be5312dc5328367caa7ac174b7f78fe"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"84a6125c1daff95d965c27ec0cbeb6920a938425","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    global _dbdriver_instance"},{"line_number":39,"context_line":"    if _dbdriver_instance is None:"},{"line_number":40,"context_line":"        if CONF.db_type \u003d\u003d \u0027sql\u0027:"},{"line_number":41,"context_line":"            _dbdriver_instance \u003d IMPL"},{"line_number":42,"context_line":"        elif CONF.db_type \u003d\u003d \u0027etcd\u0027:"},{"line_number":43,"context_line":"            import zun.db.etcd.api as etcd_api"},{"line_number":44,"context_line":"            _dbdriver_instance \u003d etcd_api.get_connection()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_8f88d31f","line":41,"range":{"start_line":41,"start_character":33,"end_line":41,"end_character":37},"updated":"2017-12-02 02:46:37.000000000","message":"If db_type is sql, simply return IMPL should be enough. It seems we don\u0027t need to assign _dbdriver_instance in this case.","commit_id":"f9edda287be5312dc5328367caa7ac174b7f78fe"},{"author":{"_account_id":17812,"name":"chengyang","email":"374519141@qq.com","username":"chengyang"},"change_message_id":"bf42e4f9b49f90ca8fe4df03e409f624fd649a9b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    global _dbdriver_instance"},{"line_number":39,"context_line":"    if _dbdriver_instance is None:"},{"line_number":40,"context_line":"        if CONF.db_type \u003d\u003d \u0027sql\u0027:"},{"line_number":41,"context_line":"            _dbdriver_instance \u003d IMPL"},{"line_number":42,"context_line":"        elif CONF.db_type \u003d\u003d \u0027etcd\u0027:"},{"line_number":43,"context_line":"            import zun.db.etcd.api as etcd_api"},{"line_number":44,"context_line":"            _dbdriver_instance \u003d etcd_api.get_connection()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_a37850f8","line":41,"range":{"start_line":41,"start_character":33,"end_line":41,"end_character":37},"in_reply_to":"df87a7cf_8f88d31f","updated":"2017-12-02 13:09:51.000000000","message":"\u003e If db_type is sql, simply return IMPL should be enough. It seems we\n \u003e don\u0027t need to assign _dbdriver_instance in this case.\n\nHi, Hongbin, thanks for review. You are right, there is no need to reassgin dbdriver instance, I\u0027ll fix it in next ps","commit_id":"f9edda287be5312dc5328367caa7ac174b7f78fe"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"f4a48f283d4bda42ba78d7640257c9561ea26f87","unresolved":false,"context_lines":[{"line_number":29,"context_line":"IMPL \u003d db_api.DBAPI.from_config(CONF,"},{"line_number":30,"context_line":"                                backend_mapping\u003d_BACKEND_MAPPING,"},{"line_number":31,"context_line":"                                lazy\u003dTrue)"},{"line_number":32,"context_line":"_etcd_instance \u003d None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"@profiler.trace(\"db\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_a0f598cd","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":14},"updated":"2017-12-04 02:56:15.000000000","message":"As global variable, it should be upper case (_ETCD_INSTANCE).","commit_id":"5c8f5b12db33d8f29332a6bbd2c56f7b9960ff2c"}]}