)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"deba3b71f2a61457317ee25be28074d9944fed06","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        if security_group_id in container.security_groups:"},{"line_number":431,"context_line":"            msg \u003d _(\"Security group %(id)s has been added to container.\") % {"},{"line_number":432,"context_line":"                \u0027id\u0027: security_group_id}"},{"line_number":433,"context_line":"            raise exception.ZunException(msg)"},{"line_number":434,"context_line":"        compute_api.add_security_group(context, container,"},{"line_number":435,"context_line":"                                       security_group_id)"},{"line_number":436,"context_line":"        pecan.response.status \u003d 202"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_544bd729","line":433,"range":{"start_line":433,"start_character":28,"end_line":433,"end_character":40},"updated":"2018-01-16 02:31:00.000000000","message":"This is a good catch. However, this will raise a 500 response, which is bad. Server should return 4xx response on invalid user\u0027s input. I think changing it to a bad request exception is better.","commit_id":"8fd8d76fc70f46c08ce5d5b60bbc0a9b8b5623b4"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"e23a5e4a6778770e48c3a7faddeeee6ada96ccf8","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        if security_group_id in container.security_groups:"},{"line_number":431,"context_line":"            msg \u003d _(\"Security group %(id)s has been added to container.\") % {"},{"line_number":432,"context_line":"                \u0027id\u0027: security_group_id}"},{"line_number":433,"context_line":"            raise exception.ZunException(msg)"},{"line_number":434,"context_line":"        compute_api.add_security_group(context, container,"},{"line_number":435,"context_line":"                                       security_group_id)"},{"line_number":436,"context_line":"        pecan.response.status \u003d 202"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_f829ae89","line":433,"range":{"start_line":433,"start_character":28,"end_line":433,"end_character":40},"in_reply_to":"7f96bb07_544bd729","updated":"2018-01-16 07:55:26.000000000","message":"Done","commit_id":"8fd8d76fc70f46c08ce5d5b60bbc0a9b8b5623b4"}]}