)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"b70d26147261da5603625ddbf6d2208644e9d323","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     pengdake \u003c19921207pq@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-23 18:58:30 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update signal default value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I05050584fdd4134bdd35c761fbb2f835cb9b0f10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f93b717_6040f608","line":7,"updated":"2018-01-25 06:25:45.000000000","message":"Could you add little more detail about why this change is needed or link to any bug if you encountered?","commit_id":"f659acaae963c928ecf833dc283b9ac18301b8d0"}],"zun/container/docker/driver.py":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"370565564eb54c3d35e6059b60e7fb9d93574cb9","unresolved":false,"context_lines":[{"line_number":614,"context_line":"    @wrap_docker_error"},{"line_number":615,"context_line":"    def kill(self, context, container, signal\u003d\u0027None\u0027):"},{"line_number":616,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":617,"context_line":"            if signal \u003d\u003d \u0027None\u0027:"},{"line_number":618,"context_line":"                docker.kill(container.container_id)"},{"line_number":619,"context_line":"            else:"},{"line_number":620,"context_line":"                docker.kill(container.container_id, signal)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_0018121b","line":617,"range":{"start_line":617,"start_character":12,"end_line":617,"end_character":31},"updated":"2018-01-25 06:40:00.000000000","message":"I don\u0027t think the change is correct. Because signal can be None - kwargs.get(\u0027signal\u0027) will return None if signal key doesn\u0027t exist [1]. Check parameter types [2], signal\u0027s type: string, null.\n\n[1] https://github.com/openstack/zun/blob/master/zun/api/controllers/v1/containers.py#L763\n\n[2] https://github.com/openstack/zun/blob/master/zun/common/validation/parameter_types.py#L241","commit_id":"f659acaae963c928ecf833dc283b9ac18301b8d0"}]}