)]}'
{"zun/network/kuryr_network.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9f22822ea21bdbecc076fec74b7fb40acf391934","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            if container_id:"},{"line_number":316,"context_line":"                self.docker.disconnect_container_from_network(container_id,"},{"line_number":317,"context_line":"                                                              network_name)"},{"line_number":318,"context_line":"        except errors.APIError as api_error:"},{"line_number":319,"context_line":"            if is_not_found(api_error):"},{"line_number":320,"context_line":"                return"},{"line_number":321,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_ac08f8d8","line":318,"range":{"start_line":318,"start_character":34,"end_line":318,"end_character":43},"updated":"2018-01-27 16:33:26.000000000","message":"Arguably, this kind of handling of should on the driver: https://github.com/openstack/zun/blob/master/zun/container/docker/driver.py . In there, there are two calls of disconnect_container_from network and each of the call can be wrapped by a try catch block like this. However, this is an optional suggestion.","commit_id":"0fc441211618ce80cfbee579aa903fca26d678f6"}]}