)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"604beda3749802853293b2e62649528756f65174","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     weikeyou \u003cwei.keyou@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-02-05 20:03:35 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"If an error occurs when search images,"},{"line_number":8,"context_line":"It will always be a \"creating\" state, although the container has failed to create"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Capture the exceptions occured in searching for images when create containers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa0c359_c7f791f5","line":7,"updated":"2018-02-06 03:52:58.000000000","message":"The commit message should start with a short 50 character or less summary in a single paragraph. Here is the reference: https://docs.openstack.org/infra/manual/developers.html#committing-a-change","commit_id":"e349bd8d1c35fcd1b037e6b5daf1a9fca3baac47"}],"zun/compute/api.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"604beda3749802853293b2e62649528756f65174","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                new_container.status \u003d consts.ERROR"},{"line_number":71,"context_line":"                new_container.status_reason \u003d str(e)"},{"line_number":72,"context_line":"                new_container.save(context)"},{"line_number":73,"context_line":"                LOG.exception(\u0027Unknown exception occurred while searching \u0027"},{"line_number":74,"context_line":"                              \u0027for image: %s\u0027, six.text_type(e))"},{"line_number":75,"context_line":"                return"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self._record_action_start(context, new_container,"},{"line_number":78,"context_line":"                                  container_actions.CREATE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_076579b5","line":75,"range":{"start_line":73,"start_character":16,"end_line":75,"end_character":22},"updated":"2018-02-06 03:52:58.000000000","message":"Instead of looging and return, I would simply reraise the exception to render a 500 error code to users, because this is an internal server error.","commit_id":"e349bd8d1c35fcd1b037e6b5daf1a9fca3baac47"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"ed0e210bb8eafe1ca97d8c37c713475025d5780f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                new_container.status \u003d consts.ERROR"},{"line_number":71,"context_line":"                new_container.status_reason \u003d str(e)"},{"line_number":72,"context_line":"                new_container.save(context)"},{"line_number":73,"context_line":"                LOG.exception(\u0027Unknown exception occurred while searching \u0027"},{"line_number":74,"context_line":"                              \u0027for image: %s\u0027, six.text_type(e))"},{"line_number":75,"context_line":"                return"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self._record_action_start(context, new_container,"},{"line_number":78,"context_line":"                                  container_actions.CREATE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_6a944445","line":75,"range":{"start_line":73,"start_character":16,"end_line":75,"end_character":22},"in_reply_to":"3fa0c359_076579b5","updated":"2018-02-06 05:10:51.000000000","message":"+1. Reraising the exception is better otherwise this will hide the issue.","commit_id":"e349bd8d1c35fcd1b037e6b5daf1a9fca3baac47"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"feb2a95003f778824b8d83f19bdb52b01e1e846d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                new_container.status \u003d consts.ERROR"},{"line_number":68,"context_line":"                new_container.status_reason \u003d str(e)"},{"line_number":69,"context_line":"                new_container.save(context)"},{"line_number":70,"context_line":"                raise exception.ZunException(six.text_type(e))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self._record_action_start(context, new_container,"},{"line_number":73,"context_line":"                                  container_actions.CREATE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_cf247810","line":70,"range":{"start_line":70,"start_character":16,"end_line":70,"end_character":62},"updated":"2018-02-06 20:25:14.000000000","message":"Instead of catching and re-create an exception, it is better to simply re-raise the original exception. This can be achieved by simply replacing this with \"raise\".\n\nFWIW, here is the reference: http://www.ianbicking.org/blog/2007/09/re-raising-exceptions.html","commit_id":"9ff3c3c805c6ae9e00fbc4ddf8c562a230694058"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"ed6d1c9d6ba3115200492ee836d68dd7e4657d7a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"Handles all requests relating to compute resources (e.g. containers,"},{"line_number":14,"context_line":"networking and storage of containers, and compute hosts on which they run).\"\"\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import six"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from zun.common import consts"},{"line_number":19,"context_line":"from zun.common import exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_ffa8d4db","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":10},"updated":"2018-02-08 03:12:09.000000000","message":"This is not used","commit_id":"ea9f30b7c729502c305c7ba057d6932f6fb07ffb"}]}