)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b430c2739db129870e3b97d11d04010e87bc02db","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This PS will improve the validation for the"},{"line_number":10,"context_line":"\u0027nets\u0027 parameter."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3007c412d06ebe9f3494dc07eef4f962ead4d151"},{"line_number":13,"context_line":"Closes-Bug: #1748811"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff6b8bd7_ba1731ee","line":11,"updated":"2018-03-05 03:56:55.000000000","message":"This change will break without a client change: https://review.openstack.org/#/c/549669/ . Therefore, we need to add a dependency on the client-side patch. Simply add the following in the commit message:\n\nDepends-On: Iebb3ddb53e5e9d31175e6e7eeb170a66a8630a17","commit_id":"cc2718f857d2f221b0ebd53b8406edc32cfd769d"}],"zun/api/validation/parameter_types.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ebcc799fb0222e9d5c8d722118684db1d9e43798","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                \u0027format\u0027: \u0027ipv6\u0027"},{"line_number":129,"context_line":"            },"},{"line_number":130,"context_line":"            \u0027port\u0027: {"},{"line_number":131,"context_line":"                \u0027type\u0027: [\u0027integer\u0027, \u0027string\u0027],"},{"line_number":132,"context_line":"                \u0027pattern\u0027: \u0027^[a-zA-Z0-9]*$\u0027,"},{"line_number":133,"context_line":"                \u0027minimum\u0027: 0,"},{"line_number":134,"context_line":"                \u0027maximum\u0027: 65535,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f9dbf25_5cc1f47f","line":131,"range":{"start_line":131,"start_character":26,"end_line":131,"end_character":33},"updated":"2018-03-02 21:55:14.000000000","message":"Port is either a uuid or name of a neutron port. Therefore, I don\u0027t think it can be integer.","commit_id":"085074aa2e5a5183412e84365a5d3c662d51fc11"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ebcc799fb0222e9d5c8d722118684db1d9e43798","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027port\u0027: {"},{"line_number":131,"context_line":"                \u0027type\u0027: [\u0027integer\u0027, \u0027string\u0027],"},{"line_number":132,"context_line":"                \u0027pattern\u0027: \u0027^[a-zA-Z0-9]*$\u0027,"},{"line_number":133,"context_line":"                \u0027minimum\u0027: 0,"},{"line_number":134,"context_line":"                \u0027maximum\u0027: 65535,"},{"line_number":135,"context_line":"                \u0027minLength\u0027: 1,"},{"line_number":136,"context_line":"            }"},{"line_number":137,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f9dbf25_bc37d8b0","line":134,"range":{"start_line":133,"start_character":0,"end_line":134,"end_character":33},"updated":"2018-03-02 21:55:14.000000000","message":"Port cannot be an integer so minimum and maximum are unneeded in here.","commit_id":"085074aa2e5a5183412e84365a5d3c662d51fc11"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b430c2739db129870e3b97d11d04010e87bc02db","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                \u0027type\u0027: [\u0027string\u0027],"},{"line_number":128,"context_line":"                \u0027format\u0027: \u0027ipv6\u0027"},{"line_number":129,"context_line":"            },"},{"line_number":130,"context_line":"            \u0027port\u0027: {"},{"line_number":131,"context_line":"                \u0027type\u0027: [\u0027string\u0027],"},{"line_number":132,"context_line":"                \u0027pattern\u0027: \u0027^[a-zA-Z]*$\u0027,"},{"line_number":133,"context_line":"                \u0027minLength\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff6b8bd7_9ac82d75","line":130,"range":{"start_line":130,"start_character":13,"end_line":130,"end_character":17},"updated":"2018-03-05 03:56:55.000000000","message":"It is better to specify the maxLength as well. See \u0027network\u0027 above as an example.","commit_id":"cc2718f857d2f221b0ebd53b8406edc32cfd769d"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b430c2739db129870e3b97d11d04010e87bc02db","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            },"},{"line_number":130,"context_line":"            \u0027port\u0027: {"},{"line_number":131,"context_line":"                \u0027type\u0027: [\u0027string\u0027],"},{"line_number":132,"context_line":"                \u0027pattern\u0027: \u0027^[a-zA-Z]*$\u0027,"},{"line_number":133,"context_line":"                \u0027minLength\u0027: 1,"},{"line_number":134,"context_line":"            }"},{"line_number":135,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff6b8bd7_1ab5fdee","line":132,"range":{"start_line":132,"start_character":16,"end_line":132,"end_character":41},"updated":"2018-03-05 03:56:55.000000000","message":"I believe the value of port might fall out of this pattern. Suggestion simply remove the pattern parameter to fix it. See \u0027network\u0027 as an example.","commit_id":"cc2718f857d2f221b0ebd53b8406edc32cfd769d"}],"zun/common/validation/parameter_types.py":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"6a49cb88edc538e2316c8e7f04fdcfac24926705","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                \u0027oneOf\u0027: [{\u0027format\u0027: \u0027ipv4\u0027}]"},{"line_number":125,"context_line":"            },"},{"line_number":126,"context_line":"            \u0027port\u0027: {"},{"line_number":127,"context_line":"                \u0027type\u0027: [\u0027string\u0027],"},{"line_number":128,"context_line":"                \u0027minLength\u0027: 1,"},{"line_number":129,"context_line":"                \u0027maxLength\u0027: 255,"},{"line_number":130,"context_line":"            }"},{"line_number":131,"context_line":"        },"},{"line_number":132,"context_line":"        \u0027additionalProperties\u0027: False"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_136072ce","line":129,"range":{"start_line":127,"start_character":16,"end_line":129,"end_character":33},"updated":"2018-02-28 09:26:21.000000000","message":"It should be:\n\n\u0027type\u0027: [\u0027integer\u0027, \u0027string\u0027],\n\u0027pattern\u0027: \u0027^[0-9]*$\u0027,\n\u0027minimum\u0027: 0, \u0027maximum\u0027: 65535,\n\u0027minLength\u0027: 1","commit_id":"dd4c834ba8aefbfd1a859056dd6921f6c24e2fd7"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"6a49cb88edc538e2316c8e7f04fdcfac24926705","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            },"},{"line_number":122,"context_line":"            \u0027v4-fixed-ip\u0027: {"},{"line_number":123,"context_line":"                \u0027type\u0027: [\u0027string\u0027],"},{"line_number":124,"context_line":"                \u0027oneOf\u0027: [{\u0027format\u0027: \u0027ipv4\u0027}]"},{"line_number":125,"context_line":"            },"},{"line_number":126,"context_line":"            \u0027port\u0027: {"},{"line_number":127,"context_line":"                \u0027type\u0027: [\u0027string\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f9dbf25_d68e782d","line":124,"range":{"start_line":124,"start_character":16,"end_line":124,"end_character":44},"updated":"2018-02-28 09:26:21.000000000","message":"\u0027format\u0027: \u0027ipv4\u0027","commit_id":"fb6239a7122e19671e58ca2704334b801ec119ce"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"6a49cb88edc538e2316c8e7f04fdcfac24926705","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            \u0027v4-fixed-ip\u0027: {"},{"line_number":123,"context_line":"                \u0027type\u0027: [\u0027string\u0027],"},{"line_number":124,"context_line":"                \u0027oneOf\u0027: [{\u0027format\u0027: \u0027ipv4\u0027}]"},{"line_number":125,"context_line":"            },"},{"line_number":126,"context_line":"            \u0027port\u0027: {"},{"line_number":127,"context_line":"                \u0027type\u0027: [\u0027string\u0027],"},{"line_number":128,"context_line":"                \u0027minLength\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f9dbf25_96b6b0d9","line":125,"updated":"2018-02-28 09:26:21.000000000","message":"You missed v6-fixed-ip property.","commit_id":"fb6239a7122e19671e58ca2704334b801ec119ce"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"6a49cb88edc538e2316c8e7f04fdcfac24926705","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                \u0027oneOf\u0027: [{\u0027format\u0027: \u0027ipv4\u0027}]"},{"line_number":125,"context_line":"            },"},{"line_number":126,"context_line":"            \u0027port\u0027: {"},{"line_number":127,"context_line":"                \u0027type\u0027: [\u0027string\u0027],"},{"line_number":128,"context_line":"                \u0027minLength\u0027: 1,"},{"line_number":129,"context_line":"                \u0027maxLength\u0027: 255,"},{"line_number":130,"context_line":"            }"},{"line_number":131,"context_line":"        },"},{"line_number":132,"context_line":"        \u0027additionalProperties\u0027: False"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f9dbf25_f3aaa617","line":129,"range":{"start_line":127,"start_character":16,"end_line":129,"end_character":33},"updated":"2018-02-28 09:26:21.000000000","message":"It should be:\n\n\u0027type\u0027: [\u0027integer\u0027, \u0027string\u0027],\n\u0027pattern\u0027: \u0027^[0-9]*$\u0027,\n\u0027minimum\u0027: 0,\n\u0027maximum\u0027: 65535,\n\u0027minLength\u0027: 1","commit_id":"fb6239a7122e19671e58ca2704334b801ec119ce"}]}