)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"3795efcc7091e4a1852638793ddee937d1fa6730","unresolved":false,"context_lines":[{"line_number":310,"context_line":"    def _set_default_resource_limit(self, container_dict):"},{"line_number":311,"context_line":"        # TODO(kiennt): Uncomment it when bug [1] be resolved."},{"line_number":312,"context_line":"        #               At this time, limit disk size feature will be ready."},{"line_number":313,"context_line":"        # [1] https://bugs.launchpad.net/zun/+bug/1746401"},{"line_number":314,"context_line":"        # if not container_dict.get(\u0027disk\u0027):"},{"line_number":315,"context_line":"        # container_dict[\u0027disk\u0027] \u003d container_dict.get("},{"line_number":316,"context_line":"        #     \u0027disk\u0027, CONF.default_disk)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f9dbf25_a5528666","line":313,"range":{"start_line":313,"start_character":14,"end_line":313,"end_character":57},"updated":"2018-03-01 01:12:23.000000000","message":"I have an idea to walk around this. We can allow admin to set CONF.default_disk to -1. If CONF.default_disk is -1, there will be no disk quota so the population of container_dict is skipped. Otherwise, populate \u0027disk\u0027 into container_dict as usual. What do you think.","commit_id":"e7766becae06f04d5c604740eaf00a7e81b8d45a"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"7b094bcda222ce159cf128a4ab04cb78fd318adc","unresolved":false,"context_lines":[{"line_number":310,"context_line":"    def _set_default_resource_limit(self, container_dict):"},{"line_number":311,"context_line":"        # TODO(kiennt): Uncomment it when bug [1] be resolved."},{"line_number":312,"context_line":"        #               At this time, limit disk size feature will be ready."},{"line_number":313,"context_line":"        # [1] https://bugs.launchpad.net/zun/+bug/1746401"},{"line_number":314,"context_line":"        # if not container_dict.get(\u0027disk\u0027):"},{"line_number":315,"context_line":"        # container_dict[\u0027disk\u0027] \u003d container_dict.get("},{"line_number":316,"context_line":"        #     \u0027disk\u0027, CONF.default_disk)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f9dbf25_c5455272","line":313,"range":{"start_line":313,"start_character":14,"end_line":313,"end_character":57},"in_reply_to":"1f9dbf25_a5528666","updated":"2018-03-01 01:31:05.000000000","message":"I think it\u0027s ok and add more description to notify user about the supported storage drivers.","commit_id":"e7766becae06f04d5c604740eaf00a7e81b8d45a"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"fe640de82e339666a5aee267c36adbd1069c3792","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            self._generate_name_for_container()"},{"line_number":281,"context_line":"        container_dict[\u0027name\u0027] \u003d name"},{"line_number":282,"context_line":"        self._set_default_resource_limit(container_dict)"},{"line_number":283,"context_line":"        container_dict[\u0027memory\u0027] \u003d str(container_dict[\u0027memory\u0027]) + \u0027M\u0027"},{"line_number":284,"context_line":"        if container_dict.get(\u0027restart_policy\u0027):"},{"line_number":285,"context_line":"            utils.check_for_restart_policy(container_dict)"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_2ea15caa","line":283,"updated":"2018-03-02 10:02:51.000000000","message":"I think this line can be moved to _set_default_resource_limit.","commit_id":"687f3da16143660faed01458fbb33989683e5d40"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"23dc0326c05a35028027383da9626cafcdb8c164","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            self._generate_name_for_container()"},{"line_number":281,"context_line":"        container_dict[\u0027name\u0027] \u003d name"},{"line_number":282,"context_line":"        self._set_default_resource_limit(container_dict)"},{"line_number":283,"context_line":"        container_dict[\u0027memory\u0027] \u003d str(container_dict[\u0027memory\u0027]) + \u0027M\u0027"},{"line_number":284,"context_line":"        if container_dict.get(\u0027restart_policy\u0027):"},{"line_number":285,"context_line":"            utils.check_for_restart_policy(container_dict)"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_8e73d015","line":283,"in_reply_to":"1f9dbf25_2ea15caa","updated":"2018-03-02 10:11:39.000000000","message":"Done","commit_id":"687f3da16143660faed01458fbb33989683e5d40"}],"zun/conf/container_driver.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"fe640de82e339666a5aee267c36adbd1069c3792","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                    \u0027when run/create container.\u0027),"},{"line_number":80,"context_line":"    cfg.IntOpt(\u0027default_memory\u0027,"},{"line_number":81,"context_line":"               default\u003d512,"},{"line_number":82,"context_line":"               help\u003d\u0027The default memory in MB container can use \u0027"},{"line_number":83,"context_line":"                    \u0027(will be used if user do not specify \u0027"},{"line_number":84,"context_line":"                    \u0027container\\\u0027s memory). This value should be \u0027"},{"line_number":85,"context_line":"                    \u0027in range [minimum_memory, maximum_memory].\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_ae7d6c1d","line":82,"range":{"start_line":82,"start_character":46,"end_line":82,"end_character":55},"updated":"2018-03-02 10:02:51.000000000","message":"s/container/a container/","commit_id":"687f3da16143660faed01458fbb33989683e5d40"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"23dc0326c05a35028027383da9626cafcdb8c164","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                    \u0027when run/create container.\u0027),"},{"line_number":80,"context_line":"    cfg.IntOpt(\u0027default_memory\u0027,"},{"line_number":81,"context_line":"               default\u003d512,"},{"line_number":82,"context_line":"               help\u003d\u0027The default memory in MB container can use \u0027"},{"line_number":83,"context_line":"                    \u0027(will be used if user do not specify \u0027"},{"line_number":84,"context_line":"                    \u0027container\\\u0027s memory). This value should be \u0027"},{"line_number":85,"context_line":"                    \u0027in range [minimum_memory, maximum_memory].\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_6e768409","line":82,"range":{"start_line":82,"start_character":46,"end_line":82,"end_character":55},"in_reply_to":"1f9dbf25_ae7d6c1d","updated":"2018-03-02 10:11:39.000000000","message":"Done","commit_id":"687f3da16143660faed01458fbb33989683e5d40"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"fe640de82e339666a5aee267c36adbd1069c3792","unresolved":false,"context_lines":[{"line_number":82,"context_line":"               help\u003d\u0027The default memory in MB container can use \u0027"},{"line_number":83,"context_line":"                    \u0027(will be used if user do not specify \u0027"},{"line_number":84,"context_line":"                    \u0027container\\\u0027s memory). This value should be \u0027"},{"line_number":85,"context_line":"                    \u0027in range [minimum_memory, maximum_memory].\u0027),"},{"line_number":86,"context_line":"    cfg.FloatOpt(\u0027default_cpu\u0027,"},{"line_number":87,"context_line":"                 default\u003d1.0,"},{"line_number":88,"context_line":"                 help\u003d\u0027The default number of cpus container can use \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_8e9bd070","line":85,"updated":"2018-03-02 10:02:51.000000000","message":"Should we specify what is minimum_memory and maximum_memory here?","commit_id":"687f3da16143660faed01458fbb33989683e5d40"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"23dc0326c05a35028027383da9626cafcdb8c164","unresolved":false,"context_lines":[{"line_number":82,"context_line":"               help\u003d\u0027The default memory in MB container can use \u0027"},{"line_number":83,"context_line":"                    \u0027(will be used if user do not specify \u0027"},{"line_number":84,"context_line":"                    \u0027container\\\u0027s memory). This value should be \u0027"},{"line_number":85,"context_line":"                    \u0027in range [minimum_memory, maximum_memory].\u0027),"},{"line_number":86,"context_line":"    cfg.FloatOpt(\u0027default_cpu\u0027,"},{"line_number":87,"context_line":"                 default\u003d1.0,"},{"line_number":88,"context_line":"                 help\u003d\u0027The default number of cpus container can use \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_ce69d825","line":85,"in_reply_to":"1f9dbf25_8e9bd070","updated":"2018-03-02 10:11:39.000000000","message":"Yeah, I\u0027ve already specified these options in line L56 and L60.","commit_id":"687f3da16143660faed01458fbb33989683e5d40"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"fe640de82e339666a5aee267c36adbd1069c3792","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                    \u0027in range [minimum_memory, maximum_memory].\u0027),"},{"line_number":86,"context_line":"    cfg.FloatOpt(\u0027default_cpu\u0027,"},{"line_number":87,"context_line":"                 default\u003d1.0,"},{"line_number":88,"context_line":"                 help\u003d\u0027The default number of cpus container can use \u0027"},{"line_number":89,"context_line":"                 \u0027(will be used if user do not specify \u0027"},{"line_number":90,"context_line":"                 \u0027container\\\u0027s cpus). This value should be \u0027"},{"line_number":91,"context_line":"                 \u0027in range [minimum_cpus, maximum_cpus]\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_ee98546b","line":88,"range":{"start_line":88,"start_character":50,"end_line":88,"end_character":59},"updated":"2018-03-02 10:02:51.000000000","message":"s/container/a container/","commit_id":"687f3da16143660faed01458fbb33989683e5d40"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"23dc0326c05a35028027383da9626cafcdb8c164","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                    \u0027in range [minimum_memory, maximum_memory].\u0027),"},{"line_number":86,"context_line":"    cfg.FloatOpt(\u0027default_cpu\u0027,"},{"line_number":87,"context_line":"                 default\u003d1.0,"},{"line_number":88,"context_line":"                 help\u003d\u0027The default number of cpus container can use \u0027"},{"line_number":89,"context_line":"                 \u0027(will be used if user do not specify \u0027"},{"line_number":90,"context_line":"                 \u0027container\\\u0027s cpus). This value should be \u0027"},{"line_number":91,"context_line":"                 \u0027in range [minimum_cpus, maximum_cpus]\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_ee8294c8","line":88,"range":{"start_line":88,"start_character":50,"end_line":88,"end_character":59},"in_reply_to":"1f9dbf25_ee98546b","updated":"2018-03-02 10:11:39.000000000","message":"Done","commit_id":"687f3da16143660faed01458fbb33989683e5d40"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"fe640de82e339666a5aee267c36adbd1069c3792","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                 help\u003d\u0027The default number of cpus container can use \u0027"},{"line_number":89,"context_line":"                 \u0027(will be used if user do not specify \u0027"},{"line_number":90,"context_line":"                 \u0027container\\\u0027s cpus). This value should be \u0027"},{"line_number":91,"context_line":"                 \u0027in range [minimum_cpus, maximum_cpus]\u0027),"},{"line_number":92,"context_line":"    cfg.IntOpt(\u0027default_disk\u0027,"},{"line_number":93,"context_line":"               default\u003d-1,"},{"line_number":94,"context_line":"               help\u003d\u0027The default disk size container can use \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_aea24c99","line":91,"updated":"2018-03-02 10:02:51.000000000","message":"ditto","commit_id":"687f3da16143660faed01458fbb33989683e5d40"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"23dc0326c05a35028027383da9626cafcdb8c164","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                 help\u003d\u0027The default number of cpus container can use \u0027"},{"line_number":89,"context_line":"                 \u0027(will be used if user do not specify \u0027"},{"line_number":90,"context_line":"                 \u0027container\\\u0027s cpus). This value should be \u0027"},{"line_number":91,"context_line":"                 \u0027in range [minimum_cpus, maximum_cpus]\u0027),"},{"line_number":92,"context_line":"    cfg.IntOpt(\u0027default_disk\u0027,"},{"line_number":93,"context_line":"               default\u003d-1,"},{"line_number":94,"context_line":"               help\u003d\u0027The default disk size container can use \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_4e7e28e5","line":91,"in_reply_to":"1f9dbf25_aea24c99","updated":"2018-03-02 10:11:39.000000000","message":"Done","commit_id":"687f3da16143660faed01458fbb33989683e5d40"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"fe640de82e339666a5aee267c36adbd1069c3792","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                 \u0027in range [minimum_cpus, maximum_cpus]\u0027),"},{"line_number":92,"context_line":"    cfg.IntOpt(\u0027default_disk\u0027,"},{"line_number":93,"context_line":"               default\u003d-1,"},{"line_number":94,"context_line":"               help\u003d\u0027The default disk size container can use \u0027"},{"line_number":95,"context_line":"                    \u0027(will be used if user do not specify \u0027"},{"line_number":96,"context_line":"                    \u0027container\\\u0027s disk). This value should be \u0027"},{"line_number":97,"context_line":"                    \u0027in range [minimum_disk, maximum_disk]. Default \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_8ea9907c","line":94,"range":{"start_line":94,"start_character":43,"end_line":94,"end_character":52},"updated":"2018-03-02 10:02:51.000000000","message":"s/container/a container/","commit_id":"687f3da16143660faed01458fbb33989683e5d40"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"23dc0326c05a35028027383da9626cafcdb8c164","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                 \u0027in range [minimum_cpus, maximum_cpus]\u0027),"},{"line_number":92,"context_line":"    cfg.IntOpt(\u0027default_disk\u0027,"},{"line_number":93,"context_line":"               default\u003d-1,"},{"line_number":94,"context_line":"               help\u003d\u0027The default disk size container can use \u0027"},{"line_number":95,"context_line":"                    \u0027(will be used if user do not specify \u0027"},{"line_number":96,"context_line":"                    \u0027container\\\u0027s disk). This value should be \u0027"},{"line_number":97,"context_line":"                    \u0027in range [minimum_disk, maximum_disk]. Default \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_2e795cfb","line":94,"range":{"start_line":94,"start_character":43,"end_line":94,"end_character":52},"in_reply_to":"1f9dbf25_8ea9907c","updated":"2018-03-02 10:11:39.000000000","message":"Done","commit_id":"687f3da16143660faed01458fbb33989683e5d40"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"fe640de82e339666a5aee267c36adbd1069c3792","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    \u0027container\\\u0027s disk). This value should be \u0027"},{"line_number":97,"context_line":"                    \u0027in range [minimum_disk, maximum_disk]. Default \u0027"},{"line_number":98,"context_line":"                    \u0027is -1, it means no disk quota. This option should \u0027"},{"line_number":99,"context_line":"                    \u0027be only changed if the storage drivers is \u0027"},{"line_number":100,"context_line":"                    \u0027in the following list: devicemapper, btrfs, \u0027"},{"line_number":101,"context_line":"                    \u0027windowsfilter, zfs, overlay2.\u0027)"},{"line_number":102,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_eeb134e3","line":99,"range":{"start_line":99,"start_character":21,"end_line":99,"end_character":35},"updated":"2018-03-02 10:02:51.000000000","message":"s/be only changed/only be used/","commit_id":"687f3da16143660faed01458fbb33989683e5d40"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"23dc0326c05a35028027383da9626cafcdb8c164","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    \u0027container\\\u0027s disk). This value should be \u0027"},{"line_number":97,"context_line":"                    \u0027in range [minimum_disk, maximum_disk]. Default \u0027"},{"line_number":98,"context_line":"                    \u0027is -1, it means no disk quota. This option should \u0027"},{"line_number":99,"context_line":"                    \u0027be only changed if the storage drivers is \u0027"},{"line_number":100,"context_line":"                    \u0027in the following list: devicemapper, btrfs, \u0027"},{"line_number":101,"context_line":"                    \u0027windowsfilter, zfs, overlay2.\u0027)"},{"line_number":102,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f9dbf25_8e1e70b8","line":99,"range":{"start_line":99,"start_character":21,"end_line":99,"end_character":35},"in_reply_to":"1f9dbf25_eeb134e3","updated":"2018-03-02 10:11:39.000000000","message":"Done","commit_id":"687f3da16143660faed01458fbb33989683e5d40"}]}