)]}'
{"api-ref/source/samples/container-action-get-resp.json":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"edeb55fd83b99542a52e2e9d74ea9b1a355c914e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"container_action\": {"},{"line_number":3,"context_line":"        \"action\": \"create\","},{"line_number":4,"context_line":"        \"events\": ["},{"line_number":5,"context_line":"            {"}],"source_content_type":"application/json","patch_set":1,"id":"1f9dbf25_1946117e","line":2,"range":{"start_line":2,"start_character":5,"end_line":2,"end_character":21},"updated":"2018-03-04 20:34:51.000000000","message":"I tried this patch locally and here is the response I got: http://paste.openstack.org/show/690868/ . There are some inconsistencies:\n\n* There are no \"container_action\" key\n* The server returned message as null but it is documented as \"\" in here. Either the response or the docs needs to be fixed.\n* The project_id \u0026 user_id is an uuid instead of a number.\n* The traceback key is missing in the response.\n* The start_time seems to be in an inconsistent format. The response is \"2018-03-04 17:02:54+00:00\" but it is \"2012-12-05T01:04:00.000000\" in here (ignore this issue if it is not related to this change).","commit_id":"226ab765c5834d508b076c3a454e6ebabd281b89"}],"api-ref/source/samples/container-actions-list-resp.json":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"edeb55fd83b99542a52e2e9d74ea9b1a355c914e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"container_actions\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"action\": \"create\","},{"line_number":5,"context_line":"            \"container_uuid\": \"b48316c5-71e8-45e4-9884-6c78055b9b13\","}],"source_content_type":"application/json","patch_set":1,"id":"1f9dbf25_7966352c","line":2,"range":{"start_line":2,"start_character":5,"end_line":2,"end_character":22},"updated":"2018-03-04 20:34:51.000000000","message":"I tried this patch locally and here is the response I got: http://paste.openstack.org/show/690867/ . There are some inconsistencies:\n\n* There are no \"container_actions\" key\n* The server returned message as null but it is documented as \"\" in here. Either the response or the docs needs to be fixed.\n* The project_id \u0026 user_id is an uuid instead of a number.","commit_id":"226ab765c5834d508b076c3a454e6ebabd281b89"}],"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"edeb55fd83b99542a52e2e9d74ea9b1a355c914e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        policy.enforce(context, \"container:actions\","},{"line_number":111,"context_line":"                       action\u003d\"container:actions\")"},{"line_number":112,"context_line":"        actions_raw \u003d objects.ContainerAction.get_by_container_uuid("},{"line_number":113,"context_line":"            context, container_ident)"},{"line_number":114,"context_line":"        actions \u003d [self._format_action(action) for action in actions_raw]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        return actions"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_79ecf528","line":113,"range":{"start_line":113,"start_character":21,"end_line":113,"end_character":36},"updated":"2018-03-04 20:34:51.000000000","message":"This will work for container\u0027s uuid but won\u0027t work for container\u0027s name. A potential enhancement is to retrieve the container\u0027s uuid by the provided input and use the uuid to retrieve the container actions. You can use utils.get_container(container_ident) for that.","commit_id":"226ab765c5834d508b076c3a454e6ebabd281b89"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"edeb55fd83b99542a52e2e9d74ea9b1a355c914e","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        action \u003d self._format_action(action)"},{"line_number":138,"context_line":"        show_traceback \u003d False"},{"line_number":139,"context_line":"        if policy.enforce(context, \"container:actions:events\","},{"line_number":140,"context_line":"                          do_raise\u003dFalse, action\u003d\"container:actions:events\"):"},{"line_number":141,"context_line":"            show_traceback \u003d True"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_b43044ea","line":139,"range":{"start_line":139,"start_character":46,"end_line":139,"end_character":53},"updated":"2018-03-04 20:34:51.000000000","message":"This looks inconsistent with the policy: https://review.openstack.org/#/c/548853/1/zun/common/policies/container_action.py . The policy name is \"container:action:events\" (not \u0027s\u0027).","commit_id":"226ab765c5834d508b076c3a454e6ebabd281b89"}]}