)]}'
{"zun/container/docker/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"333a10d48ffb7141130b2d8c91ffd65176f041e2","unresolved":false,"context_lines":[{"line_number":893,"context_line":"                    architecture, os_type, os, kernel_version, labels)"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    def get_total_disk_for_container(self):"},{"line_number":896,"context_line":"        return CONF.compute.total_disk_for_containers"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"    def get_cpu_used(self):"},{"line_number":899,"context_line":"        cpu_used \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_9104807d","line":896,"range":{"start_line":896,"start_character":28,"end_line":896,"end_character":53},"updated":"2018-03-06 04:20:28.000000000","message":"I think this approach will work but it introduces overhead for administrator to manually configure the total disk. IMHO, a better approach is to calculate the total disk:\n\n  total_disk_for_container \u003d disk_size - CONF.compute.reserved_host_disk_mb\n\nwhere:\n\n* disk_size is the size of the hard disk (run \"df /\" will display it).\n* CONF.compute.reserved_host_disk_mb is a config like [1]\n\nWhat do you think?\n\n[1] https://github.com/openstack/nova/blob/master/nova/conf/compute.py#L355","commit_id":"7e06f6100336f6c02e4033178fafa669135205e0"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"abd59a57d191824eed664233a53a9cb1ef9c2a49","unresolved":false,"context_lines":[{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    def get_total_disk_for_container(self):"},{"line_number":896,"context_line":"        try:"},{"line_number":897,"context_line":"            output \u003d utils.execute(\u0027df -B 1G\u0027, CONF.docker.docker_data_root)"},{"line_number":898,"context_line":"        except exception.CommandError:"},{"line_number":899,"context_line":"            LOG.info(\u0027There was a problem while executing df -B 1G %s\u0027,"},{"line_number":900,"context_line":"                     CONF.docker.docker_data_root)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_ecc4b861","line":897,"range":{"start_line":897,"start_character":36,"end_line":897,"end_character":44},"updated":"2018-03-10 22:40:18.000000000","message":"The gate is complaining. Here is the error message: http://logs.openstack.org/09/549709/4/check/zun-tempest-docker-sql/0ca5e71/logs/screen-zun-compute.txt.gz#_Mar_09_01_36_35_212625 .\n\nIt looks this is the root cause of the issue. I think you need to split each this into tokens, like this (UNTESTED):\n\n    output \u003d utils.execute(\u0027df\u0027, \u0027-B\u0027, \u00271G\u0027, CONF.docker.docker_data_root)","commit_id":"259c900ad548be06f4dec59800ec84847b1e97cb"}]}