)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d470a0907cb0d2c65acfb0695c625d3baa88a48f","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        return view.format_container(pecan.request.host_url, new_container)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def _set_default_resource_limit(self, container_dict):"},{"line_number":389,"context_line":"        if CONF.default_disk \u003e\u003d 0:"},{"line_number":390,"context_line":"            container_dict[\u0027disk\u0027] \u003d container_dict.get("},{"line_number":391,"context_line":"                \u0027disk\u0027, CONF.default_disk)"},{"line_number":392,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_75942c45","line":389,"range":{"start_line":389,"start_character":16,"end_line":389,"end_character":28},"updated":"2018-03-08 02:40:39.000000000","message":"I think this is a temporary work-around which allows cloud admins to set default_disk to -1 for disabling disk quota. Since this patch implements a proper check for the disk quota support, we don\u0027t need this work-around anymore. It looks we are ready to remove this check.","commit_id":"3dc5de76f45fdec37f0520e3987434f590b8b958"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"8c2c40eea6bd107cb89de0852ee8c6a3f2c77738","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        return view.format_container(pecan.request.host_url, new_container)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def _set_default_resource_limit(self, container_dict):"},{"line_number":389,"context_line":"        if CONF.default_disk \u003e\u003d 0:"},{"line_number":390,"context_line":"            container_dict[\u0027disk\u0027] \u003d container_dict.get("},{"line_number":391,"context_line":"                \u0027disk\u0027, CONF.default_disk)"},{"line_number":392,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_0671bfe0","line":389,"range":{"start_line":389,"start_character":16,"end_line":389,"end_character":28},"in_reply_to":"df7087c5_75942c45","updated":"2018-03-12 07:37:22.000000000","message":"Done","commit_id":"3dc5de76f45fdec37f0520e3987434f590b8b958"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b58b1b4143ed3494aec57864896588273170e448","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        return view.format_container(pecan.request.host_url, new_container)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def _set_default_resource_limit(self, container_dict):"},{"line_number":390,"context_line":"        if CONF.default_disk \u003e\u003d 0:"},{"line_number":391,"context_line":"            container_dict[\u0027disk\u0027] \u003d container_dict.get("},{"line_number":392,"context_line":"                \u0027disk\u0027, CONF.default_disk)"},{"line_number":393,"context_line":"        container_dict[\u0027memory\u0027] \u003d container_dict.get("}],"source_content_type":"text/x-python","patch_set":11,"id":"df7087c5_47238c06","side":"PARENT","line":390,"range":{"start_line":390,"start_character":16,"end_line":390,"end_character":28},"updated":"2018-03-18 18:59:59.000000000","message":"This is for checking if CONF.default_disk is -1 which is the default value. If this is removed, we\u0027d better to update the default_disk: https://github.com/openstack/zun/blob/master/zun/conf/container_driver.py#L92 .\n\nThis is not a big deal, and we can do it in a separated patch.","commit_id":"faaf53d2e7adadf6f65cd61c605a2dc7925351ea"}],"zun/compute/manager.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d470a0907cb0d2c65acfb0695c625d3baa88a48f","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def _check_support_disk_quota(self, container):"},{"line_number":196,"context_line":"        if not self.driver.node_support_disk_quota() and container.disk:"},{"line_number":197,"context_line":"            msg \u003d _(\u0027Your storage driver is %(storage_driver)s. This is \u0027"},{"line_number":198,"context_line":"                    \u0027unsupported storage driver for disk quota feature.\u0027) % {"},{"line_number":199,"context_line":"                        \u0027storage_driver\u0027:"},{"line_number":200,"context_line":"                        self.driver.get_host_storage_driver()}"},{"line_number":201,"context_line":"            self._fail_container(context, container, msg, unset_host\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_f58efc25","line":198,"range":{"start_line":197,"start_character":20,"end_line":198,"end_character":72},"updated":"2018-03-08 02:40:39.000000000","message":"I think this message is too low-level and expose unnecessary details to end-users. Suggest to re-phrase it.","commit_id":"3dc5de76f45fdec37f0520e3987434f590b8b958"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0b2c67adf656a4327f9053a0a3ead853e97993b2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            # FIXME(kiennt): This block is too complicated. We should find"},{"line_number":195,"context_line":"            #                new effecient way to do the check."},{"line_number":196,"context_line":"            if not container.disk:"},{"line_number":197,"context_line":"                container.disk \u003d max(base_device_size, CONF.default_disk)"},{"line_number":198,"context_line":"                return"},{"line_number":199,"context_line":"            else:"},{"line_number":200,"context_line":"                if container.disk \u003c base_device_size:"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_e0b6948a","line":197,"range":{"start_line":197,"start_character":33,"end_line":197,"end_character":73},"updated":"2018-03-15 03:02:34.000000000","message":"If the default is 10G and the backing file system is 5G, we take the max (which is 10G) and assign 10G to the container. Then, it looks the container will demand 10G of disk and the available disk is only 5G, which doesn\u0027t look correct.","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"6736b9c00c19e57278c8e06ba7076b50adca1ffa","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            # FIXME(kiennt): This block is too complicated. We should find"},{"line_number":195,"context_line":"            #                new effecient way to do the check."},{"line_number":196,"context_line":"            if not container.disk:"},{"line_number":197,"context_line":"                container.disk \u003d max(base_device_size, CONF.default_disk)"},{"line_number":198,"context_line":"                return"},{"line_number":199,"context_line":"            else:"},{"line_number":200,"context_line":"                if container.disk \u003c base_device_size:"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_289d130a","line":197,"range":{"start_line":197,"start_character":33,"end_line":197,"end_character":73},"in_reply_to":"df7087c5_002fdf87","updated":"2018-03-17 02:54:22.000000000","message":"Oh, I see. Sorry for my misunderstanding.","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"83ad2d1132e017ca220867cce2a4cda32667b7d4","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            # FIXME(kiennt): This block is too complicated. We should find"},{"line_number":195,"context_line":"            #                new effecient way to do the check."},{"line_number":196,"context_line":"            if not container.disk:"},{"line_number":197,"context_line":"                container.disk \u003d max(base_device_size, CONF.default_disk)"},{"line_number":198,"context_line":"                return"},{"line_number":199,"context_line":"            else:"},{"line_number":200,"context_line":"                if container.disk \u003c base_device_size:"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_002fdf87","line":197,"range":{"start_line":197,"start_character":33,"end_line":197,"end_character":73},"in_reply_to":"df7087c5_e0b6948a","updated":"2018-03-16 08:39:23.000000000","message":"base_device_size here isn\u0027t the available disk. Base size is the maximum size that a container/image can grow to. By default, it limits containers to 10G. You can check this option by run: docker info (with storage-driver \u003d devicemapper for e.x). \nAccording to the documentation [1], for the devicemapper, btrfs, windowsfilter and zfs graph drivers, user cannot pass a size less than the Default BaseFS Size. Repoduce:\n\n$ docker info | grep -i storage # Check storage options. Storage driver should be changed to devicemapper.\n$ docker info | grep -i \"Base Device Size\"\nBase Device Size: 10.74GB\n$ docker run -it --storage-opt size\u003d5G ubuntu /bin/bash\ndocker: Error response from daemon: devmapper: Container size cannot be smaller than 10.74GB.\n\n[1] https://docs.docker.com/engine/reference/commandline/run/#set-storage-driver-options-per-container","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0b2c67adf656a4327f9053a0a3ead853e97993b2","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                container.disk \u003d max(base_device_size, CONF.default_disk)"},{"line_number":198,"context_line":"                return"},{"line_number":199,"context_line":"            else:"},{"line_number":200,"context_line":"                if container.disk \u003c base_device_size:"},{"line_number":201,"context_line":"                    msg \u003d _(\u0027Disk size cannot be smaller than \u0027"},{"line_number":202,"context_line":"                            \u0027%(base_device_size)s.\u0027) % {"},{"line_number":203,"context_line":"                                \u0027base_device_size\u0027: base_device_size"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_0b116904","line":200,"range":{"start_line":200,"start_character":19,"end_line":200,"end_character":53},"updated":"2018-03-15 03:02:34.000000000","message":"In here, we compare a container with the base_device_size, but shouldn\u0027t we compare the sum of all containers with the base_device_size?","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"83ad2d1132e017ca220867cce2a4cda32667b7d4","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                container.disk \u003d max(base_device_size, CONF.default_disk)"},{"line_number":198,"context_line":"                return"},{"line_number":199,"context_line":"            else:"},{"line_number":200,"context_line":"                if container.disk \u003c base_device_size:"},{"line_number":201,"context_line":"                    msg \u003d _(\u0027Disk size cannot be smaller than \u0027"},{"line_number":202,"context_line":"                            \u0027%(base_device_size)s.\u0027) % {"},{"line_number":203,"context_line":"                                \u0027base_device_size\u0027: base_device_size"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_e0b66b3e","line":200,"range":{"start_line":200,"start_character":19,"end_line":200,"end_character":53},"in_reply_to":"df7087c5_0b116904","updated":"2018-03-16 08:39:23.000000000","message":"As I said in the previous comment, base_device_size isn\u0027t about the remain disks, so we shouldn\u0027t compare the sum with the base_device_size.","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0b2c67adf656a4327f9053a0a3ead853e97993b2","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                return"},{"line_number":199,"context_line":"            else:"},{"line_number":200,"context_line":"                if container.disk \u003c base_device_size:"},{"line_number":201,"context_line":"                    msg \u003d _(\u0027Disk size cannot be smaller than \u0027"},{"line_number":202,"context_line":"                            \u0027%(base_device_size)s.\u0027) % {"},{"line_number":203,"context_line":"                                \u0027base_device_size\u0027: base_device_size"},{"line_number":204,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_4052e03c","line":201,"range":{"start_line":201,"start_character":29,"end_line":201,"end_character":61},"updated":"2018-03-15 03:02:34.000000000","message":"I think container\u0027s disk can be smaller than the file system. I guess you mean larger than?","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0b2c67adf656a4327f9053a0a3ead853e97993b2","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                            \u0027%(base_device_size)s.\u0027) % {"},{"line_number":203,"context_line":"                                \u0027base_device_size\u0027: base_device_size"},{"line_number":204,"context_line":"                    }"},{"line_number":205,"context_line":"                    self._fail_container(context, container,"},{"line_number":206,"context_line":"                                         msg, unset_host\u003dTrue)"},{"line_number":207,"context_line":"                    raise exception.Invalid(msg)"},{"line_number":208,"context_line":"        # NOTE(kiennt): Only raise Exception when user passes disk size and"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_8b1579e7","line":205,"range":{"start_line":205,"start_character":25,"end_line":205,"end_character":40},"updated":"2018-03-15 03:02:34.000000000","message":"The logic in here looks very similar to the Claim class (https://github.com/openstack/zun/blob/master/zun/compute/claims.py#L59). In particular, the Claim class has _test_memory() and _test_cpu(), and the logic in here looks like a _test_disk(). Could we move some code to the Claim class?","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"}],"zun/container/docker/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d470a0907cb0d2c65acfb0695c625d3baa88a48f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                {\u0027storage_driver\u0027: self._host.storage_driver,"},{"line_number":201,"context_line":"                                 \u0027default_base_size\u0027:"},{"line_number":202,"context_line":"                                 self._host.default_base_size}"},{"line_number":203,"context_line":"                            raise exception.Invalid(msg)"},{"line_number":204,"context_line":"                    disk_size \u003d str(container.disk) + \u0027G\u0027"},{"line_number":205,"context_line":"                    host_config[\u0027storage_opt\u0027] \u003d {\u0027size\u0027: disk_size}"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_15ccd033","line":203,"range":{"start_line":203,"start_character":52,"end_line":203,"end_character":55},"updated":"2018-03-08 02:40:39.000000000","message":"Several observations here:\n\n* This error message looks too low-level for end-users. It exposes implementation details that end-users don\u0027t need to know.\n* Shouldn\u0027t the scheduler ensure this node has enough disk for the container?\n* Suppose the container is scheduled to this node. The resource claiming should fail if this node doesn\u0027t have enough disk. Therefore, I am not sure if this code block is reachable.","commit_id":"3dc5de76f45fdec37f0520e3987434f590b8b958"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"8c2c40eea6bd107cb89de0852ee8c6a3f2c77738","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                {\u0027storage_driver\u0027: self._host.storage_driver,"},{"line_number":201,"context_line":"                                 \u0027default_base_size\u0027:"},{"line_number":202,"context_line":"                                 self._host.default_base_size}"},{"line_number":203,"context_line":"                            raise exception.Invalid(msg)"},{"line_number":204,"context_line":"                    disk_size \u003d str(container.disk) + \u0027G\u0027"},{"line_number":205,"context_line":"                    host_config[\u0027storage_opt\u0027] \u003d {\u0027size\u0027: disk_size}"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_c7f3ea72","line":203,"range":{"start_line":203,"start_character":52,"end_line":203,"end_character":55},"in_reply_to":"df7087c5_15ccd033","updated":"2018-03-12 07:37:22.000000000","message":"According to Docker documentation [1], for the devicemapper, btrfs, windowsfilter and zfs graph drivers, user cannot pass a size less than the Default BaseFS Size. This block is checking that requirement, not about check disk info.\n\n[1] https://docs.docker.com/engine/reference/commandline/run/#set-storage-driver-options-per-container","commit_id":"3dc5de76f45fdec37f0520e3987434f590b8b958"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"5acba333d04cc6f64bd4cc48570a0598cd6a47ce","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                {\u0027storage_driver\u0027: self._host.storage_driver,"},{"line_number":201,"context_line":"                                 \u0027default_base_size\u0027:"},{"line_number":202,"context_line":"                                 self._host.default_base_size}"},{"line_number":203,"context_line":"                            raise exception.Invalid(msg)"},{"line_number":204,"context_line":"                    disk_size \u003d str(container.disk) + \u0027G\u0027"},{"line_number":205,"context_line":"                    host_config[\u0027storage_opt\u0027] \u003d {\u0027size\u0027: disk_size}"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_d5bc186b","line":203,"range":{"start_line":203,"start_character":52,"end_line":203,"end_character":55},"in_reply_to":"df7087c5_15ccd033","updated":"2018-03-08 02:46:33.000000000","message":"FYI: You might interest to checkout these two patches:\n\n* https://review.openstack.org/#/c/549709/\n* https://review.openstack.org/#/c/550035/","commit_id":"3dc5de76f45fdec37f0520e3987434f590b8b958"}],"zun/container/docker/host.py":[{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"40ed952fb9bd25a2cfc68bd84f55f2d3d80cc21d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":65,"context_line":"                    # Check project quota mount option"},{"line_number":66,"context_line":"                    return_code \u003d \\"},{"line_number":67,"context_line":"                        os.system(\"mount | grep \u0027xfs\u0027 | grep \u0027pquota\u0027\")"},{"line_number":68,"context_line":"                    if return_code:"},{"line_number":69,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":70,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_d8d0cd53","line":67,"range":{"start_line":67,"start_character":23,"end_line":67,"end_character":71},"updated":"2018-03-08 03:54:51.000000000","message":"IMO, we should check the mount info of docker_data_root.","commit_id":"3dc5de76f45fdec37f0520e3987434f590b8b958"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"cdb8811afd0bb5428df869ddfd7b74c1ab64ac90","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":65,"context_line":"                    # Check project quota mount option"},{"line_number":66,"context_line":"                    return_code \u003d \\"},{"line_number":67,"context_line":"                        os.system(\"mount | grep \u0027xfs\u0027 | grep \u0027pquota\u0027\")"},{"line_number":68,"context_line":"                    if return_code:"},{"line_number":69,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":70,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_da463822","line":67,"range":{"start_line":67,"start_character":23,"end_line":67,"end_character":71},"in_reply_to":"df7087c5_2a3cebc6","updated":"2018-03-12 10:21:03.000000000","message":"hi Kien,I have do something about this.\nhttps://review.openstack.org/#/c/549709/","commit_id":"3dc5de76f45fdec37f0520e3987434f590b8b958"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"8c2c40eea6bd107cb89de0852ee8c6a3f2c77738","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":65,"context_line":"                    # Check project quota mount option"},{"line_number":66,"context_line":"                    return_code \u003d \\"},{"line_number":67,"context_line":"                        os.system(\"mount | grep \u0027xfs\u0027 | grep \u0027pquota\u0027\")"},{"line_number":68,"context_line":"                    if return_code:"},{"line_number":69,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":70,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_2a3cebc6","line":67,"range":{"start_line":67,"start_character":23,"end_line":67,"end_character":71},"in_reply_to":"df7087c5_d8d0cd53","updated":"2018-03-12 07:37:22.000000000","message":"hi Feng, could you elaborate how to do a check with docker_data_root?","commit_id":"3dc5de76f45fdec37f0520e3987434f590b8b958"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"befa9ad6b6fcdb61128bcaa0c2894be16fa82db7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":65,"context_line":"                    # Check project quota mount option"},{"line_number":66,"context_line":"                    return_code \u003d \\"},{"line_number":67,"context_line":"                        os.system(\"mount | grep \u0027xfs\u0027 | grep \u0027pquota\u0027\")"},{"line_number":68,"context_line":"                    if return_code:"},{"line_number":69,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":70,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_1f3b399c","line":67,"range":{"start_line":67,"start_character":23,"end_line":67,"end_character":71},"in_reply_to":"df7087c5_da463822","updated":"2018-03-12 15:18:04.000000000","message":"Let me check. Thank Feng :)","commit_id":"3dc5de76f45fdec37f0520e3987434f590b8b958"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f9fc583b3dca4dddacb6c8cd11588ffee32193e9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":65,"context_line":"                    # Check project quota mount option"},{"line_number":66,"context_line":"                    return_code \u003d \\"},{"line_number":67,"context_line":"                        os.system(\"mount | grep \u0027xfs\u0027 | grep \u0027pquota\u0027\")"},{"line_number":68,"context_line":"                    if return_code:"},{"line_number":69,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":70,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_a3c45360","line":67,"range":{"start_line":67,"start_character":23,"end_line":67,"end_character":71},"in_reply_to":"df7087c5_da463822","updated":"2018-03-13 15:45:09.000000000","message":"To address @Shengqin\u0027s comment, perhaps the command could be (UNTESTED):\n\n  $ DEVICE\u003d$(df /var/lib/docker/ | awk \u0027FNR\u003d\u003d2 {print $1}\u0027)\n  $ mount | grep $DEVICE | grep \u0027xfs\u0027 | grep \u0027pquota\u0027\n\nI assume CONF.docker_data_root is /var/lib/docker in above commands.","commit_id":"3dc5de76f45fdec37f0520e3987434f590b8b958"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"d28159b818170c03c9734b3cee21be1218a9ab87","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                        return"},{"line_number":66,"context_line":"                    # Check project quota mount option"},{"line_number":67,"context_line":"                    return_code \u003d os.system("},{"line_number":68,"context_line":"                        \"mount | grep $(df /var/lib/docker | \""},{"line_number":69,"context_line":"                        \"awk \u0027FNR\u003d\u003d2 {print $1}\u0027) |grep \u0027xfs\u0027 |\""},{"line_number":70,"context_line":"                        \" grep \u0027pquota\u0027\")"},{"line_number":71,"context_line":"                    if return_code:"}],"source_content_type":"text/x-python","patch_set":7,"id":"df7087c5_780b34d5","line":68,"range":{"start_line":68,"start_character":43,"end_line":68,"end_character":58},"updated":"2018-03-14 08:51:12.000000000","message":"hardcode here due to PEP8 check failure. It has security issues just when the function was run with arguments taken from users.\n\n\u003e\u003e Issue: [B605:start_process_with_a_shell] Starting a process with a shell, possible injection detected, security iss\nue.\n   Severity: High   Confidence: High\n   Location: zun/container/docker/host.py:73","commit_id":"84fbb03588730aff44f32ea456422a86a8cd2606"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0b2c67adf656a4327f9053a0a3ead853e97993b2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                            {\u0027old\u0027: self._hostname, \u0027new\u0027: hostname})"},{"line_number":48,"context_line":"        return self._hostname"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def check_supported_disk_quota(self):"},{"line_number":51,"context_line":"        \"\"\"Check your system be supported disk quota or not\"\"\""},{"line_number":52,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":53,"context_line":"            info \u003d docker.info()"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_6bf2659c","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":34},"updated":"2018-03-15 03:02:34.000000000","message":"This method looks a bit complicated and I would suggest to split this methods into several. From my point of view, it can be split into the following:\n\n  def get_docker_info(self)\n  def get_storage_driver(self, docker_info)\n  def get_default_base_size(self, docker_info)\n  def check_supported_disk_quota(self, docker_info)","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"f885e2f885bc45ed57a385aa1a4a405daeeb33a0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                            {\u0027old\u0027: self._hostname, \u0027new\u0027: hostname})"},{"line_number":48,"context_line":"        return self._hostname"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def check_supported_disk_quota(self):"},{"line_number":51,"context_line":"        \"\"\"Check your system be supported disk quota or not\"\"\""},{"line_number":52,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":53,"context_line":"            info \u003d docker.info()"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_413f1886","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":34},"in_reply_to":"df7087c5_5bb06add","updated":"2018-03-16 10:15:44.000000000","message":"I combine 3 first methods with one method such as get_storage_info().","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"83ad2d1132e017ca220867cce2a4cda32667b7d4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                            {\u0027old\u0027: self._hostname, \u0027new\u0027: hostname})"},{"line_number":48,"context_line":"        return self._hostname"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def check_supported_disk_quota(self):"},{"line_number":51,"context_line":"        \"\"\"Check your system be supported disk quota or not\"\"\""},{"line_number":52,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":53,"context_line":"            info \u003d docker.info()"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_5bb06add","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":34},"in_reply_to":"df7087c5_6bf2659c","updated":"2018-03-16 08:39:23.000000000","message":"Ok, I\u0027ll do it soon.","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0b2c67adf656a4327f9053a0a3ead853e97993b2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":65,"context_line":"                        return"},{"line_number":66,"context_line":"                    # Check project quota mount option"},{"line_number":67,"context_line":"                    return_code \u003d os.system("},{"line_number":68,"context_line":"                        \"mount | grep $(df /var/lib/docker | \""},{"line_number":69,"context_line":"                        \"awk \u0027FNR\u003d\u003d2 {print $1}\u0027) |grep \u0027xfs\u0027 |\""},{"line_number":70,"context_line":"                        \" grep \u0027pquota\u0027\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_abd2bd26","line":67,"range":{"start_line":67,"start_character":34,"end_line":67,"end_character":43},"updated":"2018-03-15 03:02:34.000000000","message":"I think it is better to use privsep to execute this command for security reason. However, feel free to enhance it in a separated patch with a tech-debt bug.","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"83ad2d1132e017ca220867cce2a4cda32667b7d4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":65,"context_line":"                        return"},{"line_number":66,"context_line":"                    # Check project quota mount option"},{"line_number":67,"context_line":"                    return_code \u003d os.system("},{"line_number":68,"context_line":"                        \"mount | grep $(df /var/lib/docker | \""},{"line_number":69,"context_line":"                        \"awk \u0027FNR\u003d\u003d2 {print $1}\u0027) |grep \u0027xfs\u0027 |\""},{"line_number":70,"context_line":"                        \" grep \u0027pquota\u0027\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_fb1a9ec3","line":67,"range":{"start_line":67,"start_character":34,"end_line":67,"end_character":43},"in_reply_to":"df7087c5_abd2bd26","updated":"2018-03-16 08:39:23.000000000","message":"I\u0027ll try this way :)","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"f885e2f885bc45ed57a385aa1a4a405daeeb33a0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":65,"context_line":"                        return"},{"line_number":66,"context_line":"                    # Check project quota mount option"},{"line_number":67,"context_line":"                    return_code \u003d os.system("},{"line_number":68,"context_line":"                        \"mount | grep $(df /var/lib/docker | \""},{"line_number":69,"context_line":"                        \"awk \u0027FNR\u003d\u003d2 {print $1}\u0027) |grep \u0027xfs\u0027 |\""},{"line_number":70,"context_line":"                        \" grep \u0027pquota\u0027\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_01760071","line":67,"range":{"start_line":67,"start_character":34,"end_line":67,"end_character":43},"in_reply_to":"df7087c5_fb1a9ec3","updated":"2018-03-16 10:15:44.000000000","message":"Done","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0b2c67adf656a4327f9053a0a3ead853e97993b2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    if return_code:"},{"line_number":72,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":73,"context_line":"                else:"},{"line_number":74,"context_line":"                    self.default_base_size \u003d \\"},{"line_number":75,"context_line":"                        float(driver_status.get(\u0027Base Device Size\u0027)."},{"line_number":76,"context_line":"                              strip(\u0027GB\u0027))"},{"line_number":77,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_eb82f5ff","line":74,"range":{"start_line":74,"start_character":25,"end_line":74,"end_character":42},"updated":"2018-03-15 03:02:34.000000000","message":"If storage driver is overlay2, could we still set default_base_size by using \"df /var/lib/docker/\" ? Just want to bring up the idea and I am not sure if it is a good idea.","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"83ad2d1132e017ca220867cce2a4cda32667b7d4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    if return_code:"},{"line_number":72,"context_line":"                        self.sp_disk_quota \u003d False"},{"line_number":73,"context_line":"                else:"},{"line_number":74,"context_line":"                    self.default_base_size \u003d \\"},{"line_number":75,"context_line":"                        float(driver_status.get(\u0027Base Device Size\u0027)."},{"line_number":76,"context_line":"                              strip(\u0027GB\u0027))"},{"line_number":77,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_bbcc2635","line":74,"range":{"start_line":74,"start_character":25,"end_line":74,"end_character":42},"in_reply_to":"df7087c5_eb82f5ff","updated":"2018-03-16 08:39:23.000000000","message":"\"df /var/lib/docker\" doesn\u0027t give us default_base_device_size information. And if storage-driver is overlay2, we don\u0027t need default_base_device_size to check requirements.","commit_id":"35c0ec9f8e06f82c1af848fc368c9efd6e5239c3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b7fc5b07313ff042cbcf355d03734922aec871d3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def get_storage_info(self):"},{"line_number":52,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":53,"context_line":"            info \u003d docker.info()"},{"line_number":54,"context_line":"            self.storage_driver \u003d str(info[\u0027Driver\u0027])"},{"line_number":55,"context_line":"            # DriverStatus is list. Convert it to dict"},{"line_number":56,"context_line":"            driver_status \u003d dict(info[\u0027DriverStatus\u0027])"},{"line_number":57,"context_line":"            backing_filesystem \u003d \\"}],"source_content_type":"text/x-python","patch_set":9,"id":"df7087c5_e8af1b29","line":54,"range":{"start_line":54,"start_character":12,"end_line":54,"end_character":53},"updated":"2018-03-17 03:13:06.000000000","message":"Nit: The method name \"get_storage_info\" seems to suggest that this is a getter method. However, this method actually modifies the state, which looks a bit confused. How about returning this field instead? Somewhere in upper stack should capture the return value and set it.\n\nIn this case, this method needs to return three values:\n\n  return (driver_state, backing_filesystem, storage_driver)","commit_id":"8f15a78a195ae95c4e2cadbd823dea3ea0d9cec9"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b7fc5b07313ff042cbcf355d03734922aec871d3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                str(driver_status.get(\u0027Backing Filesystem\u0027))"},{"line_number":59,"context_line":"        return (driver_status, backing_filesystem)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def check_supported_disk_quota(self):"},{"line_number":62,"context_line":"        \"\"\"Check your system be supported disk quota or not\"\"\""},{"line_number":63,"context_line":"        driver_status, backing_filesystem \u003d self.get_storage_info()"},{"line_number":64,"context_line":"        if self.storage_driver in consts.SUPPORTED_STORAGE_DRIVERS:"}],"source_content_type":"text/x-python","patch_set":9,"id":"df7087c5_6861cb11","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":34},"updated":"2018-03-17 03:13:06.000000000","message":"Ditto. By looking at the method name, I would expect this method is a getter and returns the result instead of setting internal state.","commit_id":"8f15a78a195ae95c4e2cadbd823dea3ea0d9cec9"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b7fc5b07313ff042cbcf355d03734922aec871d3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def check_supported_disk_quota(self):"},{"line_number":62,"context_line":"        \"\"\"Check your system be supported disk quota or not\"\"\""},{"line_number":63,"context_line":"        driver_status, backing_filesystem \u003d self.get_storage_info()"},{"line_number":64,"context_line":"        if self.storage_driver in consts.SUPPORTED_STORAGE_DRIVERS:"},{"line_number":65,"context_line":"            if self.storage_driver \u003d\u003d \u0027overlay2\u0027:"},{"line_number":66,"context_line":"                self.sp_disk_quota \u003d True"},{"line_number":67,"context_line":"                # Check backing filesystem"}],"source_content_type":"text/x-python","patch_set":9,"id":"df7087c5_e874fbd2","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":67},"updated":"2018-03-17 03:13:06.000000000","message":"Nit: personally, I think it will look better by moving the shorter branch up:\n\n    if self.storage_driver not in consts.SUPPORTED_STORAGE_DRIVERS:\n        self.sp_disk_quota \u003d False\n    else:\n        ...","commit_id":"8f15a78a195ae95c4e2cadbd823dea3ea0d9cec9"}]}
