)]}'
{"zun/common/utils.py":[{"author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"change_message_id":"336fdc0c64c86b0a4e4b5c09e03a54a7b7548ad6","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    image_parts \u003d image.split(\u0027:\u0027, 1)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    image_repo \u003d image_parts[0]"},{"line_number":155,"context_line":"    if driver \u003d\u003d \u0027glance\u0027:"},{"line_number":156,"context_line":"        image_tag \u003d \u0027\u0027"},{"line_number":157,"context_line":"    else:"},{"line_number":158,"context_line":"        image_tag \u003d \u0027latest\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_16721fae","line":155,"updated":"2018-03-23 06:35:28.000000000","message":"maybe we could get the driver from the driver list in conf/image_driver.py instead.","commit_id":"9cc3e60bbcb9dfb1a626bbe4bc2f39fe0f8ebebb"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"700c72d4ac1d289a968bf5a6978cd986c6a4361c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    image_parts \u003d image.split(\u0027:\u0027, 1)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    image_repo \u003d image_parts[0]"},{"line_number":155,"context_line":"    if driver \u003d\u003d \u0027glance\u0027:"},{"line_number":156,"context_line":"        image_tag \u003d \u0027\u0027"},{"line_number":157,"context_line":"    else:"},{"line_number":158,"context_line":"        image_tag \u003d \u0027latest\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_5f3c1fe0","line":155,"in_reply_to":"df7087c5_16721fae","updated":"2018-03-23 14:46:14.000000000","message":"This is a good point. If we prefer to do a validation of the driver name against conf, this should happen in the API layer (right before we create the container object in particular) so that we can reject the request immediately if the input is invalid. I will create a bug report for that. This is irrelevant to this patch though.","commit_id":"9cc3e60bbcb9dfb1a626bbe4bc2f39fe0f8ebebb"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"fde70fb1769f5f13ffcafda410d45e018615414d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    image_parts \u003d image.split(\u0027:\u0027, 1)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    image_repo \u003d image_parts[0]"},{"line_number":155,"context_line":"    if driver \u003d\u003d \u0027glance\u0027:"},{"line_number":156,"context_line":"        image_tag \u003d \u0027\u0027"},{"line_number":157,"context_line":"    else:"},{"line_number":158,"context_line":"        image_tag \u003d \u0027latest\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_dae91de3","line":155,"in_reply_to":"df7087c5_5f3c1fe0","updated":"2018-03-23 14:57:33.000000000","message":"Bug report: https://bugs.launchpad.net/zun/+bug/1758358","commit_id":"9cc3e60bbcb9dfb1a626bbe4bc2f39fe0f8ebebb"}]}