)]}'
{"zun/api/controllers/v1/views/containers_view.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"949000abd7812dcadb80f62d5c3456a16a26ccf8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    \u0027runtime\u0027,"},{"line_number":46,"context_line":"    \u0027hostname\u0027,"},{"line_number":47,"context_line":"    \u0027disk\u0027,"},{"line_number":48,"context_line":"    \u0027auto_heal\u0027,"},{"line_number":49,"context_line":")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_f642e00e","line":48,"range":{"start_line":48,"start_character":5,"end_line":48,"end_character":14},"updated":"2018-04-02 03:25:35.000000000","message":"We need to document this parameter in api-ref: https://developer.openstack.org/api-ref/application-container/ , but this can be done in a follow-up patch.","commit_id":"9f9ea6e950b6640ef435462c724334c346556631"}],"zun/container/docker/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"e27980b98ce26f0c3c97fd2bef32b2489896ecaf","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        try:"},{"line_number":363,"context_line":"            if (container.auto_heal and"},{"line_number":364,"context_line":"                    container.status in rebuild_status):"},{"line_number":365,"context_line":"                compute_api.container_rebuild(context, container)"},{"line_number":366,"context_line":"            else:"},{"line_number":367,"context_line":"                LOG.warning(\"Container %s was recorded in DB but \""},{"line_number":368,"context_line":"                            \"missing in docker\", container.uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_5e6f41fb","line":365,"range":{"start_line":365,"start_character":46,"end_line":365,"end_character":53},"updated":"2018-03-30 03:44:07.000000000","message":"I downloaded this patch and tried to rebuild an \u0027auto_heal\u0027 container, but it failed: http://paste.openstack.org/show/717986/ . I think this is because you are using an admin context to rebuild the container in the admin tenant but the container was originally in the user\u0027s tenant. This is why it cannot find the tenant security group as shown in the paste.","commit_id":"f25cb58b806dedbafb5ec7114f9ff4a3f3a26739"},{"author":{"_account_id":23829,"name":"weikeyou","email":"wei.keyou@zte.com.cn","username":"weikeyou"},"change_message_id":"0765e24365c2e1ca85f5ed0decc15025b6b2c34d","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            else:"},{"line_number":367,"context_line":"                LOG.warning(\"Container %s was recorded in DB but \""},{"line_number":368,"context_line":"                            \"missing in docker\", container.uuid)"},{"line_number":369,"context_line":"                container.status \u003d consts.ERROR"},{"line_number":370,"context_line":"                container.save(context)"},{"line_number":371,"context_line":"        except Exception as e:"},{"line_number":372,"context_line":"            LOG.warning(\"heal container with rebuilding failed, \""},{"line_number":373,"context_line":"                        \"err code: %s\", e)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_0e08cd8f","line":370,"range":{"start_line":369,"start_character":0,"end_line":370,"end_character":39},"updated":"2018-03-29 12:17:35.000000000","message":"Can we set the container which auto_heal is False to ERROR? We can set non-existent container in docker to Error here, instead of setting error when show it, then we can show it from DB directly.","commit_id":"f25cb58b806dedbafb5ec7114f9ff4a3f3a26739"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"e27980b98ce26f0c3c97fd2bef32b2489896ecaf","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            else:"},{"line_number":367,"context_line":"                LOG.warning(\"Container %s was recorded in DB but \""},{"line_number":368,"context_line":"                            \"missing in docker\", container.uuid)"},{"line_number":369,"context_line":"                container.status \u003d consts.ERROR"},{"line_number":370,"context_line":"                container.save(context)"},{"line_number":371,"context_line":"        except Exception as e:"},{"line_number":372,"context_line":"            LOG.warning(\"heal container with rebuilding failed, \""},{"line_number":373,"context_line":"                        \"err code: %s\", e)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_3efdad6d","line":370,"range":{"start_line":369,"start_character":0,"end_line":370,"end_character":39},"in_reply_to":"bf659307_0e08cd8f","updated":"2018-03-30 03:44:07.000000000","message":"I am fine with that. However, we\u0027d better to set the status_reason as well. The status_reason should explain why the container is in ERROR state.","commit_id":"f25cb58b806dedbafb5ec7114f9ff4a3f3a26739"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7a3e3d311120becddca617b8005448b180223e42","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            if (container.auto_heal and"},{"line_number":364,"context_line":"                    container.status in rebuild_status):"},{"line_number":365,"context_line":"                context.project_id \u003d container.project_id"},{"line_number":366,"context_line":"                compute_api.container_rebuild(context, container)"},{"line_number":367,"context_line":"            else:"},{"line_number":368,"context_line":"                LOG.warning(\"Container %s was recorded in DB but \""},{"line_number":369,"context_line":"                            \"missing in docker\", container.uuid)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_48f5b856","line":366,"range":{"start_line":366,"start_character":16,"end_line":366,"end_character":27},"updated":"2019-01-01 03:22:40.000000000","message":"Hi @weikeyou,\n\nI wonder if it is fine to do a compute API call in the docker driver? Normally, we won\u0027t do something like this in a driver so this looks a bit odd to me.","commit_id":"9f9ea6e950b6640ef435462c724334c346556631"},{"author":{"_account_id":23829,"name":"weikeyou","email":"wei.keyou@zte.com.cn","username":"weikeyou"},"change_message_id":"18c440f7f2414ee2af8cb4e93e39a0b75fda897a","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            if (container.auto_heal and"},{"line_number":364,"context_line":"                    container.status in rebuild_status):"},{"line_number":365,"context_line":"                context.project_id \u003d container.project_id"},{"line_number":366,"context_line":"                compute_api.container_rebuild(context, container)"},{"line_number":367,"context_line":"            else:"},{"line_number":368,"context_line":"                LOG.warning(\"Container %s was recorded in DB but \""},{"line_number":369,"context_line":"                            \"missing in docker\", container.uuid)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_01d1db54","line":366,"range":{"start_line":366,"start_character":16,"end_line":366,"end_character":27},"in_reply_to":"1f769fc5_48f5b856","updated":"2019-01-02 02:13:41.000000000","message":"OK","commit_id":"9f9ea6e950b6640ef435462c724334c346556631"},{"author":{"_account_id":23829,"name":"weikeyou","email":"wei.keyou@zte.com.cn","username":"weikeyou"},"change_message_id":"79a79e69ad84da35913747b4d25a0561ecff525b","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            if (container.auto_heal and"},{"line_number":364,"context_line":"                    container.status in rebuild_status):"},{"line_number":365,"context_line":"                context.project_id \u003d container.project_id"},{"line_number":366,"context_line":"                compute_api.container_rebuild(context, container)"},{"line_number":367,"context_line":"            else:"},{"line_number":368,"context_line":"                LOG.warning(\"Container %s was recorded in DB but \""},{"line_number":369,"context_line":"                            \"missing in docker\", container.uuid)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_413cb392","line":366,"range":{"start_line":366,"start_character":16,"end_line":366,"end_character":27},"in_reply_to":"1f769fc5_48f5b856","updated":"2019-01-02 02:23:07.000000000","message":"You are right.I\u0027ll think of a way to modify it.","commit_id":"9f9ea6e950b6640ef435462c724334c346556631"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"77d884708933191a6cce06141609007cb072025f","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                context.project_id \u003d container.project_id"},{"line_number":366,"context_line":"                compute_api.container_rebuild(context, container)"},{"line_number":367,"context_line":"            else:"},{"line_number":368,"context_line":"                LOG.warning(\"Container %s was recorded in DB but \""},{"line_number":369,"context_line":"                            \"missing in docker\", container.uuid)"},{"line_number":370,"context_line":"                container.status \u003d consts.ERROR"},{"line_number":371,"context_line":"                msg \u003d \"No such container:%s in docker\" % \\"},{"line_number":372,"context_line":"                      (container.container_id)"},{"line_number":373,"context_line":"                container.status_reason \u003d six.text_type(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_f73f3784","line":370,"range":{"start_line":368,"start_character":16,"end_line":370,"end_character":47},"updated":"2018-04-02 13:33:03.000000000","message":"hi,keyou,would we rebuild the containers missing in docker?","commit_id":"9f9ea6e950b6640ef435462c724334c346556631"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"e3a9c3fb0d02d5d1c546df9acb4bff44bcc12eb8","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                context.project_id \u003d container.project_id"},{"line_number":366,"context_line":"                compute_api.container_rebuild(context, container)"},{"line_number":367,"context_line":"            else:"},{"line_number":368,"context_line":"                LOG.warning(\"Container %s was recorded in DB but \""},{"line_number":369,"context_line":"                            \"missing in docker\", container.uuid)"},{"line_number":370,"context_line":"                container.status \u003d consts.ERROR"},{"line_number":371,"context_line":"                msg \u003d \"No such container:%s in docker\" % \\"},{"line_number":372,"context_line":"                      (container.container_id)"},{"line_number":373,"context_line":"                container.status_reason \u003d six.text_type(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_c170c375","line":370,"range":{"start_line":368,"start_character":16,"end_line":370,"end_character":47},"in_reply_to":"bf659307_e89d11bc","updated":"2019-01-02 02:36:17.000000000","message":"See here: https://review.openstack.org/#/c/627911/","commit_id":"9f9ea6e950b6640ef435462c724334c346556631"},{"author":{"_account_id":23829,"name":"weikeyou","email":"wei.keyou@zte.com.cn","username":"weikeyou"},"change_message_id":"b58063df898408643c198ce1b88621a9b451967d","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                context.project_id \u003d container.project_id"},{"line_number":366,"context_line":"                compute_api.container_rebuild(context, container)"},{"line_number":367,"context_line":"            else:"},{"line_number":368,"context_line":"                LOG.warning(\"Container %s was recorded in DB but \""},{"line_number":369,"context_line":"                            \"missing in docker\", container.uuid)"},{"line_number":370,"context_line":"                container.status \u003d consts.ERROR"},{"line_number":371,"context_line":"                msg \u003d \"No such container:%s in docker\" % \\"},{"line_number":372,"context_line":"                      (container.container_id)"},{"line_number":373,"context_line":"                container.status_reason \u003d six.text_type(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_e89d11bc","line":370,"range":{"start_line":368,"start_character":16,"end_line":370,"end_character":47},"in_reply_to":"bf659307_f73f3784","updated":"2018-04-03 00:52:39.000000000","message":"the container which auto_heal is True and status is in  rebuild_status will be rebuilt. Others will be set ERROR, so we wouldn\u0027t set them when show it.","commit_id":"9f9ea6e950b6640ef435462c724334c346556631"}]}