)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ba7ee26df97d010306215b712c6fabe39b5a5100","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        if kwargs.get(\u0027image\u0027):"},{"line_number":685,"context_line":"            container.image \u003d kwargs.get(\u0027image\u0027)"},{"line_number":686,"context_line":"        if kwargs.get(\u0027image_driver\u0027):"},{"line_number":687,"context_line":"            container.image_driver \u003d kwargs.get(\u0027image_driver\u0027)"},{"line_number":688,"context_line":"        LOG.debug(\u0027Calling compute.container_rebuild with %s\u0027,"},{"line_number":689,"context_line":"                  container.uuid)"},{"line_number":690,"context_line":"        context \u003d pecan.request.context"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_6ba3949f","line":687,"range":{"start_line":687,"start_character":49,"end_line":687,"end_character":61},"updated":"2018-03-28 15:26:42.000000000","message":"However, I feel it is necessary to check the validity of the image_driver since an invalid image_driver will crash the zun-compute process.\n\nWe have a similar issue on the POST /containers as well: https://bugs.launchpad.net/zun/+bug/1758358","commit_id":"a3966d4700e22720ff553fbcbb9326f42905e9f7"},{"author":{"_account_id":21428,"name":"JiWei","email":"17366060309@163.com","username":"WeiJi"},"change_message_id":"13a106caab457216f42d227c9da616e2ae9ec44b","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        container \u003d utils.get_container(container_ident)"},{"line_number":682,"context_line":"        check_policy_on_container(container.as_dict(), \"container:rebuild\")"},{"line_number":683,"context_line":"        utils.validate_container_state(container, \u0027rebuild\u0027)"},{"line_number":684,"context_line":"        if kwargs.get(\u0027image\u0027):"},{"line_number":685,"context_line":"            container.image \u003d kwargs.get(\u0027image\u0027)"},{"line_number":686,"context_line":"        if kwargs.get(\u0027image_driver\u0027):"},{"line_number":687,"context_line":"            container.image_driver \u003d kwargs.get(\u0027image_driver\u0027)"},{"line_number":688,"context_line":"        LOG.debug(\u0027Calling compute.container_rebuild with %s\u0027,"},{"line_number":689,"context_line":"                  container.uuid)"},{"line_number":690,"context_line":"        context \u003d pecan.request.context"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_28ea8c0e","line":687,"range":{"start_line":684,"start_character":0,"end_line":687,"end_character":63},"updated":"2018-03-28 09:15:03.000000000","message":"I\u0027m not sure whether we need to check whether the image exists before deleting the source container.\nAfter all, the image will be checked twice when creating the new container","commit_id":"a3966d4700e22720ff553fbcbb9326f42905e9f7"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ba7ee26df97d010306215b712c6fabe39b5a5100","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        container \u003d utils.get_container(container_ident)"},{"line_number":682,"context_line":"        check_policy_on_container(container.as_dict(), \"container:rebuild\")"},{"line_number":683,"context_line":"        utils.validate_container_state(container, \u0027rebuild\u0027)"},{"line_number":684,"context_line":"        if kwargs.get(\u0027image\u0027):"},{"line_number":685,"context_line":"            container.image \u003d kwargs.get(\u0027image\u0027)"},{"line_number":686,"context_line":"        if kwargs.get(\u0027image_driver\u0027):"},{"line_number":687,"context_line":"            container.image_driver \u003d kwargs.get(\u0027image_driver\u0027)"},{"line_number":688,"context_line":"        LOG.debug(\u0027Calling compute.container_rebuild with %s\u0027,"},{"line_number":689,"context_line":"                  container.uuid)"},{"line_number":690,"context_line":"        context \u003d pecan.request.context"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_6be71414","line":687,"range":{"start_line":684,"start_character":0,"end_line":687,"end_character":63},"in_reply_to":"bf659307_28ea8c0e","updated":"2018-03-28 15:26:42.000000000","message":"I think the check for existent of image is optional. As you mentioned, the image will be checked on creating.","commit_id":"a3966d4700e22720ff553fbcbb9326f42905e9f7"}],"zun/tests/unit/api/controllers/v1/test_containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"88f0e1c6d79d91314ad4067cda386a944f2542c3","unresolved":false,"context_lines":[{"line_number":1013,"context_line":"            self.post(\u0027/v1/containers/%s/%s/\u0027 % (test_object.uuid,"},{"line_number":1014,"context_line":"                                                 \u0027unpause\u0027))"},{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"    @patch(\u0027zun.common.policy.enforce\u0027)"},{"line_number":1017,"context_line":"    def test_rebuild_container(self, mock_policy):"},{"line_number":1018,"context_line":"        mock_policy.return_value \u003d True"},{"line_number":1019,"context_line":"        uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_1e7c691d","line":1016,"updated":"2018-03-30 03:12:34.000000000","message":"I think you need to patch \u0027zun.compute.api.API.container_rebuild\u0027 as well. This might be the cause of the gate failure.","commit_id":"1dd9940892cce343af2041ebe1c0aecfb7c9ba36"}]}