)]}'
{"zun/compute/manager.py":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"98ff7fc8ed091e5408bc6cea4a04397ad9e08c9b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                    self._fail_container(context, container,"},{"line_number":207,"context_line":"                                         msg, unset_host\u003dTrue)"},{"line_number":208,"context_line":"                    raise exception.Invalid(msg)"},{"line_number":209,"context_line":"        # NOTE(kiennt): Only raise Exception when user passes disk size and"},{"line_number":210,"context_line":"        #               the disk quota feature isn\u0027t supported in host."},{"line_number":211,"context_line":"        if not self.driver.node_support_disk_quota() and container.disk:"},{"line_number":212,"context_line":"            msg \u003d _(\u0027Your host does not support disk quota feature.\u0027)"},{"line_number":213,"context_line":"            self._fail_container(context, container, msg, unset_host\u003dTrue)"},{"line_number":214,"context_line":"            raise exception.Invalid(msg)"},{"line_number":215,"context_line":"        if self.driver.node_support_disk_quota() and not container.disk:"},{"line_number":216,"context_line":"            container.disk \u003d CONF.default_disk"},{"line_number":217,"context_line":"            return"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def container_create(self, context, limits, requested_networks,"},{"line_number":220,"context_line":"                         requested_volumes, container, run, pci_requests\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_5975fff8","side":"PARENT","line":217,"range":{"start_line":209,"start_character":8,"end_line":217,"end_character":18},"updated":"2018-04-02 07:05:55.000000000","message":"This block already ignores default_disk config if unsupported. Exception is raised when user passes disk size and unsupported. So in the case, user don\u0027t pass disk size, just ignore it. But I agree with you, a warning message will be a good idea. How about rework this block a little bit?\n\n# NOTE(kiennt): Only raise Exception when user passes disk size and\n#               the disk quota feature isn\u0027t supported in host.\nif not self.driver.node_support_disk_quota():\n    if container.disk:\n        msg \u003d _(\u0027Your host does not support disk quota feature.\u0027)\n        self._fail_container(context, container, msg, unset_host\u003dTrue)\n        raise exception.Invalid(msg)\n    LOG.warning(\"Ignore the configured default disk size because \"\n                \"the driver does not support disk quota.\")\nif self.driver.node_support_disk_quota() and not container.disk:\n    container.disk \u003d CONF.default_disk\n    return","commit_id":"24a6602f0bb43946b115cd8a5490901382000efb"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"77b723f08fa840741a0b82271248ef0bc65b39cd","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                    self._fail_container(context, container,"},{"line_number":207,"context_line":"                                         msg, unset_host\u003dTrue)"},{"line_number":208,"context_line":"                    raise exception.Invalid(msg)"},{"line_number":209,"context_line":"        # NOTE(kiennt): Only raise Exception when user passes disk size and"},{"line_number":210,"context_line":"        #               the disk quota feature isn\u0027t supported in host."},{"line_number":211,"context_line":"        if not self.driver.node_support_disk_quota() and container.disk:"},{"line_number":212,"context_line":"            msg \u003d _(\u0027Your host does not support disk quota feature.\u0027)"},{"line_number":213,"context_line":"            self._fail_container(context, container, msg, unset_host\u003dTrue)"},{"line_number":214,"context_line":"            raise exception.Invalid(msg)"},{"line_number":215,"context_line":"        if self.driver.node_support_disk_quota() and not container.disk:"},{"line_number":216,"context_line":"            container.disk \u003d CONF.default_disk"},{"line_number":217,"context_line":"            return"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def container_create(self, context, limits, requested_networks,"},{"line_number":220,"context_line":"                         requested_volumes, container, run, pci_requests\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_7a622eda","side":"PARENT","line":217,"range":{"start_line":209,"start_character":8,"end_line":217,"end_character":18},"in_reply_to":"bf659307_5975fff8","updated":"2018-04-02 14:30:23.000000000","message":"Done","commit_id":"24a6602f0bb43946b115cd8a5490901382000efb"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"98ff7fc8ed091e5408bc6cea4a04397ad9e08c9b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.default_disk \u003d CONF.default_disk"},{"line_number":58,"context_line":"        if not self.driver.node_support_disk_quota() and CONF.default_disk:"},{"line_number":59,"context_line":"            LOG.warning(\"Ignore the configured default disk size because \""},{"line_number":60,"context_line":"                        \"the driver doesnot support disk quota.\")"},{"line_number":61,"context_line":"            self.default_disk \u003d 0"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def restore_running_container(self, context, container, current_status):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_794243ad","line":60,"range":{"start_line":60,"start_character":36,"end_line":60,"end_character":43},"updated":"2018-04-02 07:05:55.000000000","message":"Nit: does not","commit_id":"86d4aee021270bfa4b8bee0f3aeee1182e8489b0"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"98ff7fc8ed091e5408bc6cea4a04397ad9e08c9b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        if not self.driver.node_support_disk_quota() and CONF.default_disk:"},{"line_number":59,"context_line":"            LOG.warning(\"Ignore the configured default disk size because \""},{"line_number":60,"context_line":"                        \"the driver doesnot support disk quota.\")"},{"line_number":61,"context_line":"            self.default_disk \u003d 0"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def restore_running_container(self, context, container, current_status):"},{"line_number":64,"context_line":"        if (container.status \u003d\u003d consts.RUNNING and"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_f9473376","line":61,"range":{"start_line":61,"start_character":12,"end_line":61,"end_character":33},"updated":"2018-04-02 07:05:55.000000000","message":"Container, that is created after, has a zero disk size. IMO\u003c it makes the user confused.","commit_id":"86d4aee021270bfa4b8bee0f3aeee1182e8489b0"}]}