)]}'
{"zun/servicegroup/zun_service_periodic.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7eb63abe39489264dbd98d0cf889794f62d46e1f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                self.zun_service_ref.create()"},{"line_number":54,"context_line":"        self.zun_service_ref.report_state_up()"},{"line_number":55,"context_line":"        self.zun_service_ref.availability_zone \u003d self.availability_zone"},{"line_number":56,"context_line":"        self.zun_service_ref.save()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def setup(conf, binary, tg):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_d4bab4be","line":56,"range":{"start_line":56,"start_character":29,"end_line":56,"end_character":33},"updated":"2018-04-08 15:08:06.000000000","message":"It looks the call of \u0027report_state_up\u0027 will do a \u0027save\u0027. In here, it calls a \u0027save\u0027 again which is undesirable in performance perspective. Could we reduce the number of \u0027save\u0027 to one?","commit_id":"fc030ee194ff85f5067d57310ccc08b1f058c862"},{"author":{"_account_id":23829,"name":"weikeyou","email":"wei.keyou@zte.com.cn","username":"weikeyou"},"change_message_id":"9001923447e9c775a9161cb95e52c1eccd1843b3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                self.zun_service_ref.create()"},{"line_number":54,"context_line":"        self.zun_service_ref.report_state_up()"},{"line_number":55,"context_line":"        self.zun_service_ref.availability_zone \u003d self.availability_zone"},{"line_number":56,"context_line":"        self.zun_service_ref.save()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def setup(conf, binary, tg):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_fa49e15f","line":56,"range":{"start_line":56,"start_character":29,"end_line":56,"end_character":33},"in_reply_to":"bf659307_d4bab4be","updated":"2018-04-09 00:46:28.000000000","message":"Thank you for your review. As your advice, it is better to put \u0027availability_zone\u0027 before \u0027report_state_up\u0027 and then reduce the save().","commit_id":"fc030ee194ff85f5067d57310ccc08b1f058c862"}]}