)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"53325f6a1a7743753872d23f29f14cb5e84f1e09","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     weikeyou \u003cweikeyou@126.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-30 19:50:36 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"support-healthycheck"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The docker has supported healthcheck. It is useful for application container."},{"line_number":10,"context_line":"Zun may integration these options."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_c5ee0bb4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"updated":"2018-06-12 11:29:36.000000000","message":"Please add one line title for the commit. Example:\n\nSupport health check for Docker containers","commit_id":"7536b90a857b93ca5c233886f6aa8ce5f8d5f385"}],"zun/api/controllers/v1/schemas/parameter_types.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7034aacba1c12c1d3fea1dcfca7da0c90e028d45","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                \u0027minLength\u0027: 1,"},{"line_number":176,"context_line":"                \u0027maxLength\u0027: 255"},{"line_number":177,"context_line":"            },"},{"line_number":178,"context_line":"            \u0027internal\u0027: {"},{"line_number":179,"context_line":"                \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]"},{"line_number":180,"context_line":"            },"},{"line_number":181,"context_line":"            \u0027retries\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2010ffff","line":178,"range":{"start_line":178,"start_character":13,"end_line":178,"end_character":21},"updated":"2018-05-31 02:26:25.000000000","message":"It seems you mean \u0027interval\u0027?","commit_id":"7536b90a857b93ca5c233886f6aa8ce5f8d5f385"}],"zun/container/docker/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7034aacba1c12c1d3fea1dcfca7da0c90e028d45","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                healthcheck \u003d {}"},{"line_number":279,"context_line":"                healthcheck[\u0027test\u0027] \u003d container.healthcheck.get(\u0027test\u0027, \u0027\u0027)"},{"line_number":280,"context_line":"                interval \u003d container.healthcheck.get(\u0027interval\u0027, \u00270\u0027)"},{"line_number":281,"context_line":"                healthcheck[\u0027interval\u0027] \u003d self._convert_healthcheck_para(interval)"},{"line_number":282,"context_line":"                healthcheck[\u0027retries\u0027] \u003d int(container.healthcheck."},{"line_number":283,"context_line":"                                             get(\u0027retries\u0027, 0))"},{"line_number":284,"context_line":"                timeout \u003d container.healthcheck.get(\u0027timeout\u0027, \u00270\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a0c2cf51","line":281,"range":{"start_line":281,"start_character":47,"end_line":281,"end_character":72},"updated":"2018-05-31 02:26:25.000000000","message":"I would suggest to take \u0027interval\u0027 as a number and implicitly assume it is the number of seconds. As a result, we can remove this complicated conversion which is not easy to maintain.\n\nHowever, if anyone has a requirement to specify time unit other than seconds (i.e. --interval \u00275m\u0027), we can implement it in python-zunclient instead.","commit_id":"7536b90a857b93ca5c233886f6aa8ce5f8d5f385"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7034aacba1c12c1d3fea1dcfca7da0c90e028d45","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                healthcheck[\u0027retries\u0027] \u003d int(container.healthcheck."},{"line_number":283,"context_line":"                                             get(\u0027retries\u0027, 0))"},{"line_number":284,"context_line":"                timeout \u003d container.healthcheck.get(\u0027timeout\u0027, \u00270\u0027)"},{"line_number":285,"context_line":"                healthcheck[\u0027timeout\u0027] \u003d self._convert_healthcheck_para(timeout)"},{"line_number":286,"context_line":"                kwargs[\u0027healthcheck\u0027] \u003d healthcheck"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"            kwargs[\u0027host_config\u0027] \u003d docker.create_host_config(**host_config)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_20ac7f9d","line":285,"range":{"start_line":285,"start_character":46,"end_line":285,"end_character":71},"updated":"2018-05-31 02:26:25.000000000","message":"Ditto, let\u0027s remove this conversion and treat timeout as a number.","commit_id":"7536b90a857b93ca5c233886f6aa8ce5f8d5f385"}]}