)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d95e34d158ebf0a39a318527f4de29d53d6118ac","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disk size is smaller than base_device_size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When disk size is none and base_device_size is larger than default_disk, the disk size is assigned to base_device_size."},{"line_number":10,"context_line":"Because base_device_size is float type, when converting to interger ,the disk size is smaller than base_device_size."},{"line_number":11,"context_line":"We need to assign the ceil of  base_device_size to the disk size."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_763d778b","line":9,"updated":"2018-07-31 01:37:28.000000000","message":"In general, the commit message is too long which make it a bit difficult to read. Could you make each line shorter. In particular, here is the commit message requirement [1]:\n\n* The first line should be limited to 50 characters and should not end with a period.\n* Subsequent lines should be wrapped at 72 characters.\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"b62b29382787b10784672260c4f6f0ed9de4abc2"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d95e34d158ebf0a39a318527f4de29d53d6118ac","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Disk size is smaller than base_device_size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When disk size is none and base_device_size is larger than default_disk, the disk size is assigned to base_device_size."},{"line_number":10,"context_line":"Because base_device_size is float type, when converting to interger ,the disk size is smaller than base_device_size."},{"line_number":11,"context_line":"We need to assign the ceil of  base_device_size to the disk size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5c3bfc7ce4c83c39a212040601792ff1ace2fdf5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_36905f96","line":10,"range":{"start_line":10,"start_character":86,"end_line":10,"end_character":115},"updated":"2018-07-31 01:37:28.000000000","message":"Could you update the commit message to add some explanation about what is the problem if the disk size is smaller than base_device_size?","commit_id":"b62b29382787b10784672260c4f6f0ed9de4abc2"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d95e34d158ebf0a39a318527f4de29d53d6118ac","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When disk size is none and base_device_size is larger than default_disk, the disk size is assigned to base_device_size."},{"line_number":10,"context_line":"Because base_device_size is float type, when converting to interger ,the disk size is smaller than base_device_size."},{"line_number":11,"context_line":"We need to assign the ceil of  base_device_size to the disk size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5c3bfc7ce4c83c39a212040601792ff1ace2fdf5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_96e4d343","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":64},"updated":"2018-07-31 01:37:28.000000000","message":"If we do that, the disk size will be bigger than the base_device_size?","commit_id":"b62b29382787b10784672260c4f6f0ed9de4abc2"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9f2f41c9297d08a2437f615bde365584ec53b640","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When disk size is none and base_device_size is larger than default_disk, the disk size is assigned to base_device_size."},{"line_number":10,"context_line":"Because base_device_size is float type, when converting to interger ,the disk size is smaller than base_device_size."},{"line_number":11,"context_line":"We need to assign the ceil of  base_device_size to the disk size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5c3bfc7ce4c83c39a212040601792ff1ace2fdf5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_a442d90b","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":64},"in_reply_to":"5f7c97a3_1000ac02","updated":"2018-08-01 00:51:16.000000000","message":"ACK. Sorry, I forgot that in before.","commit_id":"b62b29382787b10784672260c4f6f0ed9de4abc2"},{"author":{"_account_id":24115,"name":"Xianghui Zeng","email":"zengxh1981@126.com","username":"XianghuiZeng"},"change_message_id":"4d4b197a9347a28f4c3a5e8e8799b699666856d6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When disk size is none and base_device_size is larger than default_disk, the disk size is assigned to base_device_size."},{"line_number":10,"context_line":"Because base_device_size is float type, when converting to interger ,the disk size is smaller than base_device_size."},{"line_number":11,"context_line":"We need to assign the ceil of  base_device_size to the disk size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5c3bfc7ce4c83c39a212040601792ff1ace2fdf5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_1000ac02","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":64},"in_reply_to":"5f7c97a3_96e4d343","updated":"2018-08-01 00:35:10.000000000","message":"According to the code, if the disk size is smaller than the base_device_size, there will be an exception.","commit_id":"b62b29382787b10784672260c4f6f0ed9de4abc2"}]}