)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"3fd63d84dadfc7ba6fc25b6e911aa1f010d288d4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"When using multipath, detach volume failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using the same volume to create a container, it will fail"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I97551b72f9532b86658e997052d9937e658dc415"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_d9f91cc6","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":57},"updated":"2018-07-31 03:06:45.000000000","message":"@JiWei,\n\nCould you provide more details about this? In particular, what error you were seeing and what are the steps to reproduce it?\n\nIn general, I think it is better to create a bug about this and link to the bug report in the commit message.","commit_id":"317da4183747b76c977c50955da902e98f4ed29f"},{"author":{"_account_id":21428,"name":"JiWei","email":"17366060309@163.com","username":"WeiJi"},"change_message_id":"c7941bfdf4afd711f154e549d695fe7423e2f85d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"When using multipath, detach volume failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using the same volume to create a container, it will fail"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I97551b72f9532b86658e997052d9937e658dc415"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_27becb63","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":57},"in_reply_to":"5f7c97a3_d9f91cc6","updated":"2018-08-01 03:01:44.000000000","message":"Thanks, the problem description has been added and details can be seen in https://bugs.launchpad.net/zun/+bug/1784334","commit_id":"317da4183747b76c977c50955da902e98f4ed29f"}],"zun/common/mount.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"27fe106dbab5a7fd5c67e9c731ac6afc7b74b51e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    mounts \u003d Mounter().read_mounts()"},{"line_number":134,"context_line":"    for m in mounts:"},{"line_number":135,"context_line":"        if mountpoint \u003d\u003d m.mountpoint:"},{"line_number":136,"context_line":"            return True"},{"line_number":137,"context_line":"    return False"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b34766a4","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":38},"updated":"2018-08-02 02:52:16.000000000","message":"@JiWei,\n\nWhat do you think if we do this:\n\n* Check if multipath is using (by reading CONF.volume.use_multipath)\n* If we are using multipath, compare the mountpoint only.\n* If we are not using multipath, compare both device and mountpoint.\n\nDo you think if this is better? or it is not necessary to compare the device in all cases?","commit_id":"e40332c5b05b34adc78f64c095c97ee74f8d5d75"},{"author":{"_account_id":21428,"name":"JiWei","email":"17366060309@163.com","username":"WeiJi"},"change_message_id":"7017b56b0d008c87dacd957f03fe5d851f864e25","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    mounts \u003d Mounter().read_mounts()"},{"line_number":134,"context_line":"    for m in mounts:"},{"line_number":135,"context_line":"        if mountpoint \u003d\u003d m.mountpoint:"},{"line_number":136,"context_line":"            return True"},{"line_number":137,"context_line":"    return False"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e60975dd","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":38},"in_reply_to":"3f79a3b5_cad9ec22","updated":"2018-08-06 12:45:24.000000000","message":"Hi hongbin, this patch has been tested, there is no problem","commit_id":"e40332c5b05b34adc78f64c095c97ee74f8d5d75"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"bc1c8b6f97452cd7699aa02ec2385f61c6f458de","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    mounts \u003d Mounter().read_mounts()"},{"line_number":134,"context_line":"    for m in mounts:"},{"line_number":135,"context_line":"        if mountpoint \u003d\u003d m.mountpoint:"},{"line_number":136,"context_line":"            return True"},{"line_number":137,"context_line":"    return False"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3b48dfca","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":38},"in_reply_to":"3f79a3b5_e60975dd","updated":"2018-08-06 17:01:04.000000000","message":"Great. Thanks for confirming.","commit_id":"e40332c5b05b34adc78f64c095c97ee74f8d5d75"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"4310cbb1b5b153ec18bf58d011497777f085e8d5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    mounts \u003d Mounter().read_mounts()"},{"line_number":134,"context_line":"    for m in mounts:"},{"line_number":135,"context_line":"        if mountpoint \u003d\u003d m.mountpoint:"},{"line_number":136,"context_line":"            return True"},{"line_number":137,"context_line":"    return False"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_cad9ec22","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":38},"in_reply_to":"5f7c97a3_2ca2f098","updated":"2018-08-04 22:46:22.000000000","message":"Sure. Just let me know whenever you would like to have this patch merged.","commit_id":"e40332c5b05b34adc78f64c095c97ee74f8d5d75"},{"author":{"_account_id":21428,"name":"JiWei","email":"17366060309@163.com","username":"WeiJi"},"change_message_id":"49197fcf31cf6fcf4257dab8cf8a56bd1498d9a5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    mounts \u003d Mounter().read_mounts()"},{"line_number":134,"context_line":"    for m in mounts:"},{"line_number":135,"context_line":"        if mountpoint \u003d\u003d m.mountpoint:"},{"line_number":136,"context_line":"            return True"},{"line_number":137,"context_line":"    return False"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_2ca2f098","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":38},"in_reply_to":"5f7c97a3_b34766a4","updated":"2018-08-03 09:43:42.000000000","message":"The mountpoint contains the volume mount information(mount directory). The mount directory is created by the volume id, which is the unique identifier, so I think it is enough to compare the mountpoint. \nI will test it again.","commit_id":"e40332c5b05b34adc78f64c095c97ee74f8d5d75"}],"zun/volume/driver.py":[{"author":{"_account_id":23829,"name":"weikeyou","email":"wei.keyou@zte.com.cn","username":"weikeyou"},"change_message_id":"2530a90c4c5072252ee6aa63a0e69e1f44188e3f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        cinder \u003d cinder_workflow.CinderWorkflow(context)"},{"line_number":121,"context_line":"        cinder.delete_volume(volume)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def _unmount_device(self, volume):"},{"line_number":124,"context_line":"        mountpoint \u003d mount.get_mountpoint(volume.volume_id)"},{"line_number":125,"context_line":"        mount.do_unmount(mountpoint)"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d28349a9","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":23},"updated":"2018-07-30 11:21:31.000000000","message":"When delete the error volume, it may has no connection_info, because the volumemapping table  has not been created. In this case, it is better to keep the judgement。","commit_id":"317da4183747b76c977c50955da902e98f4ed29f"},{"author":{"_account_id":21428,"name":"JiWei","email":"17366060309@163.com","username":"WeiJi"},"change_message_id":"c7941bfdf4afd711f154e549d695fe7423e2f85d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        cinder \u003d cinder_workflow.CinderWorkflow(context)"},{"line_number":121,"context_line":"        cinder.delete_volume(volume)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def _unmount_device(self, volume):"},{"line_number":124,"context_line":"        mountpoint \u003d mount.get_mountpoint(volume.volume_id)"},{"line_number":125,"context_line":"        mount.do_unmount(mountpoint)"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a7fbbb45","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":23},"in_reply_to":"5f7c97a3_d28349a9","updated":"2018-08-01 03:01:44.000000000","message":"Done","commit_id":"317da4183747b76c977c50955da902e98f4ed29f"}]}
