)]}'
{"zun/compute/compute_node_tracker.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"624f3b15f248879ae57c88c4057aab70830bf9aa","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            node.numa_topology \u003d numa_obj"},{"line_number":61,"context_line":"            node.disk_quota_supported \u003d \\"},{"line_number":62,"context_line":"                self.container_driver.node_support_disk_quota()"},{"line_number":63,"context_line":"            node.runtime \u003d self.container_driver.node_runtime_info()"},{"line_number":64,"context_line":"            node.create(context)"},{"line_number":65,"context_line":"            LOG.info(\u0027Node created for :%(host)s\u0027, {\u0027host\u0027: self.host})"},{"line_number":66,"context_line":"        self.container_driver.get_available_resources(node)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_05d6c0f2","line":63,"range":{"start_line":63,"start_character":49,"end_line":63,"end_character":66},"updated":"2018-08-08 02:16:38.000000000","message":"If we assign node.runtime in here, it will assign the runtime at node creation time only. As a result, the runtime won\u0027t be updated after the creation of the node.\n\nWe really want to have the runtime up-to-dated with docker. Therefore, we need to move this down to line #67 or move it inside the method \u0027get_available_resources\u0027. This will make the periodic task update the runtime as long as it is changed at docker side.","commit_id":"07e87c8c26d328475d112ce08198b8d12b352cf2"}],"zun/container/docker/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4e603b3d48acb2650218ba26655454f0453da2b","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    def node_runtime_info(self):"},{"line_number":338,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":339,"context_line":"            info \u003d docker.info()"},{"line_number":340,"context_line":"            if \u0027DefaultRuntime\u0027 in info:"},{"line_number":341,"context_line":"                runtime \u003d str(info[\u0027DefaultRuntime\u0027])"},{"line_number":342,"context_line":"            else:"},{"line_number":343,"context_line":"                runtime \u003d \u0027runc\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_45c11880","line":340,"range":{"start_line":340,"start_character":16,"end_line":340,"end_character":30},"updated":"2018-08-08 02:08:39.000000000","message":"It looks docker.info() will output these two keys:\n\n* DefaultRuntime: This is the default runtime that docker will choose, if users don\u0027t explicitly specify the runtime.\n* Runtimes: This is the list of runtime that docker supports.\n\nFor this BP, which is runtime aware scheduling, what we want to know is \u0027Runtimes\u0027 that each host supports. In particular, we want to schedule a container to a host, as long as the requested runtime is one of the \u0027Runtimes\u0027 that this host supports.\n\nTherefore, I think we should read \u0027Runtimes\u0027 instead of \u0027DefaultRuntime\u0027","commit_id":"07e87c8c26d328475d112ce08198b8d12b352cf2"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4e603b3d48acb2650218ba26655454f0453da2b","unresolved":false,"context_lines":[{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"    def get_host_info(self):"},{"line_number":1050,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":1051,"context_line":"            info \u003d docker.info()"},{"line_number":1052,"context_line":"            total \u003d info[\u0027Containers\u0027]"},{"line_number":1053,"context_line":"            paused \u003d info[\u0027ContainersPaused\u0027]"},{"line_number":1054,"context_line":"            running \u003d info[\u0027ContainersRunning\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_05fec0ad","line":1051,"range":{"start_line":1051,"start_character":26,"end_line":1051,"end_character":30},"updated":"2018-08-08 02:08:39.000000000","message":"We can retrieve the runtime info in this method. Then, the method \u0027node_runtime_info\u0027 can be removed?","commit_id":"07e87c8c26d328475d112ce08198b8d12b352cf2"}],"zun/db/sqlalchemy/alembic/versions/bc56b9932dd9_add_runtime_to_compute_node.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f4e603b3d48acb2650218ba26655454f0453da2b","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027compute_node\u0027,"},{"line_number":34,"context_line":"                  sa.Column(\u0027runtime\u0027, sa.String(length\u003d32),"},{"line_number":35,"context_line":"                            nullable\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_a58a6c18","line":34,"range":{"start_line":34,"start_character":29,"end_line":34,"end_character":36},"updated":"2018-08-08 02:08:39.000000000","message":"I think we need to change the data model. This patch assumes each compute_node supports only one runtime. However, in reality, a compute node can support more than one runtimes. For example, it is possible for a docker daemon to support both \u0027runc\u0027 and \u0027kata\u0027.\n\nI would suggest to change this column from string to list, and rename this fields as \u0027runtimes\u0027 (plural). Does it make sense?","commit_id":"07e87c8c26d328475d112ce08198b8d12b352cf2"}]}
