)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ee13680b2bfd51ff756b71dfad30d0e13af52991","unresolved":false,"context_lines":[{"line_number":682,"context_line":"            stop \u003d strutils.bool_from_string(stop, strict\u003dTrue)"},{"line_number":683,"context_line":"        except ValueError:"},{"line_number":684,"context_line":"            bools \u003d \u0027, \u0027.join(strutils.TRUE_STRINGS + strutils.FALSE_STRINGS)"},{"line_number":685,"context_line":"            raise exception.InvalidValue(_(\u0027Valid stop values are: %s\u0027)"},{"line_number":686,"context_line":"                                         % bools)"},{"line_number":687,"context_line":"        compute_api \u003d pecan.request.compute_api"},{"line_number":688,"context_line":"        if not force and not stop:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e441b163","line":685,"range":{"start_line":685,"start_character":50,"end_line":685,"end_character":54},"updated":"2018-08-01 02:07:14.000000000","message":"nit: need to add \u0027force\u0027 into here.","commit_id":"5bedc6eef76b4f66ba504a1c352a6479dafcb3d4"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"2a96b6ad43318053455c4cd4a6f511f1329244e7","unresolved":false,"context_lines":[{"line_number":682,"context_line":"            stop \u003d strutils.bool_from_string(stop, strict\u003dTrue)"},{"line_number":683,"context_line":"        except ValueError:"},{"line_number":684,"context_line":"            bools \u003d \u0027, \u0027.join(strutils.TRUE_STRINGS + strutils.FALSE_STRINGS)"},{"line_number":685,"context_line":"            raise exception.InvalidValue(_(\u0027Valid stop values are: %s\u0027)"},{"line_number":686,"context_line":"                                         % bools)"},{"line_number":687,"context_line":"        compute_api \u003d pecan.request.compute_api"},{"line_number":688,"context_line":"        if not force and not stop:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_57657e1b","line":685,"range":{"start_line":685,"start_character":50,"end_line":685,"end_character":54},"in_reply_to":"5f7c97a3_e441b163","updated":"2018-08-03 05:53:09.000000000","message":"Done","commit_id":"5bedc6eef76b4f66ba504a1c352a6479dafcb3d4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ee13680b2bfd51ff756b71dfad30d0e13af52991","unresolved":false,"context_lines":[{"line_number":688,"context_line":"        if not force and not stop:"},{"line_number":689,"context_line":"            utils.validate_container_state(container, \u0027delete\u0027)"},{"line_number":690,"context_line":"        elif force and not stop:"},{"line_number":691,"context_line":"            api_utils.version_check(\u0027force\u0027, \u00271.7\u0027)"},{"line_number":692,"context_line":"            policy.enforce(context, \"container:delete_force\","},{"line_number":693,"context_line":"                           action\u003d\"container:delete_force\")"},{"line_number":694,"context_line":"            utils.validate_container_state(container, \u0027delete_force\u0027)"},{"line_number":695,"context_line":"        elif stop:"},{"line_number":696,"context_line":"            api_utils.version_check(\u0027stop\u0027, \u00271.12\u0027)"},{"line_number":697,"context_line":"            check_policy_on_container(container.as_dict(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_07fcef09","line":694,"range":{"start_line":691,"start_character":0,"end_line":694,"end_character":69},"updated":"2018-08-01 02:07:14.000000000","message":"I think it is still better to go through this check for consistency of API behavior. We want to let these checks give out the error response even regardless of container.host is none or not. I think this will make the API behavior predictable and more friendly to API users.","commit_id":"5bedc6eef76b4f66ba504a1c352a6479dafcb3d4"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"2a96b6ad43318053455c4cd4a6f511f1329244e7","unresolved":false,"context_lines":[{"line_number":688,"context_line":"        if not force and not stop:"},{"line_number":689,"context_line":"            utils.validate_container_state(container, \u0027delete\u0027)"},{"line_number":690,"context_line":"        elif force and not stop:"},{"line_number":691,"context_line":"            api_utils.version_check(\u0027force\u0027, \u00271.7\u0027)"},{"line_number":692,"context_line":"            policy.enforce(context, \"container:delete_force\","},{"line_number":693,"context_line":"                           action\u003d\"container:delete_force\")"},{"line_number":694,"context_line":"            utils.validate_container_state(container, \u0027delete_force\u0027)"},{"line_number":695,"context_line":"        elif stop:"},{"line_number":696,"context_line":"            api_utils.version_check(\u0027stop\u0027, \u00271.12\u0027)"},{"line_number":697,"context_line":"            check_policy_on_container(container.as_dict(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_573edee3","line":694,"range":{"start_line":691,"start_character":0,"end_line":694,"end_character":69},"in_reply_to":"5f7c97a3_07fcef09","updated":"2018-08-03 05:53:09.000000000","message":"i agree with you and keep code unchanged","commit_id":"5bedc6eef76b4f66ba504a1c352a6479dafcb3d4"}]}