)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab8e8a742b633d5a9288dd3fc4eefb952a9ab261","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support health check for Docker containers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The docker has supported healthcheck. It is useful for application"},{"line_number":10,"context_line":"container."},{"line_number":11,"context_line":"Zun may integration these options."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_c707d7c7","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":36},"updated":"2018-08-01 02:44:22.000000000","message":"We need to document the new \u0027healthcheck\u0027 parameter in our API reference: https://raw.githubusercontent.com/openstack/zun/master/api-ref/source/containers.inc\n\nCould you help to update it. Feel free to do it in a separated patch if you feel like.","commit_id":"1f9591c41bae19b025d999881d48489bb8df9c93"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab8e8a742b633d5a9288dd3fc4eefb952a9ab261","unresolved":false,"context_lines":[{"line_number":10,"context_line":"container."},{"line_number":11,"context_line":"Zun may integration these options."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  --health-cmd Command to run to check health"},{"line_number":14,"context_line":"  --health-interval Time between running the check"},{"line_number":15,"context_line":"  --health-retries Consecutive failures needed to report unhealthy"},{"line_number":16,"context_line":"  --health-timeout Maximum time to allow one check to run"},{"line_number":17,"context_line":"  In zun, the four parameter are cmd, interval, retries, timeout."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  Partial-Implements: blueprint support-healthycheck"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_a7f09bdb","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":65},"updated":"2018-08-01 02:44:22.000000000","message":"I assume you will have a follow-up patch to implement this in python-zunclient ?","commit_id":"1f9591c41bae19b025d999881d48489bb8df9c93"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab8e8a742b633d5a9288dd3fc4eefb952a9ab261","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  --health-timeout Maximum time to allow one check to run"},{"line_number":17,"context_line":"  In zun, the four parameter are cmd, interval, retries, timeout."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  Partial-Implements: blueprint support-healthycheck"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I1f4f6a5536a33ecb9ac9c032b119a9349e3616ee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_47fbc7bd","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":2},"updated":"2018-08-01 02:44:22.000000000","message":"nit: remove spaces","commit_id":"1f9591c41bae19b025d999881d48489bb8df9c93"}],"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab8e8a742b633d5a9288dd3fc4eefb952a9ab261","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        pci_req \u003d self._create_pci_requests_for_sriov_ports(context,"},{"line_number":356,"context_line":"                                                            requested_networks)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        healthcheck \u003d container_dict.pop(\u0027healthcheck\u0027, {})"},{"line_number":359,"context_line":"        if healthcheck:"},{"line_number":360,"context_line":"            api_utils.version_check(\u0027healthcheck\u0027, \u00271.24\u0027)"},{"line_number":361,"context_line":"            healthcheck[\u0027test\u0027] \u003d healthcheck.pop(\u0027cmd\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c7aef79f","line":358,"range":{"start_line":358,"start_character":8,"end_line":358,"end_character":19},"updated":"2018-08-01 02:44:22.000000000","message":"We requires a unit test case to cover this new parameter in here: https://github.com/openstack/zun/blob/master/zun/tests/unit/api/controllers/v1/test_containers.py","commit_id":"1f9591c41bae19b025d999881d48489bb8df9c93"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab8e8a742b633d5a9288dd3fc4eefb952a9ab261","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        healthcheck \u003d container_dict.pop(\u0027healthcheck\u0027, {})"},{"line_number":359,"context_line":"        if healthcheck:"},{"line_number":360,"context_line":"            api_utils.version_check(\u0027healthcheck\u0027, \u00271.24\u0027)"},{"line_number":361,"context_line":"            healthcheck[\u0027test\u0027] \u003d healthcheck.pop(\u0027cmd\u0027, \u0027\u0027)"},{"line_number":362,"context_line":"            container_dict[\u0027healthcheck\u0027] \u003d healthcheck"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a7de5b39","line":360,"range":{"start_line":360,"start_character":52,"end_line":360,"end_character":56},"updated":"2018-08-01 02:44:22.000000000","message":"According to the guideline (https://docs.openstack.org/zun/latest/contributor/api-microversion.html#other-necessary-changes), we needs to update the following files for this API version bump:\n\n* zun/api/controllers/versions.py\n* zun/api/rest_api_version_history.rst\n* zun/tests/unit/api/controllers/test_root.py\n* zun/tests/unit/api/base.py","commit_id":"1f9591c41bae19b025d999881d48489bb8df9c93"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"15527c3d094af566cd4d484b7682d8c98c898055","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        healthcheck \u003d container_dict.pop(\u0027healthcheck\u0027, {})"},{"line_number":359,"context_line":"        if healthcheck:"},{"line_number":360,"context_line":"            api_utils.version_check(\u0027healthcheck\u0027, \u00271.24\u0027)"},{"line_number":361,"context_line":"            healthcheck[\u0027test\u0027] \u003d healthcheck.pop(\u0027cmd\u0027, \u0027\u0027)"},{"line_number":362,"context_line":"            container_dict[\u0027healthcheck\u0027] \u003d healthcheck"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_0f21364e","line":360,"range":{"start_line":360,"start_character":54,"end_line":360,"end_character":56},"updated":"2018-08-04 17:37:07.000000000","message":"According to https://review.openstack.org/#/c/587337/5/zun/api/controllers/versions.py , this should be 1.21","commit_id":"69fd71730a9382aa99160ac037ad15c435ca7664"}],"zun/api/controllers/v1/schemas/parameter_types.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab8e8a742b633d5a9288dd3fc4eefb952a9ab261","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                \u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]"},{"line_number":191,"context_line":"            },"},{"line_number":192,"context_line":"            \u0027retries\u0027: {"},{"line_number":193,"context_line":"                \u0027type\u0027: [\u0027string\u0027, \u0027integer\u0027, \u0027null\u0027]"},{"line_number":194,"context_line":"            },"},{"line_number":195,"context_line":"            \u0027timeout\u0027: {"},{"line_number":196,"context_line":"                \u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a78c1b39","line":193,"range":{"start_line":193,"start_character":26,"end_line":193,"end_character":32},"updated":"2018-08-01 02:44:22.000000000","message":"Do we have to handle string?","commit_id":"1f9591c41bae19b025d999881d48489bb8df9c93"}],"zun/container/docker/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab8e8a742b633d5a9288dd3fc4eefb952a9ab261","unresolved":false,"context_lines":[{"line_number":305,"context_line":"            if container.healthcheck:"},{"line_number":306,"context_line":"                healthcheck \u003d {}"},{"line_number":307,"context_line":"                healthcheck[\u0027test\u0027] \u003d container.healthcheck.get(\u0027test\u0027, \u0027\u0027)"},{"line_number":308,"context_line":"                interval \u003d container.healthcheck.get(\u0027interval\u0027, \u00270\u0027)"},{"line_number":309,"context_line":"                healthcheck[\u0027interval\u0027] \u003d interval * 10 ** 9"},{"line_number":310,"context_line":"                healthcheck[\u0027retries\u0027] \u003d int(container.healthcheck."},{"line_number":311,"context_line":"                                             get(\u0027retries\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_07b5cfcf","line":308,"range":{"start_line":308,"start_character":65,"end_line":308,"end_character":68},"updated":"2018-08-01 02:44:22.000000000","message":"It seems this should be an integer instead of string?","commit_id":"1f9591c41bae19b025d999881d48489bb8df9c93"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab8e8a742b633d5a9288dd3fc4eefb952a9ab261","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                healthcheck[\u0027interval\u0027] \u003d interval * 10 ** 9"},{"line_number":310,"context_line":"                healthcheck[\u0027retries\u0027] \u003d int(container.healthcheck."},{"line_number":311,"context_line":"                                             get(\u0027retries\u0027, 0))"},{"line_number":312,"context_line":"                timeout \u003d container.healthcheck.get(\u0027timeout\u0027, \u00270\u0027)"},{"line_number":313,"context_line":"                healthcheck[\u0027timeout\u0027] \u003d timeout * 10 ** 9"},{"line_number":314,"context_line":"                kwargs[\u0027healthcheck\u0027] \u003d healthcheck"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_87c8ff55","line":312,"range":{"start_line":312,"start_character":63,"end_line":312,"end_character":66},"updated":"2018-08-01 02:44:22.000000000","message":"Ditto: this should be an integer?","commit_id":"1f9591c41bae19b025d999881d48489bb8df9c93"}],"zun/tests/unit/db/utils.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab8e8a742b633d5a9288dd3fc4eefb952a9ab261","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \u0027auto_heal\u0027: kwargs.get(\u0027auto_heal\u0027, False),"},{"line_number":103,"context_line":"        \u0027capsule_id\u0027: kwargs.get(\u0027capsule_id\u0027, 42),"},{"line_number":104,"context_line":"        \u0027started_at\u0027: kwargs.get(\u0027started_at\u0027),"},{"line_number":105,"context_line":"        \u0027healthcheck\u0027: kwargs.get(\u0027healthcheck\u0027, {}),"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_07daaf1b","line":105,"range":{"start_line":105,"start_character":49,"end_line":105,"end_character":51},"updated":"2018-08-01 02:44:22.000000000","message":"Could we populate it with command, timeout, retries, etc.","commit_id":"1f9591c41bae19b025d999881d48489bb8df9c93"}]}