)]}'
{"zun/api/controllers/v1/views/containers_view.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ecca527a24395f8bf0c640b69c329808912febe1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \u0027privileged\u0027,"},{"line_number":50,"context_line":"    \u0027healthcheck\u0027,"},{"line_number":51,"context_line":"    \u0027cpu_policy\u0027,"},{"line_number":52,"context_line":"    \u0027cpuset_cpus\u0027,"},{"line_number":53,"context_line":"    \u0027cpuset_mems\u0027,"},{"line_number":54,"context_line":")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6d0f1d2e","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":18},"updated":"2018-09-04 04:56:16.000000000","message":"I am not sure if these two fields should be included in the container view. Including these two fields mean exposing them to the end-users, and I am not sure if end-users want to see these fields, which are actually server-internal information.","commit_id":"38be8fe311d235cf730612e8a57f012e5ecdde4d"}],"zun/conf/scheduler.py":[{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"687098e5d267e51d8b92a252828954fb016ae0da","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    \"ComputeFilter\","},{"line_number":70,"context_line":"                    \"DiskFilter\","},{"line_number":71,"context_line":"                    \"RuntimeFilter\","},{"line_number":72,"context_line":"                    \"CUP_CPUSETFilter\","},{"line_number":73,"context_line":"                    ],"},{"line_number":74,"context_line":"                help\u003d\"\"\""},{"line_number":75,"context_line":"Filters that the scheduler will use."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b9f33309","line":72,"range":{"start_line":72,"start_character":21,"end_line":72,"end_character":37},"updated":"2018-09-04 09:43:51.000000000","message":"CPUSETFilter","commit_id":"38be8fe311d235cf730612e8a57f012e5ecdde4d"}],"zun/container/os_capability/linux/os_capability_linux.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ecca527a24395f8bf0c640b69c329808912febe1","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def get_mem_numa_info(self):"},{"line_number":57,"context_line":"        try:"},{"line_number":58,"context_line":"            output \u003d utils.execute(\u0027numactl\u0027, \u0027-H\u0027)"},{"line_number":59,"context_line":"        except exception.CommandError:"},{"line_number":60,"context_line":"            LOG.info(\"There was a problem while executing numactl -H, Try again without the online column.\")"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2a158b3d","line":58,"range":{"start_line":58,"start_character":36,"end_line":58,"end_character":43},"updated":"2018-09-04 04:56:16.000000000","message":"This introduces a dependency on numactl so make sure to list it in bindep.txt.\n\nFYI. you can find information about bindep in: https://docs.openstack.org/infra/bindep/ , and here is an example of how nova is using it: https://github.com/openstack/nova/blob/master/bindep.txt","commit_id":"38be8fe311d235cf730612e8a57f012e5ecdde4d"}],"zun/db/sqlalchemy/models.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ecca527a24395f8bf0c640b69c329808912febe1","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    image \u003d Column(String(255))"},{"line_number":144,"context_line":"    cpu \u003d Column(Float)"},{"line_number":145,"context_line":"    cpu_policy \u003d Column(String(255))"},{"line_number":146,"context_line":"    cpuset_cpus \u003d Column(String(255))"},{"line_number":147,"context_line":"    cpuset_mems \u003d Column(String(255))"},{"line_number":148,"context_line":"    command \u003d Column(JSONEncodedList)"},{"line_number":149,"context_line":"    memory \u003d Column(String(255))"},{"line_number":150,"context_line":"    status \u003d Column(String(20))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6a0aa326","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":37},"updated":"2018-09-04 04:56:16.000000000","message":"I would suggest to combine these two fields into one. Perhaps call it \"cpuset\" or something else, and use \"JSONEncodedDict\" as its type. By this way, we have flexibility to add/remove fields in the future without changing the DB schema.","commit_id":"38be8fe311d235cf730612e8a57f012e5ecdde4d"}],"zun/objects/container.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ecca527a24395f8bf0c640b69c329808912febe1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \u0027image\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":81,"context_line":"        \u0027cpu\u0027: fields.FloatField(nullable\u003dTrue),"},{"line_number":82,"context_line":"        \u0027cpu_policy\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":83,"context_line":"        \u0027cpuset_cpus\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":84,"context_line":"        \u0027cpuset_mems\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027memory\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":86,"context_line":"        \u0027command\u0027: fields.ListOfStringsField(nullable\u003dTrue),"},{"line_number":87,"context_line":"        \u0027status\u0027: z_fields.ContainerStatusField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2a002b02","line":84,"range":{"start_line":83,"start_character":0,"end_line":84,"end_character":57},"updated":"2018-09-04 04:56:16.000000000","message":"Ditto, I would suggest to combine these two fields into one. In particular, we can define an object, called \"Cpuset\" or something else, then in here reference the object type as:\n\n  \u0027cpuset\u0027: fields.ObjectField(\"Cpuset\"),","commit_id":"38be8fe311d235cf730612e8a57f012e5ecdde4d"}],"zun/scheduler/filters/cup_cpuset_filter.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ecca527a24395f8bf0c640b69c329808912febe1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright (c) 2018 National Engineering Laboratory of electronic"},{"line_number":2,"context_line":"#    commerce and electronic payment"},{"line_number":3,"context_line":"#    All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0ae0cf96","line":1,"updated":"2018-09-04 04:56:16.000000000","message":"The file name is strange. I guess it should be \"cpu_cpuset_filter.py\" ?","commit_id":"38be8fe311d235cf730612e8a57f012e5ecdde4d"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ecca527a24395f8bf0c640b69c329808912febe1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class CUP_CPUSETFilter(filters.BaseHostFilter):"},{"line_number":25,"context_line":"    \"\"\"Filter the host by cpu and memory request of cpuset\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    run_filter_once_per_request \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ca2ad7e5","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":22},"updated":"2018-09-04 04:56:16.000000000","message":"According to the naming style, it should be: CpuSetFilter","commit_id":"38be8fe311d235cf730612e8a57f012e5ecdde4d"}],"zun/tests/unit/db/utils.py":[{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"687098e5d267e51d8b92a252828954fb016ae0da","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                                   \"test\": \"stat /etc/passwd || exit 1\","},{"line_number":109,"context_line":"                                   \"interval\": 3}),"},{"line_number":110,"context_line":"        \u0027exposed_ports\u0027: kwargs.get(\u0027exposed_ports\u0027, {\"80/tcp\": {}}),"},{"line_number":111,"context_line":"        \u0027cpu_policy\u0027: None,"},{"line_number":112,"context_line":"        \u0027cpuset_cpus\u0027: None,"},{"line_number":113,"context_line":"        \u0027cpuset_mems\u0027: None,"},{"line_number":114,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_59dc5f73","line":111,"range":{"start_line":111,"start_character":22,"end_line":111,"end_character":26},"updated":"2018-09-04 09:43:51.000000000","message":"kwargs.get(\u0027cpu_policy\u0027, \u0027dedicated\u0027)","commit_id":"38be8fe311d235cf730612e8a57f012e5ecdde4d"}]}
