)]}'
{"zun/common/utils.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"001e87896feaa6d196340da18404040deabe0a6a","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    def __enter__(self):"},{"line_number":611,"context_line":"        return self"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    def __exit__(self, exc_type, exc_val, exc_tb):"},{"line_number":614,"context_line":"        for uuid in self.container_uuids:"},{"line_number":615,"context_line":"            objects.ContainerAction.action_finish("},{"line_number":616,"context_line":"                self.context, uuid, self.action_name, exc_val\u003dexc_val,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ffb9cba7_ec1b5f18","line":613,"range":{"start_line":613,"start_character":23,"end_line":613,"end_character":31},"updated":"2019-04-24 10:12:26.000000000","message":"This parameter is not used anywhere. Is it meant to be like this?","commit_id":"d5f7ca7d0a1632dbff1c4bd718dee1dba7b91fc4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"1ee98ff4a4e3d49542c5b1c3780a9b09bd0698ea","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    def __enter__(self):"},{"line_number":611,"context_line":"        return self"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    def __exit__(self, exc_type, exc_val, exc_tb):"},{"line_number":614,"context_line":"        for uuid in self.container_uuids:"},{"line_number":615,"context_line":"            objects.ContainerAction.action_finish("},{"line_number":616,"context_line":"                self.context, uuid, self.action_name, exc_val\u003dexc_val,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ffb9cba7_5d7326b2","line":613,"range":{"start_line":613,"start_character":23,"end_line":613,"end_character":31},"in_reply_to":"ffb9cba7_ec1b5f18","updated":"2019-04-25 02:38:07.000000000","message":"Yes, the signature of this method must be in this form: https://docs.python.org/3/library/contextlib.html#using-a-context-manager-as-a-function-decorator","commit_id":"d5f7ca7d0a1632dbff1c4bd718dee1dba7b91fc4"}],"zun/compute/manager.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"001e87896feaa6d196340da18404040deabe0a6a","unresolved":false,"context_lines":[{"line_number":507,"context_line":"    def add_security_group(self, context, container, security_group):"},{"line_number":508,"context_line":"        @utils.synchronized(container.uuid)"},{"line_number":509,"context_line":"        def do_add_security_group():"},{"line_number":510,"context_line":"            with utils.FinishAction(context,"},{"line_number":511,"context_line":"                                    container_actions.ADD_SECURITY_GROUP,"},{"line_number":512,"context_line":"                                    container.uuid):"},{"line_number":513,"context_line":"                self._add_security_group(context, container, security_group)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ffb9cba7_6c99af6c","line":510,"updated":"2019-04-24 10:12:26.000000000","message":"Hongbin, I think its better to add this in the calling methods such as _add_security_group, _do_container_*.\nSo that we don\u0027t have to change at multiple places. What do you think?","commit_id":"d5f7ca7d0a1632dbff1c4bd718dee1dba7b91fc4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"20ed4af242959332c4415216524963ea276c009e","unresolved":false,"context_lines":[{"line_number":507,"context_line":"    def add_security_group(self, context, container, security_group):"},{"line_number":508,"context_line":"        @utils.synchronized(container.uuid)"},{"line_number":509,"context_line":"        def do_add_security_group():"},{"line_number":510,"context_line":"            with utils.FinishAction(context,"},{"line_number":511,"context_line":"                                    container_actions.ADD_SECURITY_GROUP,"},{"line_number":512,"context_line":"                                    container.uuid):"},{"line_number":513,"context_line":"                self._add_security_group(context, container, security_group)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ffb9cba7_43eebcb4","line":510,"in_reply_to":"ffb9cba7_6c99af6c","updated":"2019-04-27 02:53:13.000000000","message":"Done. I move this to \u0027wrap_container_event\u0027.","commit_id":"d5f7ca7d0a1632dbff1c4bd718dee1dba7b91fc4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"1ee98ff4a4e3d49542c5b1c3780a9b09bd0698ea","unresolved":false,"context_lines":[{"line_number":507,"context_line":"    def add_security_group(self, context, container, security_group):"},{"line_number":508,"context_line":"        @utils.synchronized(container.uuid)"},{"line_number":509,"context_line":"        def do_add_security_group():"},{"line_number":510,"context_line":"            with utils.FinishAction(context,"},{"line_number":511,"context_line":"                                    container_actions.ADD_SECURITY_GROUP,"},{"line_number":512,"context_line":"                                    container.uuid):"},{"line_number":513,"context_line":"                self._add_security_group(context, container, security_group)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ffb9cba7_dd5e3611","line":510,"in_reply_to":"ffb9cba7_6c99af6c","updated":"2019-04-25 02:38:07.000000000","message":"I will add this in calling methods.","commit_id":"d5f7ca7d0a1632dbff1c4bd718dee1dba7b91fc4"}]}