)]}'
{"zun/db/sqlalchemy/alembic/versions/74c97dca93d0_add_missing_index_and_foreign_key.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"4a9e674bb86a2207f4a652964c079f43878478b8","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    with op.batch_alter_table(\u0027quota_usages\u0027, schema\u003dNone) as batch_op:"},{"line_number":37,"context_line":"        batch_op.create_index("},{"line_number":38,"context_line":"            batch_op.f(\u0027ix_quota_usages_resource\u0027), [\u0027resource\u0027], unique\u003dFalse)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # ### end Alembic commands ###"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_c5dd5315","line":38,"range":{"start_line":38,"start_character":54,"end_line":38,"end_character":62},"updated":"2020-03-28 04:10:50.000000000","message":"I don\u0027t think resource should be index, because adding this index doesn\u0027t seem have any benefit. Therefore, the mistake is on the db model side, in which the index should be removed from \u0027resource\u0027 field in QuotaUsage class. What do you think?","commit_id":"e4a1ad0ffb4530b981d5ee6d1bcee98c8b95cdcd"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"8332a22ef948131c8e65af47a7803e6d1bfd3014","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    with op.batch_alter_table(\u0027quota_usages\u0027, schema\u003dNone) as batch_op:"},{"line_number":37,"context_line":"        batch_op.create_index("},{"line_number":38,"context_line":"            batch_op.f(\u0027ix_quota_usages_resource\u0027), [\u0027resource\u0027], unique\u003dFalse)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # ### end Alembic commands ###"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_20d86d7d","line":38,"range":{"start_line":38,"start_character":54,"end_line":38,"end_character":62},"in_reply_to":"df33271e_c5dd5315","updated":"2020-03-28 07:02:30.000000000","message":"sure, will fix on model side.","commit_id":"e4a1ad0ffb4530b981d5ee6d1bcee98c8b95cdcd"}]}
