)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"77062892a05eb2d0c1dda2e9ea4b32cde8b67a82","unresolved":false,"context_lines":[{"line_number":10,"context_line":"\"identity_provider\" fields."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7d0ef23d4551cbf709d3ddfca4e1edb7e4cd0557"},{"line_number":13,"context_line":"Closes-Bug: bug/1290600"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F9g9s%3D","line":13,"updated":"2014-04-04 00:40:59.000000000","message":"this should be \n\n Closes-Bug: #1290600","commit_id":"4be002c7b34fbc5e51197dfcbfe7be2f3bd06680"}],"openstack-identity-api/v3/src/markdown/identity-api-v3-os-federation-ext.md":[{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"07393059f51ba470d546324db23e483b83a66f7e","unresolved":false,"context_lines":[{"line_number":761,"context_line":"                    \"saml2\""},{"line_number":762,"context_line":"                ],"},{"line_number":763,"context_line":"                \"saml2\": {"},{"line_number":764,"context_line":"                    \"identity_provider\": \"ACME\","},{"line_number":765,"context_line":"                    \"protocol\": \"SAML\""},{"line_number":766,"context_line":"                }"},{"line_number":767,"context_line":"            }"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"AAAAVn%2F%2B8WM%3D","line":764,"updated":"2014-03-11 05:51:00.000000000","message":"Why is this wrong?\nThe federation api uses \"id\" to identitfy the provider.\n\n\"id\" is overloaded and in general if we use \"id\" we expect some number. If we really want to fix this, we need to change the federation api to use \"name\" instead of id and use \"name\" here to refer it.\n\nHow do we even know that \"identity_provider\" value should match the \"id\" attribute in federation api?","commit_id":"f8fdf9b8fea19eb8f5f9c02e35bab3253b4c38b7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"422d55c6647970f1e175316c16373c1a6a71719d","unresolved":false,"context_lines":[{"line_number":761,"context_line":"                    \"saml2\""},{"line_number":762,"context_line":"                ],"},{"line_number":763,"context_line":"                \"saml2\": {"},{"line_number":764,"context_line":"                    \"identity_provider\": \"ACME\","},{"line_number":765,"context_line":"                    \"protocol\": \"SAML\""},{"line_number":766,"context_line":"                }"},{"line_number":767,"context_line":"            }"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"AAAAWH%2F%2Ft9k%3D","line":764,"in_reply_to":"AAAAVn%2F%2B8WM%3D","updated":"2014-03-14 08:59:25.000000000","message":"@Haneef:\nMatthieu is right, doc is outdated.\nBesides, in this particular case the \u0027id\u0027 is just a human readable name for identity_provider as well as protocol.","commit_id":"f8fdf9b8fea19eb8f5f9c02e35bab3253b4c38b7"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"f26593cb2372e92e7fb4a5eb7ae021cf5d549e6a","unresolved":false,"context_lines":[{"line_number":761,"context_line":"                    \"saml2\""},{"line_number":762,"context_line":"                ],"},{"line_number":763,"context_line":"                \"saml2\": {"},{"line_number":764,"context_line":"                    \"identity_provider\": \"ACME\","},{"line_number":765,"context_line":"                    \"protocol\": \"SAML\""},{"line_number":766,"context_line":"                }"},{"line_number":767,"context_line":"            }"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"AAAAVn%2F%2B6z4%3D","line":764,"in_reply_to":"AAAAVn%2F%2B8WM%3D","updated":"2014-03-11 09:50:57.000000000","message":"It is not \"wrong\", but it is different from the way it is implemented. See https://github.com/openstack/keystone/blob/master/keystone/tests/test_v3_federation.py#L714 for example.\nSo it comes up to this: either the API is changed to conform to what is done in the code, or the code is fixed to use the explicit \"id\" key. While the latter is probably better, the former is quicker, which is probably best if this feature is to be included in Icehouse.\nThoughts ?","commit_id":"f8fdf9b8fea19eb8f5f9c02e35bab3253b4c38b7"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"07393059f51ba470d546324db23e483b83a66f7e","unresolved":false,"context_lines":[{"line_number":784,"context_line":"                \"id\": \"username%40example.com\","},{"line_number":785,"context_line":"                \"name\": \"username@example.com\","},{"line_number":786,"context_line":"                \"OS-FEDERATION\": {"},{"line_number":787,"context_line":"                    \"identity_provider\": \"ACME\","},{"line_number":788,"context_line":"                    \"protocol\": \"SAML\""},{"line_number":789,"context_line":"                },"},{"line_number":790,"context_line":"                \"OS-FEDERATION:groups\": ["}],"source_content_type":"text/x-markdown","patch_set":1,"id":"AAAAVn%2F%2B8WE%3D","line":787,"updated":"2014-03-11 05:51:00.000000000","message":"Same as above.","commit_id":"f8fdf9b8fea19eb8f5f9c02e35bab3253b4c38b7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"422d55c6647970f1e175316c16373c1a6a71719d","unresolved":false,"context_lines":[{"line_number":784,"context_line":"                \"id\": \"username%40example.com\","},{"line_number":785,"context_line":"                \"name\": \"username@example.com\","},{"line_number":786,"context_line":"                \"OS-FEDERATION\": {"},{"line_number":787,"context_line":"                    \"identity_provider\": \"ACME\","},{"line_number":788,"context_line":"                    \"protocol\": \"SAML\""},{"line_number":789,"context_line":"                },"},{"line_number":790,"context_line":"                \"OS-FEDERATION:groups\": ["}],"source_content_type":"text/x-markdown","patch_set":1,"id":"AAAAWH%2F%2Ft%2B8%3D","line":787,"in_reply_to":"AAAAVn%2F%2B8WE%3D","updated":"2014-03-14 08:59:25.000000000","message":"In fact, this should not be changed, as a response in a format as depicted in the current doc. So, please revert this change. (This however may be a good point to change this token dictionary format):\n\n(Pdb) p token_data\n{\u0027token\u0027: {\u0027issued_at\u0027: \u00272014-03-14T08:48:03.504179Z\u0027, \u0027extras\u0027: {}, \u0027methods\u0027: [\u0027saml2\u0027], \u0027expires_at\u0027: \u00272014-03-14T09:48:03.504136Z\u0027, \u0027user\u0027: {\u0027OS-FEDERATION\u0027: {\u0027identity_provider\u0027: {\u0027id\u0027: \u0027ORG_IDP\u0027}, \u0027protocol\u0027: {\u0027id\u0027: \u0027saml2\u0027}}, \u0027OS-FEDERATION:groups\u0027: [{\u0027id\u0027: u\u0027f8c4337c4fd243a8b134ea71dd9d0fed\u0027}], \u0027id\u0027: u\u0027tbo\u0027, \u0027name\u0027: u\u0027tbo\u0027}}}","commit_id":"f8fdf9b8fea19eb8f5f9c02e35bab3253b4c38b7"}]}