)]}'
{"ara/server/urls.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"6363a0abefb285ed714d1e3c05b90424b6979b91","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"urlpatterns \u003d [path(\"\", APIRoot.as_view()), path(\"api/v1/\", include(\"ara.api.urls\")), path(\"admin/\", admin.site.urls)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_5647c71e","line":40,"updated":"2019-05-03 23:55:26.000000000","message":"Note that long lines like that are not diff/patch friendly and it increases the chance of rebase/conflict...","commit_id":"da5d5daed322485d8cef2b06cc17fd818c61d3a2"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"1cefdfa0f89a84913816762ef69d49fb49ef4f5a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"urlpatterns \u003d [path(\"\", APIRoot.as_view()), path(\"api/v1/\", include(\"ara.api.urls\")), path(\"admin/\", admin.site.urls)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_570f9ce0","line":40,"in_reply_to":"dfbec78f_5647c71e","updated":"2019-05-07 14:34:52.000000000","message":"\u003e Note that long lines like that are not diff/patch friendly and it\n \u003e increases the chance of rebase/conflict...\n\nApologies for the unwarranted linters fix, Florian\u0027s suggestion about turning off black formatting is appropriate. Since this was my own doing, I\u0027ll restore the previous patchset with Florian\u0027s approach.","commit_id":"da5d5daed322485d8cef2b06cc17fd818c61d3a2"},{"author":{"_account_id":29199,"name":"Florian Apolloner","email":"florian@apolloner.eu","username":"apollo13"},"change_message_id":"b5c01668350fb8daf24816871562afd31426c736","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"urlpatterns \u003d [path(\"\", APIRoot.as_view()), path(\"api/v1/\", include(\"ara.api.urls\")), path(\"admin/\", admin.site.urls)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_d9f4485e","line":40,"in_reply_to":"dfbec78f_5647c71e","updated":"2019-05-04 05:49:08.000000000","message":"This is most likely the doing of black, which keeps this on one line for now.\n\nIt will move to one item per line as soon as it gets longer. It\u0027s suboptimal in this case and especially for readability of URLs I\u0027d suggest:\n\n# fmt: off\nurlpatterns \u003d [\n  entry1,\n  entry2,\n  entry3,\n]\n# fmt: on\n\nand remove the black format comments once the list is long enough it no longer fits on one line.","commit_id":"da5d5daed322485d8cef2b06cc17fd818c61d3a2"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"1400d2f637166cdceef753ce391c724b0d88aa6b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                request.build_absolute_uri(), x),"},{"line_number":35,"context_line":"                ["},{"line_number":36,"context_line":"                    \"api/v1/\","},{"line_number":37,"context_line":"                    \"admin/\""},{"line_number":38,"context_line":"                ]))"},{"line_number":39,"context_line":"        })"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_20d09c1f","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":28},"updated":"2019-05-07 16:44:11.000000000","message":"On a second thought, let\u0027s not include /admin/ here.\n\nThe intent for the /admin/ URL is to allow users to create and manage users when enabling authentication [1].\nIt is not an API endpoint.\n\n[1]: https://ara.readthedocs.io/en/feature-1.0/api-security.html#user-management","commit_id":"867a0ae109d308f634f98167f56eb46a510e38cf"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"5010f1c0b08597d8b848ac4a3513e85425f384ce","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                request.build_absolute_uri(), x),"},{"line_number":35,"context_line":"                ["},{"line_number":36,"context_line":"                    \"api/v1/\","},{"line_number":37,"context_line":"                    \"admin/\""},{"line_number":38,"context_line":"                ]))"},{"line_number":39,"context_line":"        })"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_a2ab261b","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":28},"in_reply_to":"dfbec78f_20d09c1f","updated":"2019-05-08 10:49:18.000000000","message":"Done","commit_id":"867a0ae109d308f634f98167f56eb46a510e38cf"}]}