)]}'
{"ara/plugins/callback/ara_default.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"16b50a44efea783f732e78fd0dbb8435860ab717","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from ansible.parsing.ajson import AnsibleJSONEncoder"},{"line_number":27,"context_line":"from ansible.plugins.callback import CallbackBase"},{"line_number":28,"context_line":"from ansible.vars.clean import module_response_deepcopy, strip_internal_keys"},{"line_number":29,"context_line":"from concurrent.futures import ThreadPoolExecutor, as_completed"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from ara.clients import utils as client_utils"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_62a2b0af","line":29,"updated":"2020-09-01 19:13:37.000000000","message":"linters: F401 \u0027concurrent.futures.as_completed\u0027 imported but unused","commit_id":"3e3de09975904d95727e7feaa06c430fb70addeb"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"a6ad7f7305ba1d760fc73c3c5537a12b2fea037b","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        )"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        # Record the playbook file"},{"line_number":265,"context_line":"        self.threads.submit(self._get_or_create_file(path, content))"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        return self.playbook"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f681702_3e2dad46","line":265,"range":{"start_line":265,"start_character":28,"end_line":265,"end_character":68},"updated":"2020-10-16 08:57:35.000000000","message":"Instead of submitting the result of the function call, the function and its parameters should be submitted.\n\nself.threads.submit(self._get_or_create_file, path, content)","commit_id":"e4394f1d9bf72dffcdfd53e93cf840aa2a07bd3b"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"625a78675e6c5a68cb6f72b08d6ea7137577168f","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        )"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        # Record the playbook file"},{"line_number":265,"context_line":"        self.threads.submit(self._get_or_create_file(path, content))"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        return self.playbook"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f681702_a4c7ec45","line":265,"range":{"start_line":265,"start_character":28,"end_line":265,"end_character":68},"in_reply_to":"5f681702_3e2dad46","updated":"2020-10-16 13:01:21.000000000","message":"Oh wow, you\u0027re right and in hindsight that makes so much sense !\n\nLook at the results:\n\n    \u003e ara playbook list --path benchmark\n    +------+-----------+-----------------------------------------+-------+---------+-------+-----------------------------+-----------------+\n    |   id | status    | path                                    | tasks | results | hosts | started                     | duration        |\n    +------+-----------+-----------------------------------------+-------+---------+-------+-----------------------------+-----------------+\n    | 1176 | completed | ...ara/tests/integration/benchmark.yaml |    52 |    1276 |    26 | 2020-10-16T08:59:13.020078Z | 00:00:26.553335 |\n    | 1157 | completed | ...ara/tests/integration/benchmark.yaml |    52 |    1276 |    26 | 2020-10-14T21:01:38.675407Z | 00:02:10.028298 |\n    +------+-----------+-----------------------------------------+-------+---------+-------+-----------------------------+-----------------+","commit_id":"e4394f1d9bf72dffcdfd53e93cf840aa2a07bd3b"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"f2d35e820029e7e897b6b2022f8daf296442adf4","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        super(CallbackModule, self).__init__()"},{"line_number":177,"context_line":"        self.log \u003d logging.getLogger(\"ara.plugins.callback.default\")"},{"line_number":178,"context_line":"        self.client \u003d None"},{"line_number":179,"context_line":"        self.threads \u003d ThreadPoolExecutor(max_workers\u003d20)"},{"line_number":180,"context_line":"        self.ignored_facts \u003d []"},{"line_number":181,"context_line":"        self.ignored_arguments \u003d []"},{"line_number":182,"context_line":"        self.ignored_files \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f681702_8fcbe9a3","line":179,"range":{"start_line":179,"start_character":54,"end_line":179,"end_character":56},"updated":"2020-10-16 13:57:26.000000000","message":"I think we might want to not hardcode this but testing different values (10 or 50 workers) didn\u0027t seem to do much difference so it\u0027s probably a sane default we can revisit later.","commit_id":"84d04e4e111de50558a455365c374835c15acf17"}]}
