)]}'
{"id":"stackforge%2Fopenstack-cli-powershell~97878","triplet_id":"stackforge%2Fopenstack-cli-powershell~master~Ided462e5050214321e1ead50cf0498707d59128f","project":"stackforge/openstack-cli-powershell","branch":"master","topic":"bp/implement-multiple-vendor-support","hashtags":[],"change_id":"Ided462e5050214321e1ead50cf0498707d59128f","subject":"This change addresses the Code Review from the previous commit. Changes include the following","status":"MERGED","created":"2014-06-04 18:37:00.000000000","updated":"2014-06-12 17:36:21.000000000","submitted":"2014-06-12 17:36:21.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":27,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cf9f2e1e22d50663121c6c41a2e26893b6ad192f","_number":97878,"virtual_id_number":97878,"owner":{"_account_id":9274,"name":"Travis Plummer","email":"travis.plummer@hp.com","username":"Paybackman"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-06-12 17:36:21.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10523,"name":"Wayne Foley","email":"wayne.foley@hp.com","username":"wfoley"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10523,"name":"Wayne Foley","email":"wayne.foley@hp.com","username":"wfoley"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-06-12 17:36:20.000000000","_account_id":10523,"name":"Wayne Foley","email":"wayne.foley@hp.com","username":"wfoley"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10523,"name":"Wayne Foley","email":"wayne.foley@hp.com","username":"wfoley"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-06-12 17:36:20.000000000","_account_id":10523,"name":"Wayne Foley","email":"wayne.foley@hp.com","username":"wfoley"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10523,"name":"Wayne Foley","email":"wayne.foley@hp.com","username":"wfoley"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-06-12 17:36:20.000000000","updated_by":{"_account_id":10523,"name":"Wayne Foley","email":"wayne.foley@hp.com","username":"wfoley"},"reviewer":{"_account_id":10523,"name":"Wayne Foley","email":"wayne.foley@hp.com","username":"wfoley"},"state":"REVIEWER"},{"updated":"2014-06-12 17:36:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"771f8814d7bc8826884cac5ece03899dfd20caa6","author":{"_account_id":9274,"name":"Travis Plummer","email":"travis.plummer@hp.com","username":"Paybackman"},"date":"2014-06-04 18:37:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a6c99aac64126f5a7ade25c0f5404278dd9df08e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-04 18:37:02.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"dbff0feb3a6db34110e1abae1768fd4a135d41d2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-04 18:37:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/78/97878/1/check/noop/0dcb4bd : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1924b816d4f9c9a42ec8a22d2343bc3e44c91470","author":{"_account_id":10523,"name":"Wayne Foley","email":"wayne.foley@hp.com","username":"wfoley"},"date":"2014-06-05 17:54:50.000000000","message":"Patch Set 1: Code-Review-1\n\n(27 comments)\n\nOverall I think this is good stuff. I few comments that should be resolved first before merging up. \n\nOverall, you may also want to consider adding more/any unit tests... while Powershell cmdlets themselves can be a pain to test, there are a lot of pure C# classes/methods that could be tested in isolation.","accounts_in_message":[],"_revision_number":1},{"id":"4700092feedbae8fab8b7be857a034e45c72c003","author":{"_account_id":9274,"name":"Travis Plummer","email":"travis.plummer@hp.com","username":"Paybackman"},"date":"2014-06-11 19:58:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ca207cfa1316f43a103a0b91359fb5623000182b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-11 19:58:26.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"7ba3ddc30093986ecfaaed3a20d518b2ebdf173b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-11 19:58:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/78/97878/2/check/noop/117aecc : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ff070ece704df7a9d197a0b5202fc09cbfe02ef9","author":{"_account_id":10523,"name":"Wayne Foley","email":"wayne.foley@hp.com","username":"wfoley"},"date":"2014-06-12 17:36:20.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"d7d00f0c20dcbd9aa478ebfb4a0349eb70380ae3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-12 17:36:21.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/78/97878/2/gate/noop/306ca96 : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"02f6b16db2cc8fb64378be49f454d36286f28916","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-12 17:36:21.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"65c6747f900a7d03012346616893f0cfc44f0e0a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-12 17:36:21.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"53dc8b3bf92315a41b77bb78cfe01e9385456b40","revisions":{"98e49965e73763d6e3faa028b3757ef13f240641":{"kind":"REWORK","_number":1,"created":"2014-06-04 18:37:00.000000000","uploader":{"_account_id":9274,"name":"Travis Plummer","email":"travis.plummer@hp.com","username":"Paybackman"},"ref":"refs/changes/78/97878/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-cli-powershell","ref":"refs/changes/78/97878/1","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-cli-powershell refs/changes/78/97878/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-cli-powershell refs/changes/78/97878/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-cli-powershell refs/changes/78/97878/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-cli-powershell refs/changes/78/97878/1"}}},"commit":{"parents":[{"commit":"3a9dd4338078d63cd2b3701f36ca12c3bed49178","subject":"Minor changes... About to port from other Repo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-cli-powershell/commit/3a9dd4338078d63cd2b3701f36ca12c3bed49178"}]}],"author":{"name":"paybackman","email":"travis.plummer@hp.com","date":"2014-06-04 18:31:52.000000000","tz":-300},"committer":{"name":"paybackman","email":"travis.plummer@hp.com","date":"2014-06-04 18:36:55.000000000","tz":-300},"subject":"This change implements 2 separate use cases for Multi-Vendor support.","message":"This change implements 2 separate use cases for Multi-Vendor support.\n\na. Initial Bootstrapping\nb. Switch Providers\n\nChange-Id: Ided462e5050214321e1ead50cf0498707d59128f\nPartially-implements: blueprint implement-multiple-vendor-support\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-cli-powershell/commit/98e49965e73763d6e3faa028b3757ef13f240641"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-cli-powershell/commit/98e49965e73763d6e3faa028b3757ef13f240641"}]},"branch":"refs/heads/master"},"53dc8b3bf92315a41b77bb78cfe01e9385456b40":{"kind":"REWORK","_number":2,"created":"2014-06-11 19:58:25.000000000","uploader":{"_account_id":9274,"name":"Travis Plummer","email":"travis.plummer@hp.com","username":"Paybackman"},"ref":"refs/changes/78/97878/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-cli-powershell","ref":"refs/changes/78/97878/2","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-cli-powershell refs/changes/78/97878/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-cli-powershell refs/changes/78/97878/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-cli-powershell refs/changes/78/97878/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-cli-powershell refs/changes/78/97878/2"}}},"commit":{"parents":[{"commit":"3a9dd4338078d63cd2b3701f36ca12c3bed49178","subject":"Minor changes... About to port from other Repo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-cli-powershell/commit/3a9dd4338078d63cd2b3701f36ca12c3bed49178"}]}],"author":{"name":"paybackman","email":"travis.plummer@hp.com","date":"2014-06-04 18:31:52.000000000","tz":-300},"committer":{"name":"paybackman","email":"travis.plummer@hp.com","date":"2014-06-11 19:53:06.000000000","tz":-300},"subject":"This change addresses the Code Review from the previous commit. Changes include the following","message":"This change addresses the Code Review from the previous commit. Changes include the following\n\n Stronger Validation for Openstack.config.\n Better handling of detecting and raising NullReferenceExceptions\n Removal of dead code in a few places\n Added ability for each ServiceProvider to supply a ServiceMap which translates his name for a CoreService to something we can work with.\n Optimized code for dealing with Runspaces.\n\nThis change implements 2 separate use cases for Multi-Vendor support.\n\na. Initial Bootstrapping\nb. Switch Providers\n\nChange-Id: Ided462e5050214321e1ead50cf0498707d59128f\nPartially-implements: blueprint implement-multiple-vendor-support\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-cli-powershell/commit/53dc8b3bf92315a41b77bb78cfe01e9385456b40"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-cli-powershell/commit/53dc8b3bf92315a41b77bb78cfe01e9385456b40"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}