)]}'
{"id":"stackforge%2Fopenstack-sdk-php~93089","triplet_id":"stackforge%2Fopenstack-sdk-php~master~Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e","project":"stackforge/openstack-sdk-php","branch":"master","topic":"transport-refactoring","hashtags":[],"change_id":"Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e","subject":"Refactors ClientInterface and Guzzle adapter.","status":"MERGED","created":"2014-05-09 17:22:44.000000000","updated":"2014-06-07 17:15:37.000000000","submitted":"2014-06-07 17:15:37.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":91,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"80eb155e453dc10f531fcf3211a94dfe9cec34c7","_number":93089,"virtual_id_number":93089,"owner":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},{"value":0,"date":"2014-06-07 00:34:45.000000000","_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},{"value":2,"date":"2014-06-07 17:15:37.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"value":0,"date":"2014-06-07 17:04:03.000000000","_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},"all":[{"value":0,"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},{"value":2,"date":"2014-06-07 17:15:34.000000000","_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-06-05 09:18:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"value":0,"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},"all":[{"value":0,"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},{"value":1,"date":"2014-06-07 17:15:34.000000000","_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"value":0,"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-05-30 15:40:23.000000000","updated_by":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"reviewer":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"state":"REVIEWER"},{"updated":"2014-06-05 09:18:12.000000000","updated_by":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"reviewer":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"state":"REVIEWER"},{"updated":"2014-06-07 17:15:34.000000000","updated_by":{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},"reviewer":{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},"state":"REVIEWER"},{"updated":"2014-06-07 17:15:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1fb99b468f400e4c6b27d9788c152c3b2313d4c3","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-05-09 17:22:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"55e5513b9bd901b44541fbe0f6ee6186f0fcaac6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-09 17:22:47.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"afb0a9d73b6895d40e6167a2af2b4a96b65893b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-09 17:22:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/1/check/noop/921bde7 : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"82b7176630a7a9091867bee5e12bfa4d71299897","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-13 03:42:57.000000000","message":"Patch Set 1: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"72508a3586824276128be59d5c1916ee1079cab8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-13 03:42:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/1/check/noop/cf09c47 : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cdff1cdd05f524a398e39fcc31aec482c2cd1e4f","author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"date":"2014-05-13 03:42:57.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nIn addition to the inline questions, I\u0027m left wondering why add the complexity? The interface in the client should be the minimal we need. It\u0027s not a general http interface. It\u0027s a specific interface to the needs of the SDK and not further. Why add the extra complexity and how does it fit into the broader scheme?","accounts_in_message":[],"_revision_number":1},{"id":"866e714f4d874b3acfcfb855343f6d293e62a4a8","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-05-13 11:06:40.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nRegarding complexity: I completely agree - we need to make things as simple as possible. But that\u0027s exactly what I\u0027m trying to do. I\u0027m attempting to separate concerns and make sure things have a single responsibility - in other words, I want to remove all possible ambiguity for newcomers with this SDK.\n\nThe interface is not a general one - it has a very specific purpose. It is supposed to represent a basic TRANSPORT client interface that all other HTTP clients can use. For that reason I wanted our public API to be consistent with other HTTP libraries and as efficient as possible.\n\nThe affiliated work around this change makes internal processes more efficient by clarifying concerns and extracting functionality to dedicated areas - thereby removing unnecessary conflations.","accounts_in_message":[],"_revision_number":1},{"id":"1cbf102478bfebfd14fea6ed3767efaaab136588","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-05-13 11:19:32.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c902a386e126b61431befd9077925289a7f51412","author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"date":"2014-05-13 15:28:41.000000000","message":"Patch Set 1: -Code-Review\n\n(2 comments)\n\nA couple more comments/questions.\n\nThe approach here is interesting. I\u0027m a little slow on digging into this because of the summit. I\u0027m going to look at some other http clients beyond guzzle. Though, I don\u0027t think we should be like general http clients because we have a special case and there is no PSR for one (which surprised me when I went looking).\n\nIf you have any information on why you change guzzle error handling to be event based I\u0027d be interested in seeing it. I like the way the request and response are passed on for the exceptions.","accounts_in_message":[],"_revision_number":1},{"id":"4b2ebd431b6852d2e624ec391fc3fc4a91488d4c","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-05-14 10:04:16.000000000","message":"Patch Set 1:\n\nI agree about being over-general, too - we shouldn\u0027t try to get distracted by irrelevant functionality. But I think there\u0027s an important difference between over-generalizing and decoupling.\n\nGuzzle actually uses events heavily throughout its codebase to track the lifecycle of a Request. When a Request completes, Guzzle fires off a \"complete\" event which allows extraneous subscribers (like our error handler) to unobtrusively add functionality. So what we\u0027re doing is not changing Guzzle, but actually complementing it quite nicely by adding functionality on top of it. \n\nOn a separate side-note, I think we should use events in our  SDK too because they\u0027re extremely powerful, and allow users to add in bespoke functionality without hacking, extending or overriding our base classes. They add their own subscribers, which are invoked when our events are dispatched. But this should be discussed in another patch/blueprint :)","accounts_in_message":[],"_revision_number":1},{"id":"edaa0e401ba29dd9be4caacd2eeeb425f6968031","author":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"date":"2014-05-14 10:14:52.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nI\u0027m currently researching some of the design/philosophy changes and am leaving the few comments I have at this point.","accounts_in_message":[],"_revision_number":1},{"id":"d0d9f99f5966428f830f03e642a23d905aaf4b39","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-05-14 10:51:36.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"5445e2c8da70ae2d0e1bddf3f546c62ccc7160e0","author":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"date":"2014-05-15 09:33:15.000000000","message":"Patch Set 1:\n\n(5 comments)\n\nSome thoughts/comments:\n\n- The code looks good.\n- I\u0027d like to hear more from everyone else about their thoughts on the design.\n- Looking at some of the comments others have left thus far, I wonder if it would have made more sense to tackle something like this after evaluating the suitability of JSON schema in depth? It almost seems like we\u0027re setting ourselves up to refactor and then revert certain files if JSON scehma will suit the needs of the SDK.\n- I didn\u0027t spend a lot of time digging into this, but I am getting a seg fault after this most recent patch\u0027s test suite finishes. If anyone else sees this, please let me know before I potentially dig into a rabbit hole.\n\n\t\tPHP Fatal error:  Unsupported operand types in /home/sam/Coding/openstackPHP/openstack-sdk-php/vendor/guzzlehttp/guzzle/src/Url.php on line 41\n\nSegmentation fault (core dumped)","accounts_in_message":[],"_revision_number":1},{"id":"f8d18088d3272c7e80d1e1441f0f5a031badcd8e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-16 12:46:13.000000000","message":"Patch Set 1: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"1d3d2ebcb39d0efc1ec87c6dc1608cb2b2d0eed1","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-05-16 12:46:13.000000000","message":"Patch Set 1:\n\n(4 comments)\n\nI don\u0027t think this feature heavily depends on JSON schema - whether we implement it or not. The only change that might happen is the removal of the HTTP convenience methods - which is more of a usability discussion. That being said, all of this will look the same with or without JSON schemas.\n\nI also see the segfault issue - I\u0027ll investigate more.","accounts_in_message":[],"_revision_number":1},{"id":"f41698dfb9264fb7aaffde611eff83b41adc94ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-16 12:46:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/1/check/noop/1a70367 : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"886a7f1acea1f4b57f9874394f027f48e479858b","author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"date":"2014-05-19 17:28:01.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nI like the direction this is headed in. Aside from the inline comments I have one question. Why use events on Guzzle rather than the previous architecture for handling exceptions? I\u0027m looking to gain some insight.","accounts_in_message":[],"_revision_number":1},{"id":"5b78db1371eec09fed676b78e502b1128240b26b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-19 17:28:02.000000000","message":"Patch Set 1: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"4f33eee4d2f8f044863c0b2d70e90804e7bdad54","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-19 17:28:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/1/check/noop/0bb9ca4 : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d82fc46ccc7ab6f7591fe803920cf74790963185","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-05-22 11:37:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ff25bb59789f0e33b5e85a9fcea9d47975342b15","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-22 11:37:35.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"97ef223fe0e1d2bc0d07487097d1d4244d312c14","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-22 11:37:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/2/check/noop/0bc0460 : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5a16e25a604799065aa0c004a244995473e8fd7a","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-05-22 12:08:42.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"db25b4760141855e2f8a16dcf5e37b418e475a70","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-22 12:08:43.000000000","message":"Patch Set 3:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"e7fe10fca316449742757997d255e551784da925","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-22 12:08:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/3/check/noop/7052b30 : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"8e7129a97b2426620944ee901ae8b8a146fe7ff3","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-05-27 12:53:26.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"629de7fa32497c8c549aa9d41d46b0d64d2fbc39","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-27 12:53:33.000000000","message":"Patch Set 4:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"4a668fb486074d82dd906cff30753bdc28419156","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-27 12:53:34.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/4/check/noop/9bd9d79 : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"7819e27d80f1189e907988f518ec8854210a48d9","author":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"date":"2014-05-29 09:27:40.000000000","message":"Patch Set 2:\n\n(4 comments)\n\nIt appears that changes unrelated to the scope of the patch were introduced and are encouraging scope creep. Otherwise, changes look good from what I\u0027ve seen thus far. \n\nI would recommend that the specific changes I pointed out between patch 1 and 2 (StreamWrapperTest, StreamWrapperFSTest) get moved to a different patch.","accounts_in_message":[],"_revision_number":2},{"id":"297e83df2354e85ebfa0188513acad9bb1cd7371","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-05-29 11:05:07.000000000","message":"Patch Set 2:\n\n(3 comments)\n\nThanks for reviewing. I understand the concern about scope creep, but the StreamWrapper tests refactoring was needed in order to fix the segfault issue. Without it, this patch would introduce a bug into the codebase - so removing it is a priority item which cannot be extracted into another patch IMO.","accounts_in_message":[],"_revision_number":2},{"id":"e925766d228553454932c6cc8f051f5a63d32f75","author":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"date":"2014-05-30 10:02:27.000000000","message":"Patch Set 4:\n\nOk, that sounds fine to me. Out of curiosity, what was the source of the seg fault?","accounts_in_message":[],"_revision_number":4},{"id":"53b452c4da5af548b41bb6be8040d54c07a809d7","author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"date":"2014-05-30 15:40:23.000000000","message":"Patch Set 4:\n\n(13 comments)\n\nJamie, thanks for working this through. While I have a whole bunch of comments (this is a long patch) I generally like the direction it\u0027s going.","accounts_in_message":[],"_revision_number":4},{"id":"059b3e770438f41e392a10a2b69418b9c5ab0da5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-30 15:40:25.000000000","message":"Patch Set 4: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"ee81d4d6f37ce4bc5a64856bb6911ef434f2278a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-30 15:40:26.000000000","message":"Patch Set 4: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":4},{"id":"f989791f21d26e13003faa20e4419f743063abda","author":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"date":"2014-06-01 00:28:32.000000000","message":"Patch Set 2:\n\n(2 comments)\n\nAdding few more comments","accounts_in_message":[],"_revision_number":2},{"id":"47ea5861402a3d9d247e282529d67dac8d56e080","author":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"date":"2014-06-01 00:29:03.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nAnother comment","accounts_in_message":[],"_revision_number":4},{"id":"58a640ffb123f0fb6f865ed1daa2bcbc4582c72a","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-02 09:41:39.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"46101d77d5d9dbe2be355813aeffc3ffea5f98cc","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-02 09:48:59.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"1bde6b450c0698089e3fd754f64eeeb97996e25d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-02 09:49:00.000000000","message":"Patch Set 5:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"52bdf10575bec4e2429911f1371f03540e96459f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-02 09:49:01.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/5/check/noop/12ebfcc : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"815d0ead77310fa1a8d4e1f105cfd4a2d6564a12","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-02 09:49:23.000000000","message":"Patch Set 4:\n\n(14 comments)","accounts_in_message":[],"_revision_number":4},{"id":"01f428ea342e9239b1cea159077d405589fade84","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-02 10:29:59.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"7f4e6171e3148ec71f60cb3a0025e315ca2c8cbd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-02 10:30:00.000000000","message":"Patch Set 6:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"c3e809f6ebb3d444b73c61047e00e77fcd7a9289","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-02 10:30:00.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/6/check/noop/3c1e725 : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"13f039ba2de578d3fad4a51e94ce1ef1fd26e1fd","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-02 14:10:03.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"07ab50d8189856b2cfc20444a0e6d8e87e9a17ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-02 14:10:05.000000000","message":"Patch Set 7:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"da7c45c3b0f7dfd157cb88967adb96f5cf160e11","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-02 14:10:06.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/7/check/noop/e05545a : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"fdf05a8ece5ce1af6d5a6e2f0619984cd2db66c1","author":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"date":"2014-06-03 06:11:07.000000000","message":"Patch Set 7:\n\n(1 comment)\n\nI\u0027ve caught up on reviewing patch 4-7. I think there are just a few minor things from past reviews that Matt and I did that I didn\u0027t see changed yet. Unless someone else brings up a major issue, I\u0027m ready to approve once the previous issues are addressed.","accounts_in_message":[],"_revision_number":7},{"id":"22d965cdc8079fa4ae114913776ff8009d329557","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-03 07:23:36.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"4ddf007b2da30373a4954eae09d8364d3f12a1f2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 08:37:40.000000000","message":"Patch Set 8:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":8},{"id":"d1a041e12e52e892fefbe94478d8baeccf68132b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 09:00:04.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/8/check/noop/e107397 : SUCCESS","accounts_in_message":[],"_revision_number":8},{"id":"35fe19aeedc58ee22500678895f7ce89eec85f71","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-03 12:35:54.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"ebb16711631cc30ff08b79d1239fab791c3dcc4a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 12:36:02.000000000","message":"Patch Set 9:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":9},{"id":"b9807a13f120c62e547831c4d113c1b667b5f057","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 12:36:04.000000000","message":"Patch Set 9: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/9/check/noop/1dcdbf1 : SUCCESS","accounts_in_message":[],"_revision_number":9},{"id":"9a326ed554faf6f52e3e060d8c6ce78b72458ae7","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-03 12:38:42.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"94ce385ca9a25f17c37e7b87feabe09be63aaf6b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 12:38:43.000000000","message":"Patch Set 10:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":10},{"id":"2ec7e7d159e2a397c3c12b30ae60c4b9a6084313","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 12:38:44.000000000","message":"Patch Set 10: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/10/check/noop/12c924e : SUCCESS","accounts_in_message":[],"_revision_number":10},{"id":"41fde69aa7a7152075a8f0334006ccf95c08ac16","author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"date":"2014-06-04 17:47:32.000000000","message":"Patch Set 4:\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"0833f80683a11e5966c4d34b98248bee30dd5e35","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-04 19:05:12.000000000","message":"Patch Set 4:\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"809c3b64acb8c0d197a9a82286db9dfdd7aded5d","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-05 08:04:26.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"ab400835382456444cf49c5853f5ad58d24170ff","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-05 08:10:00.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"57a6eb07c5fec59b3e1eef88dddd9bb29161c1ae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-05 08:10:03.000000000","message":"Patch Set 11:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":11},{"id":"04cd8be4edb652f840845f3a44fda4a496496029","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-05 08:10:03.000000000","message":"Patch Set 11: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/11/check/noop/c551e1f : SUCCESS","accounts_in_message":[],"_revision_number":11},{"id":"ade5726894242bcbaaa442792047f93d2195e016","author":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"date":"2014-06-05 09:11:55.000000000","message":"Patch Set 9:\n\n(1 comment)\n\nLooks like reviewers should ignore this patch right? Appears to have accidentally reverted some files to an older version.","accounts_in_message":[],"_revision_number":9},{"id":"adfe23170e1396866523bd3c7609854898a49570","author":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"date":"2014-06-05 09:18:12.000000000","message":"Patch Set 11: Code-Review+1\n\nThe addition of documentation to several files looks great. I\u0027d be much more content with the docs as a new user. \n\nTested locally vs Devstack without issues. \n\nI believe everything I\u0027ve brought up has been addressed and will wait for others to work out their concerns. Regarding the possibility of a transport client singleton - I think for practical purposes that we should shelve that for future discussion since this review is a blocker for almost every other patch that touches the current code base.","accounts_in_message":[],"_revision_number":11},{"id":"c916c6f38fcc88f3944ca78de07b25bd5c90b9b6","author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"date":"2014-06-05 14:58:17.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"5e388eb90c003798b533b480a7aaa7d5f4c1fb6d","author":{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},"date":"2014-06-07 00:34:45.000000000","message":"Patch Set 11:\n\n(8 comments)\n\nSee comments inline with code.","accounts_in_message":[],"_revision_number":11},{"id":"bd913a5dcc12451b0adbf261d7c2b16f7172a4db","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-07 17:04:03.000000000","message":"Patch Set 11:\n\n(4 comments)","accounts_in_message":[],"_revision_number":11},{"id":"583838aa28b526faf6bebb3147201df406dceaca","author":{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},"date":"2014-06-07 17:15:34.000000000","message":"Patch Set 11: Code-Review+2 Workflow+1\n\n(3 comments)\n\nMost of my comments have been addressed satisfactorily by Jamie. The remaining ones are trivial and can be addressed in a separate review. Merging.","accounts_in_message":[],"_revision_number":11},{"id":"175552137ae4d98a00c309140fd5fde44c98b85f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-07 17:15:35.000000000","message":"Patch Set 11: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":11},{"id":"54cc3b77412e0d43c843da18363f0f6215fdd0d4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-07 17:15:35.000000000","message":"Patch Set 11: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/11/check/noop/3c88a0f : SUCCESS","accounts_in_message":[],"_revision_number":11},{"id":"1c035158b39cfea752feb924d4349c837999aa14","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-07 17:15:36.000000000","message":"Patch Set 11: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":11},{"id":"6e98fd8b2be032a0fdb6c2fe86e8852731f635a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-07 17:15:37.000000000","message":"Patch Set 11: Verified+2\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/89/93089/11/gate/noop/755431e : SUCCESS","accounts_in_message":[],"_revision_number":11},{"id":"d228f478dfc3e567ab9bdab2d35033b2662f4f79","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-07 17:15:37.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":11}],"current_revision_number":11,"current_revision":"c91e2932aa6dfd9813a61f70698eb7a438306af8","revisions":{"2fa3167d72667bdc10d7964ce43aa29df058d9e1":{"kind":"REWORK","_number":1,"created":"2014-05-09 17:22:44.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/89/93089/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/89/93089/1","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/1"}}},"commit":{"parents":[{"commit":"7035fa4adebae6433c5f863ecd690bfe3c8acaa6","subject":"Merge \"Fixes an issue with Rackspace tenant IDs and Swift regions. Also fixes tests that simply do not work with certain Rackspace/OpenStack implementations.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/7035fa4adebae6433c5f863ecd690bfe3c8acaa6"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-04-30 17:10:26.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-05-09 17:19:49.000000000","tz":120},"subject":"Refactors ClientInterface and Guzzle adapter.","message":"Refactors ClientInterface and Guzzle adapter.\n\nThis patch achieves three interrelated changes\n\n1. an update to the ClientInterface, making it more efficient and\nconsistent with other HTTP libraries. PSR-FIG messages have also been\nadded as separate classes, rather than lumped as one. Guzzle\nfunctionality has also been moved to its own namespace;\n\n2. the refactoring of `GuzzleClient` to `GuzzleAdapter`, including\nrelevant changes needed for the interface change (1). We now have\nADAPTERS that bridge our interfaces with Guzzle\u0027s - making that\ndifference much clearer, extensible, less tightly coupled and less\nbrittle;\n\n3. moving \"bad request\" error handling into its own dedicated space,\nbased on how the new Adapter functionality (2). Previously the client\ntried to do all the exception logic - but this is not strictly its\nresponsibility. This logic has been shipped out to a base\nRequestException which instantiates one of its children exception based\non the HTTP status code.\n\nAlthough I have attempted to keep the scope of this patch to a minimum,\nas granular as possible, because the interface is a core internal API,\nvarious other files need to be modified to reflect the change. In terms\nof the other two changes, these are inextricably linked to the interface\nchange, so cannot be teased out into their own patches.\n\nChange-Id: Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/2fa3167d72667bdc10d7964ce43aa29df058d9e1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/2fa3167d72667bdc10d7964ce43aa29df058d9e1"}]},"branch":"refs/heads/master"},"c6a59a153dc4420a4d5be8b0e686a8db387b1a37":{"kind":"REWORK","_number":2,"created":"2014-05-22 11:37:31.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/89/93089/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/89/93089/2","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/2"}}},"commit":{"parents":[{"commit":"7035fa4adebae6433c5f863ecd690bfe3c8acaa6","subject":"Merge \"Fixes an issue with Rackspace tenant IDs and Swift regions. Also fixes tests that simply do not work with certain Rackspace/OpenStack implementations.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/7035fa4adebae6433c5f863ecd690bfe3c8acaa6"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-04-30 17:10:26.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-05-22 11:36:54.000000000","tz":120},"subject":"Refactors ClientInterface and Guzzle adapter.","message":"Refactors ClientInterface and Guzzle adapter.\n\nThis patch achieves three interrelated changes\n\n1. an update to the ClientInterface, making it more efficient and\nconsistent with other HTTP libraries. PSR-FIG messages have also been\nadded as separate classes, rather than lumped as one. Guzzle\nfunctionality has also been moved to its own namespace;\n\n2. the refactoring of `GuzzleClient` to `GuzzleAdapter`, including\nrelevant changes needed for the interface change (1). We now have\nADAPTERS that bridge our interfaces with Guzzle\u0027s - making that\ndifference much clearer, extensible, less tightly coupled and less\nbrittle;\n\n3. moving \"bad request\" error handling into its own dedicated space,\nbased on how the new Adapter functionality (2). Previously the client\ntried to do all the exception logic - but this is not strictly its\nresponsibility. This logic has been shipped out to a base\nRequestException which instantiates one of its children exception based\non the HTTP status code.\n\nAlthough I have attempted to keep the scope of this patch to a minimum,\nas granular as possible, because the interface is a core internal API,\nvarious other files need to be modified to reflect the change. In terms\nof the other two changes, these are inextricably linked to the interface\nchange, so cannot be teased out into their own patches.\n\nChange-Id: Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/c6a59a153dc4420a4d5be8b0e686a8db387b1a37"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/c6a59a153dc4420a4d5be8b0e686a8db387b1a37"}]},"branch":"refs/heads/master"},"9521feca8c28f6dd7e813bb8a6a83409e8b4271b":{"kind":"REWORK","_number":3,"created":"2014-05-22 12:08:42.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/89/93089/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/89/93089/3","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/3"}}},"commit":{"parents":[{"commit":"7035fa4adebae6433c5f863ecd690bfe3c8acaa6","subject":"Merge \"Fixes an issue with Rackspace tenant IDs and Swift regions. Also fixes tests that simply do not work with certain Rackspace/OpenStack implementations.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/7035fa4adebae6433c5f863ecd690bfe3c8acaa6"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-04-30 17:10:26.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-05-22 12:08:29.000000000","tz":120},"subject":"Refactors ClientInterface and Guzzle adapter.","message":"Refactors ClientInterface and Guzzle adapter.\n\nThis patch achieves three interrelated changes\n\n1. an update to the ClientInterface, making it more efficient and\nconsistent with other HTTP libraries. PSR-FIG messages have also been\nadded as separate classes, rather than lumped as one. Guzzle\nfunctionality has also been moved to its own namespace;\n\n2. the refactoring of `GuzzleClient` to `GuzzleAdapter`, including\nrelevant changes needed for the interface change (1). We now have\nADAPTERS that bridge our interfaces with Guzzle\u0027s - making that\ndifference much clearer, extensible, less tightly coupled and less\nbrittle;\n\n3. moving \"bad request\" error handling into its own dedicated space,\nbased on how the new Adapter functionality (2). Previously the client\ntried to do all the exception logic - but this is not strictly its\nresponsibility. This logic has been shipped out to a base\nRequestException which instantiates one of its children exception based\non the HTTP status code.\n\nAlthough I have attempted to keep the scope of this patch to a minimum,\nas granular as possible, because the interface is a core internal API,\nvarious other files need to be modified to reflect the change. In terms\nof the other two changes, these are inextricably linked to the interface\nchange, so cannot be teased out into their own patches.\n\nChange-Id: Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/9521feca8c28f6dd7e813bb8a6a83409e8b4271b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/9521feca8c28f6dd7e813bb8a6a83409e8b4271b"}]},"branch":"refs/heads/master"},"d039119151e9de9dcc7ee30875542b02c90715e0":{"kind":"REWORK","_number":4,"created":"2014-05-27 12:53:26.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/89/93089/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/89/93089/4","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/4"}}},"commit":{"parents":[{"commit":"7035fa4adebae6433c5f863ecd690bfe3c8acaa6","subject":"Merge \"Fixes an issue with Rackspace tenant IDs and Swift regions. Also fixes tests that simply do not work with certain Rackspace/OpenStack implementations.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/7035fa4adebae6433c5f863ecd690bfe3c8acaa6"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-04-30 17:10:26.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-05-27 12:48:08.000000000","tz":120},"subject":"Refactors ClientInterface and Guzzle adapter.","message":"Refactors ClientInterface and Guzzle adapter.\n\nThis patch achieves three interrelated changes\n\n1. an update to the ClientInterface, making it more efficient and\nconsistent with other HTTP libraries. PSR-FIG messages have also been\nadded as separate classes, rather than lumped as one. Guzzle\nfunctionality has also been moved to its own namespace;\n\n2. the refactoring of `GuzzleClient` to `GuzzleAdapter`, including\nrelevant changes needed for the interface change (1). We now have\nADAPTERS that bridge our interfaces with Guzzle\u0027s - making that\ndifference much clearer, extensible, less tightly coupled and less\nbrittle;\n\n3. moving \"bad request\" error handling into its own dedicated space,\nbased on how the new Adapter functionality (2). Previously the client\ntried to do all the exception logic - but this is not strictly its\nresponsibility. This logic has been shipped out to a base\nRequestException which instantiates one of its children exception based\non the HTTP status code.\n\nAlthough I have attempted to keep the scope of this patch to a minimum,\nas granular as possible, because the interface is a core internal API,\nvarious other files need to be modified to reflect the change. In terms\nof the other two changes, these are inextricably linked to the interface\nchange, so cannot be teased out into their own patches.\n\nChange-Id: Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/d039119151e9de9dcc7ee30875542b02c90715e0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/d039119151e9de9dcc7ee30875542b02c90715e0"}]},"branch":"refs/heads/master"},"15418b42388b63e359aaaaa9d3396b14b7dbeda7":{"kind":"REWORK","_number":5,"created":"2014-06-02 09:48:59.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/89/93089/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/89/93089/5","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/5"}}},"commit":{"parents":[{"commit":"bcdcba06f71256df484759cd13e7686db548c8d5","subject":"Removed all deprecated functionality and updated docs and tests as needed. Implements blueprint remove-deprecated","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/bcdcba06f71256df484759cd13e7686db548c8d5"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-04-30 17:10:26.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-02 09:48:48.000000000","tz":120},"subject":"Refactors ClientInterface and Guzzle adapter.","message":"Refactors ClientInterface and Guzzle adapter.\n\nThis patch achieves three interrelated changes\n\n1. an update to the ClientInterface, making it more efficient and\nconsistent with other HTTP libraries. PSR-FIG messages have also been\nadded as separate classes, rather than lumped as one. Guzzle\nfunctionality has also been moved to its own namespace;\n\n2. the refactoring of `GuzzleClient` to `GuzzleAdapter`, including\nrelevant changes needed for the interface change (1). We now have\nADAPTERS that bridge our interfaces with Guzzle\u0027s - making that\ndifference much clearer, extensible, less tightly coupled and less\nbrittle;\n\n3. moving \"bad request\" error handling into its own dedicated space,\nbased on how the new Adapter functionality (2). Previously the client\ntried to do all the exception logic - but this is not strictly its\nresponsibility. This logic has been shipped out to a base\nRequestException which instantiates one of its children exception based\non the HTTP status code.\n\nAlthough I have attempted to keep the scope of this patch to a minimum,\nas granular as possible, because the interface is a core internal API,\nvarious other files need to be modified to reflect the change. In terms\nof the other two changes, these are inextricably linked to the interface\nchange, so cannot be teased out into their own patches.\n\nChange-Id: Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/15418b42388b63e359aaaaa9d3396b14b7dbeda7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/15418b42388b63e359aaaaa9d3396b14b7dbeda7"}]},"branch":"refs/heads/master"},"fb7c34bf5f089c8df5fea4f1f8ce9a54283b2905":{"kind":"REWORK","_number":6,"created":"2014-06-02 10:29:59.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/89/93089/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/89/93089/6","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/6"}}},"commit":{"parents":[{"commit":"bcdcba06f71256df484759cd13e7686db548c8d5","subject":"Removed all deprecated functionality and updated docs and tests as needed. Implements blueprint remove-deprecated","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/bcdcba06f71256df484759cd13e7686db548c8d5"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-04-30 17:10:26.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-02 10:29:49.000000000","tz":120},"subject":"Refactors ClientInterface and Guzzle adapter.","message":"Refactors ClientInterface and Guzzle adapter.\n\nThis patch achieves three interrelated changes\n\n1. an update to the ClientInterface, making it more efficient and\nconsistent with other HTTP libraries. PSR-FIG messages have also been\nadded as separate classes, rather than lumped as one. Guzzle\nfunctionality has also been moved to its own namespace;\n\n2. the refactoring of `GuzzleClient` to `GuzzleAdapter`, including\nrelevant changes needed for the interface change (1). We now have\nADAPTERS that bridge our interfaces with Guzzle\u0027s - making that\ndifference much clearer, extensible, less tightly coupled and less\nbrittle;\n\n3. moving \"bad request\" error handling into its own dedicated space,\nbased on how the new Adapter functionality (2). Previously the client\ntried to do all the exception logic - but this is not strictly its\nresponsibility. This logic has been shipped out to a base\nRequestException which instantiates one of its children exception based\non the HTTP status code.\n\nAlthough I have attempted to keep the scope of this patch to a minimum,\nas granular as possible, because the interface is a core internal API,\nvarious other files need to be modified to reflect the change. In terms\nof the other two changes, these are inextricably linked to the interface\nchange, so cannot be teased out into their own patches.\n\nChange-Id: Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/fb7c34bf5f089c8df5fea4f1f8ce9a54283b2905"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/fb7c34bf5f089c8df5fea4f1f8ce9a54283b2905"}]},"branch":"refs/heads/master"},"613cb65f2a743424e495b67c221c4e97aa25b326":{"kind":"REWORK","_number":7,"created":"2014-06-02 14:10:03.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/89/93089/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/89/93089/7","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/7"}}},"commit":{"parents":[{"commit":"bcdcba06f71256df484759cd13e7686db548c8d5","subject":"Removed all deprecated functionality and updated docs and tests as needed. Implements blueprint remove-deprecated","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/bcdcba06f71256df484759cd13e7686db548c8d5"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-04-30 17:10:26.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-02 14:08:08.000000000","tz":120},"subject":"Refactors ClientInterface and Guzzle adapter.","message":"Refactors ClientInterface and Guzzle adapter.\n\nThis patch achieves three interrelated changes\n\n1. an update to the ClientInterface, making it more efficient and\nconsistent with other HTTP libraries. PSR-FIG messages have also been\nadded as separate classes, rather than lumped as one. Guzzle\nfunctionality has also been moved to its own namespace;\n\n2. the refactoring of `GuzzleClient` to `GuzzleAdapter`, including\nrelevant changes needed for the interface change (1). We now have\nADAPTERS that bridge our interfaces with Guzzle\u0027s - making that\ndifference much clearer, extensible, less tightly coupled and less\nbrittle;\n\n3. moving \"bad request\" error handling into its own dedicated space,\nbased on how the new Adapter functionality (2). Previously the client\ntried to do all the exception logic - but this is not strictly its\nresponsibility. This logic has been shipped out to a base\nRequestException which instantiates one of its children exception based\non the HTTP status code.\n\nAlthough I have attempted to keep the scope of this patch to a minimum,\nas granular as possible, because the interface is a core internal API,\nvarious other files need to be modified to reflect the change. In terms\nof the other two changes, these are inextricably linked to the interface\nchange, so cannot be teased out into their own patches.\n\nChange-Id: Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/613cb65f2a743424e495b67c221c4e97aa25b326"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/613cb65f2a743424e495b67c221c4e97aa25b326"}]},"branch":"refs/heads/master"},"e424bedec46a74246596b95804c70cd344f40f13":{"kind":"REWORK","_number":8,"created":"2014-06-03 07:23:36.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/89/93089/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/89/93089/8","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/8"}}},"commit":{"parents":[{"commit":"bcdcba06f71256df484759cd13e7686db548c8d5","subject":"Removed all deprecated functionality and updated docs and tests as needed. Implements blueprint remove-deprecated","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/bcdcba06f71256df484759cd13e7686db548c8d5"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-04-30 17:10:26.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-03 07:22:36.000000000","tz":120},"subject":"Refactors ClientInterface and Guzzle adapter.","message":"Refactors ClientInterface and Guzzle adapter.\n\nThis patch achieves three interrelated changes\n\n1. an update to the ClientInterface, making it more efficient and\nconsistent with other HTTP libraries. PSR-FIG messages have also been\nadded as separate classes, rather than lumped as one. Guzzle\nfunctionality has also been moved to its own namespace;\n\n2. the refactoring of `GuzzleClient` to `GuzzleAdapter`, including\nrelevant changes needed for the interface change (1). We now have\nADAPTERS that bridge our interfaces with Guzzle\u0027s - making that\ndifference much clearer, extensible, less tightly coupled and less\nbrittle;\n\n3. moving \"bad request\" error handling into its own dedicated space,\nbased on how the new Adapter functionality (2). Previously the client\ntried to do all the exception logic - but this is not strictly its\nresponsibility. This logic has been shipped out to a base\nRequestException which instantiates one of its children exception based\non the HTTP status code.\n\nAlthough I have attempted to keep the scope of this patch to a minimum,\nas granular as possible, because the interface is a core internal API,\nvarious other files need to be modified to reflect the change. In terms\nof the other two changes, these are inextricably linked to the interface\nchange, so cannot be teased out into their own patches.\n\nChange-Id: Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/e424bedec46a74246596b95804c70cd344f40f13"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/e424bedec46a74246596b95804c70cd344f40f13"}]},"branch":"refs/heads/master"},"2cb9b8ed1ed12d64e9a3eba974dfe87912ca5003":{"kind":"REWORK","_number":9,"created":"2014-06-03 12:35:54.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/89/93089/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/89/93089/9","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/9"}}},"commit":{"parents":[{"commit":"bcdcba06f71256df484759cd13e7686db548c8d5","subject":"Removed all deprecated functionality and updated docs and tests as needed. Implements blueprint remove-deprecated","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/bcdcba06f71256df484759cd13e7686db548c8d5"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-04-30 17:10:26.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-03 12:34:40.000000000","tz":120},"subject":"Refactors ClientInterface and Guzzle adapter.","message":"Refactors ClientInterface and Guzzle adapter.\n\nThis patch achieves three interrelated changes\n\n1. an update to the ClientInterface, making it more efficient and\nconsistent with other HTTP libraries. PSR-FIG messages have also been\nadded as separate classes, rather than lumped as one. Guzzle\nfunctionality has also been moved to its own namespace;\n\n2. the refactoring of `GuzzleClient` to `GuzzleAdapter`, including\nrelevant changes needed for the interface change (1). We now have\nADAPTERS that bridge our interfaces with Guzzle\u0027s - making that\ndifference much clearer, extensible, less tightly coupled and less\nbrittle;\n\n3. moving \"bad request\" error handling into its own dedicated space,\nbased on how the new Adapter functionality (2). Previously the client\ntried to do all the exception logic - but this is not strictly its\nresponsibility. This logic has been shipped out to a base\nRequestException which instantiates one of its children exception based\non the HTTP status code.\n\nAlthough I have attempted to keep the scope of this patch to a minimum,\nas granular as possible, because the interface is a core internal API,\nvarious other files need to be modified to reflect the change. In terms\nof the other two changes, these are inextricably linked to the interface\nchange, so cannot be teased out into their own patches.\n\nChange-Id: Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/2cb9b8ed1ed12d64e9a3eba974dfe87912ca5003"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/2cb9b8ed1ed12d64e9a3eba974dfe87912ca5003"}]},"branch":"refs/heads/master"},"018fa2a6de232c2d42a550c9f099fdd50b02892c":{"kind":"REWORK","_number":10,"created":"2014-06-03 12:38:42.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/89/93089/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/89/93089/10","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/10"}}},"commit":{"parents":[{"commit":"bcdcba06f71256df484759cd13e7686db548c8d5","subject":"Removed all deprecated functionality and updated docs and tests as needed. Implements blueprint remove-deprecated","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/bcdcba06f71256df484759cd13e7686db548c8d5"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-04-30 17:10:26.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-03 12:38:30.000000000","tz":120},"subject":"Refactors ClientInterface and Guzzle adapter.","message":"Refactors ClientInterface and Guzzle adapter.\n\nThis patch achieves three interrelated changes\n\n1. an update to the ClientInterface, making it more efficient and\nconsistent with other HTTP libraries. PSR-FIG messages have also been\nadded as separate classes, rather than lumped as one. Guzzle\nfunctionality has also been moved to its own namespace;\n\n2. the refactoring of `GuzzleClient` to `GuzzleAdapter`, including\nrelevant changes needed for the interface change (1). We now have\nADAPTERS that bridge our interfaces with Guzzle\u0027s - making that\ndifference much clearer, extensible, less tightly coupled and less\nbrittle;\n\n3. moving \"bad request\" error handling into its own dedicated space,\nbased on how the new Adapter functionality (2). Previously the client\ntried to do all the exception logic - but this is not strictly its\nresponsibility. This logic has been shipped out to a base\nRequestException which instantiates one of its children exception based\non the HTTP status code.\n\nAlthough I have attempted to keep the scope of this patch to a minimum,\nas granular as possible, because the interface is a core internal API,\nvarious other files need to be modified to reflect the change. In terms\nof the other two changes, these are inextricably linked to the interface\nchange, so cannot be teased out into their own patches.\n\nChange-Id: Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/018fa2a6de232c2d42a550c9f099fdd50b02892c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/018fa2a6de232c2d42a550c9f099fdd50b02892c"}]},"branch":"refs/heads/master"},"c91e2932aa6dfd9813a61f70698eb7a438306af8":{"kind":"REWORK","_number":11,"created":"2014-06-05 08:10:00.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/89/93089/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/89/93089/11","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/89/93089/11"}}},"commit":{"parents":[{"commit":"bcdcba06f71256df484759cd13e7686db548c8d5","subject":"Removed all deprecated functionality and updated docs and tests as needed. Implements blueprint remove-deprecated","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/bcdcba06f71256df484759cd13e7686db548c8d5"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-04-30 17:10:26.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-05 08:09:03.000000000","tz":120},"subject":"Refactors ClientInterface and Guzzle adapter.","message":"Refactors ClientInterface and Guzzle adapter.\n\nThis patch achieves three interrelated changes\n\n1. an update to the ClientInterface, making it more efficient and\nconsistent with other HTTP libraries. PSR-FIG messages have also been\nadded as separate classes, rather than lumped as one. Guzzle\nfunctionality has also been moved to its own namespace;\n\n2. the refactoring of `GuzzleClient` to `GuzzleAdapter`, including\nrelevant changes needed for the interface change (1). We now have\nADAPTERS that bridge our interfaces with Guzzle\u0027s - making that\ndifference much clearer, extensible, less tightly coupled and less\nbrittle;\n\n3. moving \"bad request\" error handling into its own dedicated space,\nbased on how the new Adapter functionality (2). Previously the client\ntried to do all the exception logic - but this is not strictly its\nresponsibility. This logic has been shipped out to a base\nRequestException which instantiates one of its children exception based\non the HTTP status code.\n\nAlthough I have attempted to keep the scope of this patch to a minimum,\nas granular as possible, because the interface is a core internal API,\nvarious other files need to be modified to reflect the change. In terms\nof the other two changes, these are inextricably linked to the interface\nchange, so cannot be teased out into their own patches.\n\nChange-Id: Ibc1b50cec125c11d32ee6e4f0dbb395fcaea864e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/c91e2932aa6dfd9813a61f70698eb7a438306af8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/c91e2932aa6dfd9813a61f70698eb7a438306af8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}