)]}'
{"id":"stackforge%2Fopenstack-sdk-php~97482","triplet_id":"stackforge%2Fopenstack-sdk-php~master~I335ecdff7afdc88ef6d6c62e15c8d9ad498aed11","project":"stackforge/openstack-sdk-php","branch":"master","topic":"service-catalog-models","hashtags":[],"change_id":"I335ecdff7afdc88ef6d6c62e15c8d9ad498aed11","subject":"Adding service catalog models","status":"ABANDONED","created":"2014-06-03 12:35:54.000000000","updated":"2015-10-17 19:23:13.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"58622288b107132c3c487c068c2b337aa7c5fd92","_number":97482,"virtual_id_number":97482,"owner":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-10-17 19:23:13.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":1,"date":"2014-06-23 09:21:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-06-17 09:15:46.000000000","updated_by":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"reviewer":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"state":"REVIEWER"},{"updated":"2014-06-23 09:21:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-10-17 19:23:13.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"}],"messages":[{"id":"d2863689ff56f6b12d60d34b20977cfd4ce2b503","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-03 12:35:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6b22ca532b858ff7a6af5d3b02f390835cb6ddd6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 12:36:02.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"1a361f83c95550f5fd0bae13e63d31ee64bd2b58","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 12:36:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/82/97482/1/check/noop/6d5eef5 : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3edb1bb18e0cfcd28cd70206626129540d0a8b17","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-04 09:41:23.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"fec2851676529dd20c874a85f02f946d523e29b2","author":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"date":"2014-06-17 09:15:46.000000000","message":"Patch Set 1:\n\nAs of now, I\u0027ve only had a chance to go through a couple files in detail and had to skim the rest. I like the functionality provided in this patch as it will make it easier for us all to build out new services. \n\nI have a few comments/concerns though:\n\n- In the future, when Identity v3, v4, etc are all supported, it would probably make a lot more sense to move many of the class function implementations to something like an abstract class (or whatever makes sense for the situation) so that we\u0027re not running into situations where we have duplicate code between a v2, v3, and v4 Catalog. However, we should really be focusing on supporting more useful services like compute and networking instead of multiple identity versions for end users. So maybe this is fine as-is for now. I\u0027d be interested in what others think.\n- From what I understand, Identity v2 referred to both Tenant/Project interchangeably and v3 uses Project only (https://github.com/openstack/identity-api/blob/master/v3/src/markdown/identity-api-v3.md). In that light, it seems like it\u0027d make more sense to use \"Project\" instead of \"Tenant\" in this patch so that we\u0027re using proper terminology for v2 and v3 already. Of course, these models are targeted for v2 so mentioning tenant/project in the comments would still help out the typical OpenStack user.","accounts_in_message":[],"_revision_number":1},{"id":"f6871368ac10db903fa1c1897ad79b381ccc0cc0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-17 09:15:47.000000000","message":"Patch Set 1: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"24f741c59d6e4e1183f46e1e603df315dae2e837","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-17 09:15:48.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"1a2ebd43ab8a2ddd6c32ae1fbf235924f45ad0c1","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-23 09:16:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"12853f84cd329348b923e85679c3f3ebcfb11785","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-23 09:16:39.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"c8106ec8f378646674a9b17a32a8c7ace78c4224","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-23 09:16:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/82/97482/2/check/noop/140b257 : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"6dad321e4c24dbd79492a3ff8de0600f07d2e0ae","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-23 09:18:27.000000000","message":"Patch Set 2:\n\nSam - \n\nI checked the API docs for the v2 identity service and it seems to rely heavily on a \"tenant\" resource rather than a project. Tenant is also returned in the service catalog payload - so I think we should keep with this name for now. When we add v3 we can easily change this name \n\nJamie","accounts_in_message":[],"_revision_number":2},{"id":"45ea68cefbad921f3fb5cb875b3d2fdc6189a25a","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-23 09:21:34.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"30bae615ac3f5fafd88309767bd29608e660b9aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-23 09:21:35.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/82/97482/3/check/noop/8e64c83 : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"5beceeb6ec53d51ea98a10c627c59add345dbb23","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-23 09:21:35.000000000","message":"Patch Set 3:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"e420fdbe73cf48f7197eb0a5fd14bfe79c56e091","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2015-10-17 19:23:13.000000000","message":"Abandoned\n\nThis change has been abandoned because it belongs to a project that is part of the StackForge retirement. See http://governance.openstack.org/resolutions/20150615-stackforge-retirement.html for more details.","accounts_in_message":[],"_revision_number":3},{"id":"03ecf7f5d13802c773ef5bc113e1dd875325c504","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2015-10-17 19:23:13.000000000","message":"Patch Set 3:\n\nThis change has been abandoned because it belongs to a project that is part of the StackForge retirement. See http://governance.openstack.org/resolutions/20150615-stackforge-retirement.html for more details.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d4aebe417da9f0ea6934fc8c8316523c921f7bc7","revisions":{"8f3cde314a724e2e73c562e3c14bd9255c8f648e":{"kind":"REWORK","_number":1,"created":"2014-06-03 12:35:54.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/82/97482/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/82/97482/1","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/82/97482/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/82/97482/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/82/97482/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/82/97482/1"}}},"commit":{"parents":[{"commit":"feaf7dbce0d3e6947302447fbb7f4630d47cef18","subject":"Adding URL class for better encapsulation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/feaf7dbce0d3e6947302447fbb7f4630d47cef18"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-05-29 12:21:53.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-03 12:35:11.000000000","tz":120},"subject":"Adding service catalog models","message":"Adding service catalog models\n\nIntroduces better abstraction for 4 interrelated models:\n\n- Catalog, which is a series of services returned from the API\n- CatalogEntry, which is in essence a service\n- Endpoint, which defines the various URLs a service uses for a\n  geographic region\n- Tenant, which defines the validation token used for all subsequent API\n  operations\n\nThis patch is only meant to introduce these classes as a foundation for\nfuture KeyStone functionality. No integration is currently supported.\n\nChange-Id: I335ecdff7afdc88ef6d6c62e15c8d9ad498aed11\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/8f3cde314a724e2e73c562e3c14bd9255c8f648e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/8f3cde314a724e2e73c562e3c14bd9255c8f648e"}]},"branch":"refs/heads/master"},"85526418eed80e4e0a0f2f2c895842322948cf07":{"kind":"REWORK","_number":2,"created":"2014-06-23 09:16:38.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/82/97482/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/82/97482/2","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/82/97482/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/82/97482/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/82/97482/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/82/97482/2"}}},"commit":{"parents":[{"commit":"ee4547c94266ce0cf1de967a1044beab5cf19d47","subject":"Adding URL class for better encapsulation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/ee4547c94266ce0cf1de967a1044beab5cf19d47"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-05-29 12:21:53.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-23 09:16:05.000000000","tz":120},"subject":"Adding service catalog models","message":"Adding service catalog models\n\nIntroduces better abstraction for 5 interrelated models:\n\n- Catalog, which is a series of services returned from the API\n- CatalogEntry, which is in essence a service\n- Endpoint, which defines the various URLs a service uses for a\n  geographic region\n- Token, which defines the validation token used for all subsequent API\n  operations\n- Tenant, which defines the tenant or project authenticating\n\nThis patch is only meant to introduce these classes as a foundation for\nfuture KeyStone functionality. No integration is currently supported.\n\nChange-Id: I335ecdff7afdc88ef6d6c62e15c8d9ad498aed11\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/85526418eed80e4e0a0f2f2c895842322948cf07"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/85526418eed80e4e0a0f2f2c895842322948cf07"}]},"branch":"refs/heads/master"},"d4aebe417da9f0ea6934fc8c8316523c921f7bc7":{"kind":"REWORK","_number":3,"created":"2014-06-23 09:21:34.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/82/97482/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/82/97482/3","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/82/97482/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/82/97482/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/82/97482/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/82/97482/3"}}},"commit":{"parents":[{"commit":"ee4547c94266ce0cf1de967a1044beab5cf19d47","subject":"Adding URL class for better encapsulation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/ee4547c94266ce0cf1de967a1044beab5cf19d47"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-05-29 12:21:53.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-23 09:21:22.000000000","tz":120},"subject":"Adding service catalog models","message":"Adding service catalog models\n\nIntroduces better abstraction for 5 interrelated models:\n\n- Catalog, which is a series of services returned from the API\n- CatalogEntry, which is in essence a service\n- Endpoint, which defines the various URLs a service uses for a\n  geographic region\n- Token, which defines the validation token used for all subsequent API\n  operations\n- Tenant, which defines the tenant or project authenticating\n\nThis patch is only meant to introduce these classes as a foundation for\nfuture KeyStone functionality. No integration is currently supported.\n\nChange-Id: I335ecdff7afdc88ef6d6c62e15c8d9ad498aed11\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/d4aebe417da9f0ea6934fc8c8316523c921f7bc7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/d4aebe417da9f0ea6934fc8c8316523c921f7bc7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}