)]}'
{"id":"stackforge%2Fopenstack-sdk-php~99303","triplet_id":"stackforge%2Fopenstack-sdk-php~master~I2364c9414d4114f4271009054e9542f6a4880e20","project":"stackforge/openstack-sdk-php","branch":"master","topic":"stream-wrapper-fs-removal","hashtags":[],"change_id":"I2364c9414d4114f4271009054e9542f6a4880e20","subject":"Consolidating stream wrappers into one class","status":"ABANDONED","created":"2014-06-11 09:25:53.000000000","updated":"2015-10-17 19:23:15.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"167b2e2f7d2e49f983908a721a7c1918ce2e3914","_number":99303,"virtual_id_number":99303,"owner":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},{"date":"2015-10-17 19:23:15.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":-1,"date":"2014-10-13 15:11:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"all":[{"value":-1,"date":"2014-06-12 19:24:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"all":[{"value":-1,"date":"2014-08-20 20:02:39.000000000","_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},{"date":"2014-06-11 09:27:32.000000000","_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-06-11 09:27:32.000000000","_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"value":0,"date":"2014-06-12 19:46:00.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-06-11 09:27:32.000000000","updated_by":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"reviewer":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"state":"REVIEWER"},{"updated":"2014-06-11 09:27:32.000000000","updated_by":{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},"reviewer":{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},"state":"REVIEWER"},{"updated":"2014-08-20 20:02:39.000000000","updated_by":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"reviewer":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"state":"REVIEWER"},{"updated":"2014-10-13 15:11:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-10-17 19:23:15.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"}],"messages":[{"id":"c200c4a11218f3a1974d3fc6743fc48bc185e677","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-11 09:25:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"193891eed86364c2e1406cf6c682079db3a5bb5c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-11 09:25:54.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"2db3723e6fa5e66eaa48ef5011cfc2171392e327","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-11 09:25:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/03/99303/1/check/noop/5363ce0 : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3c4275d098ecf420425a9de2b23f4ab155b2d2f7","author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"date":"2014-06-12 19:24:22.000000000","message":"Patch Set 1: Code-Review-1\n\nThere is a step back in functionality here.\n\nIn the swiftfs version you can use mkdir and rmdir. For example, If there are objects on a path than rmdir will fail.\n\nThere are applications that would like to mount swift as a drive and this enables that. It was originally created because of applications treating filesystem like things as filesystems. It came out of actual use when we ran into needing it.\n\nThis more removes the swiftfs functionality rather than moving it over to the swift stream wrapper.","accounts_in_message":[],"_revision_number":1},{"id":"3e1434d9480d63e4163dfced1f1c8a3a0f8a9ea9","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-12 19:46:00.000000000","message":"Patch Set 1:\n\nI see where you\u0027re coming from, but I don\u0027t think it\u0027s a step back in functionality. It seems (and correct me if I\u0027m wrong) that the swiftfs protocol doesn\u0027t actually *do* anything for rmdir and mkdir - it currently just fakes the operation.\n\nThese two functions that now sit in swift:// do the exact same thing as they did before in swifts:// - but now they\u0027re just in a more coherent location with all the other filesystem functions.\n\nI\u0027m totally for these functions doing something but I was hesitant to introduce functionality because:\n\n1. We need to talk about how rmdir and mkdir will work first. Will they just create/delete containers? Or will they work on full paths and deal with pseudo-directories? etc.\n\n2. The scope of this patch was to merge two files together (two files that we\u0027re not convinced need to be separate). Adding in functionality, however helpful, is outside this patch\u0027s scope.\n\nWhat\u0027s your take on this?","accounts_in_message":[],"_revision_number":1},{"id":"0b222b2b4dcd66fa59c7ef17323b5e7da5b6a233","author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"date":"2014-08-20 20:02:39.000000000","message":"Patch Set 1: Workflow-1\n\nAn example of something that was in the FS version that\u0027s won\u0027t work after this change is rmdir used to return false if there were objects named with the path prefix. With this change the true/false on that doesn\u0027t work.\n\nThis is useful when trying to treat it as a file system. For example, if an existing tool expects it to be a filesystem but wrote it as a stream.","accounts_in_message":[],"_revision_number":1},{"id":"6c1ea25d30746f3274fff9e23cb9543bc555f135","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-13 15:11:32.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"55686fd858173ca05fb297b4a72b2a10a5769d09","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2015-10-17 19:23:15.000000000","message":"Patch Set 1:\n\nThis change has been abandoned because it belongs to a project that is part of the StackForge retirement. See http://governance.openstack.org/resolutions/20150615-stackforge-retirement.html for more details.","accounts_in_message":[],"_revision_number":1},{"id":"f0224a38b24c62fb59687c46fbe4afd0034e7552","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2015-10-17 19:23:15.000000000","message":"Abandoned\n\nThis change has been abandoned because it belongs to a project that is part of the StackForge retirement. See http://governance.openstack.org/resolutions/20150615-stackforge-retirement.html for more details.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4a4effb7683243f9a0d97fc9c3a947ba92066b05","revisions":{"4a4effb7683243f9a0d97fc9c3a947ba92066b05":{"kind":"REWORK","_number":1,"created":"2014-06-11 09:25:53.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/03/99303/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/03/99303/1","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/03/99303/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/03/99303/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/03/99303/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/03/99303/1"}}},"commit":{"parents":[{"commit":"061a3b784aefcffad8537ce0f0a1c9163645fea6","subject":"Merge \"Removing top-level bin and script dirs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/061a3b784aefcffad8537ce0f0a1c9163645fea6"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-11 09:20:09.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-11 09:20:13.000000000","tz":120},"subject":"Consolidating stream wrappers into one class","message":"Consolidating stream wrappers into one class\n\nCurrently we support two stream wrapper protocols: `swift://\u0027 and\n`swiftfs://\u0027. The first is our main class which does the majority of the\nheavy lifting, whilst the second doesn\u0027t really offer us much\nfunctionality in terms of an SDK. Although it attempts to reconcile the\noperational differences between a filesystem and Swift, we can actually\nachieve the same thing in 1 class.\n\nNote: this patch does not attempt to implement the functionality of\n`mkdir\u0027 and `rmdir\u0027 - it just merges two files into one. Since this\nfunctionality didn\u0027t exist prior to this patch, it is not a step\nbackwards. Another patch can implement this functionality.\n\nSince we do not have two stream wrappers any more, we do not need a\nshared test case. Logic can be added to the main stream wrapper test.\n\nChange-Id: I2364c9414d4114f4271009054e9542f6a4880e20\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/4a4effb7683243f9a0d97fc9c3a947ba92066b05"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/4a4effb7683243f9a0d97fc9c3a947ba92066b05"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}