)]}'
{"id":"stackforge%2Fopenstack-sdk-php~99633","triplet_id":"stackforge%2Fopenstack-sdk-php~master~I3e03b624d889a7a687ce630feef918ef9a24d015","project":"stackforge/openstack-sdk-php","branch":"master","topic":"new-copyright-headers","hashtags":[],"change_id":"I3e03b624d889a7a687ce630feef918ef9a24d015","subject":"Re-formatting and adding Rackspace to Copyright headers","status":"MERGED","created":"2014-06-12 11:38:59.000000000","updated":"2014-06-21 13:35:47.000000000","submitted":"2014-06-21 13:35:47.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":32,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dbf0fc35ad713f76dd3430f0ea58c0d8153d5a8c","_number":99633,"virtual_id_number":99633,"owner":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},{"value":0,"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},{"value":2,"date":"2014-06-21 13:35:47.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"value":0,"date":"2014-06-20 17:47:35.000000000","_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},{"value":0,"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},{"value":0,"_account_id":6711,"name":"Glen Campbell","email":"glen.campbell@rackspace.com","username":"glen-campbell"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},"recommended":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"all":[{"value":1,"date":"2014-06-20 17:00:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},{"value":2,"date":"2014-06-21 13:35:46.000000000","_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"value":1,"date":"2014-06-20 20:14:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},{"value":0,"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},{"value":0,"_account_id":6711,"name":"Glen Campbell","email":"glen.campbell@rackspace.com","username":"glen-campbell"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"all":[{"value":1,"date":"2014-06-20 17:00:05.000000000","_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},{"value":1,"date":"2014-06-21 13:35:46.000000000","_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"value":0,"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},{"value":0,"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},{"value":0,"_account_id":6711,"name":"Glen Campbell","email":"glen.campbell@rackspace.com","username":"glen-campbell"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6711,"name":"Glen Campbell","email":"glen.campbell@rackspace.com","username":"glen-campbell"},{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-06-12 11:41:28.000000000","updated_by":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"reviewer":{"_account_id":9700,"name":"Sam Choi","email":"sam.choi@hp.com","username":"samuelchoi"},"state":"REVIEWER"},{"updated":"2014-06-12 11:41:47.000000000","updated_by":{"_account_id":6711,"name":"Glen Campbell","email":"glen.campbell@rackspace.com","username":"glen-campbell"},"reviewer":{"_account_id":6711,"name":"Glen Campbell","email":"glen.campbell@rackspace.com","username":"glen-campbell"},"state":"REVIEWER"},{"updated":"2014-06-20 17:00:05.000000000","updated_by":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"reviewer":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"state":"REVIEWER"},{"updated":"2014-06-20 17:47:35.000000000","updated_by":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"reviewer":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"state":"REVIEWER"},{"updated":"2014-06-21 13:35:46.000000000","updated_by":{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},"reviewer":{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},"state":"REVIEWER"},{"updated":"2014-06-21 13:35:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"77bd1dc87e94953db9929fba918357995a7a0a3e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-12 11:38:59.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"01b67e1e4bf1e750202b7ec6573517bfae66cab1","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-12 11:38:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7b9a1ca41a415c19d238bc860a3ac6a9e8d90436","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-12 11:39:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/33/99633/1/check/noop/57dda1c : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8f365b09ef79053e8c5602073d78a0836c233366","author":{"_account_id":6711,"name":"Glen Campbell","email":"glen.campbell@rackspace.com","username":"glen-campbell"},"date":"2014-06-12 11:52:51.000000000","message":"Patch Set 1: Code-Review+1\n\nOk","accounts_in_message":[],"_revision_number":1},{"id":"6f27f0122d77b636b77546d94fc553d395036458","author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"date":"2014-06-12 18:50:28.000000000","message":"Patch Set 1: Code-Review-1\n\nThanks for cleaning this up. It\u0027s mostly good but I\u0027m going to nit-pick for a moment.\n\nThe start to the comment block is /*. I checked PSR-1/2 and they don\u0027t cover doing these blocks. But, PHPDoc and the proposed PSR on docs uses /** to open block comments.","accounts_in_message":[],"_revision_number":1},{"id":"32c57b0989541691a361e3090576216356f18b98","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-12 19:35:54.000000000","message":"Patch Set 1:\n\nI thought so too, but Composer, Symfony, Doctrine, Packagist, phpspec, Monolog ALL use this style - so I wanted to keep it consistent.\n\nPlus, I actually think it looks nicer. If you go to Github, the copyright notice becomes greyed out, whilst normal docblocks retain their highlighting. I like this because it hides the noise.","accounts_in_message":[],"_revision_number":1},{"id":"79e1beac0ec1230d3f8b0f913d93cd96cfe9f5eb","author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"date":"2014-06-20 13:46:16.000000000","message":"Patch Set 1: Code-Review-1\n\n(22 comments)\n\nI didn\u0027t completely get through all of the files as I think there\u0027s enough of a pattern here that I can assume the rest of them have some of the same issues.  There are several instances where the original copyright holder is being replaced instead of Rackspace just being added.  Is this by design?  If so, then it needs to be annotated.  Docs about multiple copyright holders are here: https://wiki.openstack.org/wiki/Documentation/Copyright\n\nThere are also several cases where the original copyright holder had the intent of displaying an ascii-friendly copyright notice but it was removed in addition to the new formatting.  It\u0027s unlikely to matter from a legal standpoint, but good practice to respect the original copyright holder\u0027s intent and leave the (c).","accounts_in_message":[],"_revision_number":1},{"id":"02d1ff8edd7c3116d8a538551ecb242de8b1ed1d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-20 13:46:23.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"c23f13ad2a883a0e709d5fec1571b8a1dae9f198","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-20 13:46:23.000000000","message":"Patch Set 1: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"88384049332aa25a489ef596587cf9b1ee92c1e0","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-20 13:55:34.000000000","message":"Patch Set 1:\n\n(10 comments)","accounts_in_message":[],"_revision_number":1},{"id":"bfd2a1f0e211262a1b2eb7eeaae356a077304dcc","author":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"date":"2014-06-20 14:43:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6552be80fc1c84cb4c31cc6256be405718f22c0a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-20 14:43:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/33/99633/2/check/noop/31fc4d0 : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"c855487cec2ab5d8c3ba9a3f81200c97ffbac51f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-20 14:43:31.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"b04371d01157823faaf8c4f10733469f4468f75e","author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"date":"2014-06-20 17:00:05.000000000","message":"Patch Set 2: Code-Review+1 Workflow+1\n\nAs Jamie has noted, the change in copyright is to fix an error that was previously committed. If there is an issue with the process of correcting this error please let us know.","accounts_in_message":[],"_revision_number":2},{"id":"8674e4cabc66632564db796ae07962343c70a1e0","author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"date":"2014-06-20 17:47:35.000000000","message":"Patch Set 2:\n\nMatt,  No problems I know of.  It just needed context.  Without explanation it looked a tad dubious.  The new commit message clears it up.","accounts_in_message":[],"_revision_number":2},{"id":"496620a7851e736f69c495e8b8889572f99b8dec","author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"date":"2014-06-20 20:14:25.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"7a1a2ab645d081886552235f27cccdb532b3ca49","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-21 13:35:46.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"e38c7294b76d245540488df3bbbce1bcf3c713b2","author":{"_account_id":10161,"name":"Shaunak Kashyap","email":"shaunak.kashyap@rackspace.com","username":"ycombinator"},"date":"2014-06-21 13:35:46.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM. Approving since we have a couple of +1s already.","accounts_in_message":[],"_revision_number":2},{"id":"f0b33a8660598814e8cf120b4b289c6b0480c6a0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-21 13:35:47.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"309fdda912f96bf0b1b18675a69c909352525c94","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-21 13:35:47.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded.\n\n- noop http://logs.openstack.org/33/99633/2/gate/noop/10d9aea : SUCCESS","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e8228ea2fc51cd9cd4ebfac2ae8e1952a2604207","revisions":{"5354b3e269fed1f22880792862bbc4b62aedd31b":{"kind":"REWORK","_number":1,"created":"2014-06-12 11:38:59.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/33/99633/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/33/99633/1","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/33/99633/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/33/99633/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/33/99633/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/33/99633/1"}}},"commit":{"parents":[{"commit":"061a3b784aefcffad8537ce0f0a1c9163645fea6","subject":"Merge \"Removing top-level bin and script dirs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/061a3b784aefcffad8537ce0f0a1c9163645fea6"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-12 11:33:16.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-12 11:33:16.000000000","tz":120},"subject":"Re-formatting and adding Rackspace to Copyright headers","message":"Re-formatting and adding Rackspace to Copyright headers\n\nChange-Id: I3e03b624d889a7a687ce630feef918ef9a24d015\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/5354b3e269fed1f22880792862bbc4b62aedd31b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/5354b3e269fed1f22880792862bbc4b62aedd31b"}]},"branch":"refs/heads/master"},"e8228ea2fc51cd9cd4ebfac2ae8e1952a2604207":{"kind":"REWORK","_number":2,"created":"2014-06-20 14:43:30.000000000","uploader":{"_account_id":10517,"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","username":"jamiehannaford"},"ref":"refs/changes/33/99633/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/stackforge/openstack-sdk-php","ref":"refs/changes/33/99633/2","commands":{"Checkout":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/33/99633/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/33/99633/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/33/99633/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/stackforge/openstack-sdk-php refs/changes/33/99633/2"}}},"commit":{"parents":[{"commit":"3c5bd1fa3c08f36485ef616b52dddceba369f20c","subject":"Remove red herring test","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/3c5bd1fa3c08f36485ef616b52dddceba369f20c"}]}],"author":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-12 11:33:16.000000000","tz":120},"committer":{"name":"Jamie Hannaford","email":"jamie.hannaford@rackspace.com","date":"2014-06-20 14:42:52.000000000","tz":120},"subject":"Re-formatting and adding Rackspace to Copyright headers","message":"Re-formatting and adding Rackspace to Copyright headers\n\nPreviously, all work submitted by Rackspace employees were done with\n\"Copyright OpenStack Foundation\" headers. This was done because we were\nuncertain about the correct legal solution; since then, we have been\ninstructed to label all our work with \"Rackspace US, Inc.\" copyrights\ninstead. This commit does that and reformats the docblock to a more\nconsistent style. Other PHP projects like Symfony, Composer, Doctrine,\netc. all do this.\n\nChange-Id: I3e03b624d889a7a687ce630feef918ef9a24d015\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/e8228ea2fc51cd9cd4ebfac2ae8e1952a2604207"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/stackforge/openstack-sdk-php/commit/e8228ea2fc51cd9cd4ebfac2ae8e1952a2604207"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}